From patchwork Fri Nov 21 18:44:32 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sterling Augustine X-Patchwork-Id: 413158 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 6940D1400E9 for ; Sat, 22 Nov 2014 05:45:08 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:date:message-id:subject:from:to :content-type; q=dns; s=default; b=YZTs10ht6VbuPiLb+15/VvXOU7WM+ cK1o7nXCDHCPQlbcrxGIlkcN6Tt50MUxKxRvtDweEiwcvFmgcvY16mXkiJeJ6QXo Qx4YSaO1Azdua2CB9qcmBT4fs5zIvrOfZasz7HZfcj8o4j7VDH+4pKq9HwQnlUX7 PO3GQsK7KRbIc0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:date:message-id:subject:from:to :content-type; s=default; bh=mdPjKQZLf2yX/T6vCnFgI69TnO8=; b=dLG V5dW3oAgc9x+VSLoDol7Bb6+3pl4Z7zkz1bOMriaCMwXs25LWQ2VF01iaXedqU+f Yf/di8B4Hu/a8GWAEU61iNt/8mOLAaCF/Rfc8QqzwSk8snFOPLFAnjV+bkHfqf1v oEg3DoJAFL3aQU69dDNYGa6t6kKdA3Dychz3CvgQ= Received: (qmail 28214 invoked by alias); 21 Nov 2014 18:44:36 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 28123 invoked by uid 89); 21 Nov 2014 18:44:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-oi0-f47.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=mDIG9CPlLf63i9IN9sG6/kiFkSgkSD+g2lajzY8EMME=; b=Ovns9p9mRk7ChGF25GCvwOWZ2+7itQ6zfkPZAVt1VO9l8VkdMlFZhkFXEPA8Wduqz7 dvnzuoHchAtGej5Hy19Vkh5oh4C9K7PR4H4R6hiZIP+hV1OiQkX4LKNxQDdHfcYHTBWG Jem5pbk4OQOiriHfRou3nD9xA9Q5Tqjo+8+MsdQi2eWX3XywRdpGd9gZqgoHd903T96X S7JALwwoHd4JUSs9hevQBsFUnmw9NeTxCQ7RieSdnWQXJaxrytmw33X58E+440HgCnOF WOLh53z0bB4fYHwEH/FPc8b+Rf1W743CZvx6Z2VCxqI+voZHrqPyqK0rqgpX8/8bHOtr FtMQ== X-Gm-Message-State: ALoCoQmWNvxQpPGRn0HH3u5m87T8cw61HFFYiEz9xI6Rp050TgPdc87p4vnBxDkJlOvp1VaXvLrI MIME-Version: 1.0 X-Received: by 10.202.205.200 with SMTP id d191mr3852848oig.37.1416595472176; Fri, 21 Nov 2014 10:44:32 -0800 (PST) Date: Fri, 21 Nov 2014 10:44:32 -0800 Message-ID: Subject: [Patch] Add .size directives to x86_64 start.S, and possibly more From: Sterling Augustine To: libc-alpha@sourceware.org, carlos@redhat.org Hello, sysdeps/x86_64/start.S doesn't have a .size elf directive for _start. This tripped up some analysis I was doing. This patch is the straightforward fix. Would you be interested in a similar fix for the ~150 assembly files inside x86_64 with similar issues? Sterling ChangeLog 2014-11-21 Sterling Augustine * sysdeps/x86_64/start.S: Add .size directive. diff --git a/sysdeps/x86_64/start.S b/sysdeps/x86_64/start.S index e3d4ff8..5106bd0 100644 --- a/sysdeps/x86_64/start.S +++ b/sysdeps/x86_64/start.S @@ -124,6 +124,7 @@ _start: hlt /* Crash if somehow `exit' does return. */ cfi_endproc + .size _start, .-_start /* Define a symbol for the first piece of initialized data. */ .data