Message ID | CAD82F-pTOmBmWk100nCQZHqtS+rhWScp5-dY5fdqF5F8XfP4Gw@mail.gmail.com |
---|---|
State | New |
Headers | show |
On Sat, 1 Aug 2015, Juan Manuel Torres Palma wrote: > + GLIBC_2.22 { > + __mmap; __munmap; __mprotect; > + } > GLIBC_2.3 { > # f* > fgetxattr; flistxattr; fremovexattr; fsetxattr; > > I don't know if I'm actually allowed to do that, but I think it makes sense. If a symbol only needs exporting for use in other shared libraries, not for inline functions in public headers, functions from libc_nonshared.a etc., then it should be exported at version GLIBC_PRIVATE. > I think the whole patch set is ready for C11 threads.h (Including > manual and tests), but I don't expect it to make it for version 2.22 > since it's frozen. Should I just send my patches here for a deep > review? Yes.
diff --git a/misc/Versions b/misc/Versions index 534d1a3..df2ffc8 100644 --- a/misc/Versions +++ b/misc/Versions @@ -108,6 +108,9 @@ libc { # p* posix_madvise; } + GLIBC_2.22 { + __mmap; __munmap; __mprotect; + } GLIBC_2.3 { # f* fgetxattr; flistxattr; fremovexattr; fsetxattr;