diff mbox series

i386: Use generic memrchr in libc (bug 31316)

Message ID 87zfw1aik9.fsf@oldenburg.str.redhat.com
State New
Headers show
Series i386: Use generic memrchr in libc (bug 31316) | expand

Commit Message

Florian Weimer Feb. 15, 2024, 2:49 p.m. UTC 
Before this change, we incorrectly use the SSE2 variant is the
implementation, without checking that the system actually supports
SSE2.

Tested-by: Sam James <sam@gentoo.org>

---
 sysdeps/i386/i686/multiarch/memrchr-c.c    | 1 +
 sysdeps/i386/i686/multiarch/memrchr-sse2.S | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)


base-commit: 491e55beab7457ed310a4a47496f4a333c5d1032

Comments

Andreas Schwab Feb. 15, 2024, 3:08 p.m. UTC | #1 
On Feb 15 2024, Florian Weimer wrote:

> Before this change, we incorrectly use the SSE2 variant is the

s/ is / in /

> implementation, without checking that the system actually supports
> SSE2.
Florian Weimer Feb. 15, 2024, 3:17 p.m. UTC | #2 
* Andreas Schwab:

> On Feb 15 2024, Florian Weimer wrote:
>
>> Before this change, we incorrectly use the SSE2 variant is the
>
> s/ is / in /
>
>> implementation, without checking that the system actually supports
>> SSE2.

Thanks, fixed locally.  Okay to push with that change?

Florian
H.J. Lu Feb. 15, 2024, 3:41 p.m. UTC | #3 
On Thu, Feb 15, 2024 at 7:18 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * Andreas Schwab:
>
> > On Feb 15 2024, Florian Weimer wrote:
> >
> >> Before this change, we incorrectly use the SSE2 variant is the
> >
> > s/ is / in /
> >
> >> implementation, without checking that the system actually supports
> >> SSE2.
>
> Thanks, fixed locally.  Okay to push with that change?
>
> Florian
>

Yes.

Thanks.
diff mbox series

Patch

diff --git a/sysdeps/i386/i686/multiarch/memrchr-c.c b/sysdeps/i386/i686/multiarch/memrchr-c.c
index ef7bbbe792..20bfdf3af3 100644
--- a/sysdeps/i386/i686/multiarch/memrchr-c.c
+++ b/sysdeps/i386/i686/multiarch/memrchr-c.c
@@ -5,3 +5,4 @@  extern void *__memrchr_ia32 (const void *, int, size_t);
 #endif
 
 #include "string/memrchr.c"
+strong_alias (__memrchr_ia32, __GI___memrchr)
diff --git a/sysdeps/i386/i686/multiarch/memrchr-sse2.S b/sysdeps/i386/i686/multiarch/memrchr-sse2.S
index d9dae04171..e123f87435 100644
--- a/sysdeps/i386/i686/multiarch/memrchr-sse2.S
+++ b/sysdeps/i386/i686/multiarch/memrchr-sse2.S
@@ -720,5 +720,4 @@  L(ret_null):
 	ret
 
 END (__memrchr_sse2)
-strong_alias (__memrchr_sse2, __GI___memrchr)
 #endif