Message ID | 87o8k1tr2o.fsf@oldenburg2.str.redhat.com |
---|---|
State | New |
Headers | show |
Series | alpha: Remove UP preprocessor conditionals | expand |
On 13/11/2020 08:49, Florian Weimer via Libc-alpha wrote: > The macro is never defined. > LGTM, thanks. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> > --- > sysdeps/alpha/atomic-machine.h | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/sysdeps/alpha/atomic-machine.h b/sysdeps/alpha/atomic-machine.h > index 3dc0133512..0904ed5688 100644 > --- a/sysdeps/alpha/atomic-machine.h > +++ b/sysdeps/alpha/atomic-machine.h > @@ -49,11 +49,7 @@ typedef uintmax_t uatomic_max_t; > #define ATOMIC_EXCHANGE_USES_CAS 1 > > > -#ifdef UP > -# define __MB /* nothing */ > -#else > -# define __MB " mb\n" > -#endif > +#define __MB " mb\n" > > > /* Compare and exchange. For all of the "xxx" routines, we expect a > @@ -363,8 +359,6 @@ typedef uintmax_t uatomic_max_t; > > */ > > -#ifndef UP > -# define atomic_full_barrier() __asm ("mb" : : : "memory"); > -# define atomic_read_barrier() __asm ("mb" : : : "memory"); > -# define atomic_write_barrier() __asm ("wmb" : : : "memory"); > -#endif > +#define atomic_full_barrier() __asm ("mb" : : : "memory"); > +#define atomic_read_barrier() __asm ("mb" : : : "memory"); > +#define atomic_write_barrier() __asm ("wmb" : : : "memory"); >
diff --git a/sysdeps/alpha/atomic-machine.h b/sysdeps/alpha/atomic-machine.h index 3dc0133512..0904ed5688 100644 --- a/sysdeps/alpha/atomic-machine.h +++ b/sysdeps/alpha/atomic-machine.h @@ -49,11 +49,7 @@ typedef uintmax_t uatomic_max_t; #define ATOMIC_EXCHANGE_USES_CAS 1 -#ifdef UP -# define __MB /* nothing */ -#else -# define __MB " mb\n" -#endif +#define __MB " mb\n" /* Compare and exchange. For all of the "xxx" routines, we expect a @@ -363,8 +359,6 @@ typedef uintmax_t uatomic_max_t; */ -#ifndef UP -# define atomic_full_barrier() __asm ("mb" : : : "memory"); -# define atomic_read_barrier() __asm ("mb" : : : "memory"); -# define atomic_write_barrier() __asm ("wmb" : : : "memory"); -#endif +#define atomic_full_barrier() __asm ("mb" : : : "memory"); +#define atomic_read_barrier() __asm ("mb" : : : "memory"); +#define atomic_write_barrier() __asm ("wmb" : : : "memory");