Message ID | 87cz97rv5u.fsf@oldenburg.str.redhat.com |
---|---|
State | New |
Headers | show |
Series | [v2] <time.h>: Make strptime available by default | expand |
On 28/11/22 11:49, Florian Weimer via Libc-alpha wrote: > This matches what FreeBSD does. > LGTM, thanks. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> > --- > v2: Remove unneccesary parentheses. > time/time.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/time/time.h b/time/time.h > index d18089116e..0919e578d4 100644 > --- a/time/time.h > +++ b/time/time.h > @@ -101,7 +101,7 @@ extern size_t strftime (char *__restrict __s, size_t __maxsize, > const char *__restrict __format, > const struct tm *__restrict __tp) __THROW; > > -#ifdef __USE_XOPEN > +#if defined __USE_XOPEN || defined __USE_MISC > /* Parse S according to FORMAT and store binary time information in TP. > The return value is a pointer to the first unparsed character in S. */ > extern char *strptime (const char *__restrict __s, > > base-commit: f704192911c6c7b65a54beab3ab369fca7609a5d >
* Adhemerval Zanella Netto: > On 28/11/22 11:49, Florian Weimer via Libc-alpha wrote: >> This matches what FreeBSD does. >> > > > LGTM, thanks. > > Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> > >> --- >> v2: Remove unneccesary parentheses. >> time/time.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/time/time.h b/time/time.h >> index d18089116e..0919e578d4 100644 >> --- a/time/time.h >> +++ b/time/time.h >> @@ -101,7 +101,7 @@ extern size_t strftime (char *__restrict __s, size_t __maxsize, >> const char *__restrict __format, >> const struct tm *__restrict __tp) __THROW; >> >> -#ifdef __USE_XOPEN >> +#if defined __USE_XOPEN || defined __USE_MISC >> /* Parse S according to FORMAT and store binary time information in TP. >> The return value is a pointer to the first unparsed character in S. */ >> extern char *strptime (const char *__restrict __s, >> >> base-commit: f704192911c6c7b65a54beab3ab369fca7609a5d >> I think this change has been vetoed by Andreas. I assume he wants us to define __USE_XOPEN by default to check all visiblities at once. Florian
On 08/12/22 15:13, Florian Weimer wrote: > * Adhemerval Zanella Netto: > >> On 28/11/22 11:49, Florian Weimer via Libc-alpha wrote: >>> This matches what FreeBSD does. >>> >> >> >> LGTM, thanks. >> >> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> >> >>> --- >>> v2: Remove unneccesary parentheses. >>> time/time.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/time/time.h b/time/time.h >>> index d18089116e..0919e578d4 100644 >>> --- a/time/time.h >>> +++ b/time/time.h >>> @@ -101,7 +101,7 @@ extern size_t strftime (char *__restrict __s, size_t __maxsize, >>> const char *__restrict __format, >>> const struct tm *__restrict __tp) __THROW; >>> >>> -#ifdef __USE_XOPEN >>> +#if defined __USE_XOPEN || defined __USE_MISC >>> /* Parse S according to FORMAT and store binary time information in TP. >>> The return value is a pointer to the first unparsed character in S. */ >>> extern char *strptime (const char *__restrict __s, >>> >>> base-commit: f704192911c6c7b65a54beab3ab369fca7609a5d >>> > > I think this change has been vetoed by Andreas. I assume he wants us to > define __USE_XOPEN by default to check all visiblities at once. > > Florian > Alright then, defining __USE_XOPEN works as well.
diff --git a/time/time.h b/time/time.h index d18089116e..0919e578d4 100644 --- a/time/time.h +++ b/time/time.h @@ -101,7 +101,7 @@ extern size_t strftime (char *__restrict __s, size_t __maxsize, const char *__restrict __format, const struct tm *__restrict __tp) __THROW; -#ifdef __USE_XOPEN +#if defined __USE_XOPEN || defined __USE_MISC /* Parse S according to FORMAT and store binary time information in TP. The return value is a pointer to the first unparsed character in S. */ extern char *strptime (const char *__restrict __s,