diff mbox series

[2/2] nptl: Link tst-execstack-threads-mod.so with -z execstack

Message ID 69bd76edaca4b5ce51ea716d249424f16c7929f9.1699896042.git.fweimer@redhat.com
State New
Headers show
Series [1/2] nptl: Rename tst-execstack to tst-execstack-threads | expand

Commit Message

Florian Weimer Nov. 13, 2023, 5:21 p.m. UTC
This ensures that the test still links with a linker that refuses
to create an executable stack marker automatically.
---
 nptl/Makefile | 1 +
 1 file changed, 1 insertion(+)

Comments

Adhemerval Zanella Netto Nov. 14, 2023, 7:57 p.m. UTC | #1
On 13/11/23 14:21, Florian Weimer wrote:
> This ensures that the test still links with a linker that refuses
> to create an executable stack marker automatically.

LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> ---
>  nptl/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/nptl/Makefile b/nptl/Makefile
> index 015295e45c..067b01ea8e 100644
> --- a/nptl/Makefile
> +++ b/nptl/Makefile
> @@ -671,6 +671,7 @@ tst-exec4-ARGS = $(host-test-program-cmd)
>  
>  $(objpfx)tst-execstack-threads.out: $(objpfx)tst-execstack-threads-mod.so
>  LDFLAGS-tst-execstack-threads = -Wl,-z,noexecstack
> +LDFLAGS-tst-execstack-threads-mod.so = -Wl,-z,execstack
>  CFLAGS-tst-execstack-threads-mod.c += -Wno-trampolines
>  
>  tst-stackguard1-ARGS = --command "$(host-test-program-cmd) --child"
diff mbox series

Patch

diff --git a/nptl/Makefile b/nptl/Makefile
index 015295e45c..067b01ea8e 100644
--- a/nptl/Makefile
+++ b/nptl/Makefile
@@ -671,6 +671,7 @@  tst-exec4-ARGS = $(host-test-program-cmd)
 
 $(objpfx)tst-execstack-threads.out: $(objpfx)tst-execstack-threads-mod.so
 LDFLAGS-tst-execstack-threads = -Wl,-z,noexecstack
+LDFLAGS-tst-execstack-threads-mod.so = -Wl,-z,execstack
 CFLAGS-tst-execstack-threads-mod.c += -Wno-trampolines
 
 tst-stackguard1-ARGS = --command "$(host-test-program-cmd) --child"