diff mbox series

[v3,19/32] elf: Split _dl_lookup_map, _dl_map_new_object from _dl_map_object

Message ID 67022e56b3c09868b8579f3bfceb80a41d3db659.1701944612.git.fweimer@redhat.com
State New
Headers show
Series RELRO linkmaps | expand

Commit Message

Florian Weimer Dec. 7, 2023, 10:32 a.m. UTC 
So that they can eventually be called separately from dlopen.
---
 elf/dl-load.c              | 43 ++++++++++++++++++++++++++------------
 sysdeps/generic/ldsodefs.h | 13 ++++++++++++
 2 files changed, 43 insertions(+), 13 deletions(-)

Comments

Joseph Myers Feb. 27, 2024, 5:56 p.m. UTC | #1 
On Thu, 7 Dec 2023, Florian Weimer wrote:

> +/* Like _dl_map_object, but assumes that NAME has not been loaded yet
> +   (_dl_lookmap returned NULL).  */

This comment should refer to _dl_lookup_map not _dl_lookmap.  OK with that 
fix.
diff mbox series

Patch

diff --git a/elf/dl-load.c b/elf/dl-load.c
index 5c9aaf2eec..d45ae48354 100644
--- a/elf/dl-load.c
+++ b/elf/dl-load.c
@@ -1904,24 +1904,14 @@  open_path (const char *name, size_t namelen, int mode,
   return -1;
 }
 
-/* Map in the shared object file NAME.  */
-
 struct link_map_private *
-_dl_map_object (struct link_map_private *loader, const char *name,
-		int type, int trace_mode, int mode, Lmid_t nsid)
+_dl_lookup_map (Lmid_t nsid, const char *name)
 {
-  int fd;
-  const char *origname = NULL;
-  char *realname;
-  char *name_copy;
-  struct link_map_private *l;
-  struct filebuf fb;
-
   assert (nsid >= 0);
   assert (nsid < GL(dl_nns));
 
-  /* Look for this name among those already loaded.  */
-  for (l = GL(dl_ns)[nsid]._ns_loaded; l; l = l_next (l))
+  for (struct link_map_private *l = GL(dl_ns)[nsid]._ns_loaded;
+       l != NULL; l = l_next (l))
     {
       /* If the requested name matches the soname of a loaded object,
 	 use that object.  Elide this check for names that have not
@@ -1950,6 +1940,22 @@  _dl_map_object (struct link_map_private *loader, const char *name,
       return l;
     }
 
+  return NULL;
+}
+
+/* Map in the shared object file NAME.  */
+
+struct link_map_private *
+_dl_map_new_object (struct link_map_private *loader, const char *name,
+		    int type, int trace_mode, int mode, Lmid_t nsid)
+{
+  int fd;
+  const char *origname = NULL;
+  char *realname;
+  char *name_copy;
+  struct link_map_private *l;
+  struct filebuf fb;
+
   /* Display information if we are debugging.  */
   if (__glibc_unlikely (GLRO(dl_debug_mask) & DL_DEBUG_FILES)
       && loader != NULL)
@@ -2204,6 +2210,17 @@  _dl_map_object (struct link_map_private *loader, const char *name,
 				 type, mode, &stack_end, nsid);
 }
 
+struct link_map_private *
+_dl_map_object (struct link_map_private *loader, const char *name,
+		int type, int trace_mode, int mode, Lmid_t nsid)
+{
+  struct link_map_private *l = _dl_lookup_map (nsid, name);
+  if (l != NULL)
+    return l;
+  return _dl_map_new_object (loader, name, type, trace_mode, mode, nsid);
+}
+
+
 struct add_path_state
 {
   bool counting;
diff --git a/sysdeps/generic/ldsodefs.h b/sysdeps/generic/ldsodefs.h
index d6d45f8c69..01f99a57b7 100644
--- a/sysdeps/generic/ldsodefs.h
+++ b/sysdeps/generic/ldsodefs.h
@@ -908,6 +908,11 @@  int _dl_catch_exception (struct dl_exception *exception,
 			 void (*operate) (void *), void *args);
 rtld_hidden_proto (_dl_catch_exception)
 
+/* Search NSID for a map with NAME.  If no such map is already loaded,
+   return NULL.  */
+struct link_map_private *_dl_lookup_map (Lmid_t nsid, const char *name)
+     attribute_hidden;
+
 /* Open the shared object NAME and map in its segments.
    LOADER's DT_RPATH is used in searching for NAME.
    If the object is already opened, returns its existing map.  */
@@ -916,6 +921,14 @@  struct link_map_private *_dl_map_object (struct link_map_private * loader,
 					 int type, int trace_mode, int mode,
 					 Lmid_t nsid) attribute_hidden;
 
+/* Like _dl_map_object, but assumes that NAME has not been loaded yet
+   (_dl_lookmap returned NULL).  */
+struct link_map_private *_dl_map_new_object (struct link_map_private * loader,
+					     const char *name,
+					     int type, int trace_mode, int mode,
+					     Lmid_t nsid) attribute_hidden;
+
+
 /* Call _dl_map_object on the dependencies of MAP, and set up
    MAP->l_searchlist.  PRELOADS points to a vector of NPRELOADS previously
    loaded objects that will be inserted into MAP->l_searchlist after MAP