From patchwork Mon Sep 14 13:57:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlos O'Donell X-Patchwork-Id: 517417 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 668C01400CB for ; Mon, 14 Sep 2015 23:57:58 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b=y5dJnYTr; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:from:subject:message-id:date:mime-version :content-type:content-transfer-encoding; q=dns; s=default; b=BT/ fb2T2uN67ZE43V3ebSy5d5Tk0vDClPlYTaeg0DQr4w4ehLQnX6ZCt7wZcBt3m5l2 8zrzZlaQ47bnUt6EP/yyAB3Ia3lhLrxWwqaqsQF3I8uJ7k8DOG+SacKspy6BsB4x 2Fqa/FDmpzqhdXMNkx7n1q/Ytp0TFdYwL/Q3LbD0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:from:subject:message-id:date:mime-version :content-type:content-transfer-encoding; s=default; bh=AahAQssLn xHG2HIBeB5wqr7Pi9Y=; b=y5dJnYTrCJ9jWDuOy/xyw7OHSnpSDwewkEZDLVHCA DtLxatdv4z3DbXwTiuucpeDdOBxJN+xHQxd+wNN73KaJbVo3P6Q4MqiR5swdrZ1o SyFR5Neuw5hzjVOrEK7jNagZDFhNjQe+Ir/9g1LoX3wO3f5en7bz5bkFHODA5MOj ZA= Received: (qmail 72318 invoked by alias); 14 Sep 2015 13:57:53 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 72306 invoked by uid 89); 14 Sep 2015 13:57:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_PASS, T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com To: GNU C Library From: "Carlos O'Donell" Subject: [COMMITTED] Fix check-local-headers when no input is found. Message-ID: <55F6D25B.9020409@redhat.com> Date: Mon, 14 Sep 2015 09:57:47 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 Consensus in [1] was that the right way to fix this was simply to redirect from /dev/null to terminate the test if no inputs was found by the tests own globbing e.g. "*/*.{o,os,oS}.d" This can happen when the build is incomplete and the tests are started. This failure causes check-local-headers.sh to hang forever waiting for input from stdin. This change makes the test terminate immediately if the glob doesn't return any files. [1] https://sourceware.org/ml/libc-alpha/2014-12/msg00337.html 2015-09-14 Carlos O'Donell * Makefile ($(objpfx)check-local-headers.out): Redirect stdin from /dev/null. --- Cheers, Carlos. diff --git a/Makefile b/Makefile index e07309e..a2abfb9 100644 --- a/Makefile +++ b/Makefile @@ -262,7 +262,7 @@ endif $(objpfx)check-local-headers.out: scripts/check-local-headers.sh AWK='$(AWK)' scripts/check-local-headers.sh \ - "$(includedir)" "$(objpfx)" > $@; \ + "$(includedir)" "$(objpfx)" < /dev/null > $@; \ $(evaluate-test) ifneq ($(PERL),no)