diff mbox

Remove unused defines from strxfrm_l.c and strcoll_l.c

Message ID 54D7271C.8060705@web.de
State New
Headers show

Commit Message

Leonhard Holz Feb. 8, 2015, 9:06 a.m. UTC 
* string/strxfrm_l.c: Remove #define STRCMP.
	* string/strcoll_l.c: Remove #define STRLEN.

Comments

Ondřej Bílka Feb. 8, 2015, 10:32 a.m. UTC | #1 
looks ok.

On Sun, Feb 08, 2015 at 10:06:36AM +0100, Leonhard Holz wrote:
> 	* string/strxfrm_l.c: Remove #define STRCMP.
> 	* string/strcoll_l.c: Remove #define STRLEN.
> 
> diff --git a/string/strxfrm_l.c b/string/strxfrm_l.c
> index 921d1f7..8b61ea2 100644
> --- a/string/strxfrm_l.c
> +++ b/string/strxfrm_l.c
> @@ -29,7 +29,6 @@
>  # define STRING_TYPE char
>  # define USTRING_TYPE unsigned char
>  # define STRXFRM __strxfrm_l
> -# define STRCMP strcmp
>  # define STRLEN strlen
>  # define STPNCPY __stpncpy
>  # define WEIGHT_H "../locale/weight.h"
> 
> diff --git a/string/strcoll_l.c b/string/strcoll_l.c
> index 85422bd..658d5b9 100644
> --- a/string/strcoll_l.c
> +++ b/string/strcoll_l.c
> @@ -30,7 +30,6 @@
>  # define USTRING_TYPE unsigned char
>  # define STRCOLL __strcoll_l
>  # define STRCMP strcmp
> -# define STRLEN strlen
>  # define WEIGHT_H "../locale/weight.h"
>  # define SUFFIX        MB
>  # define L(arg) arg
Carlos O'Donell Feb. 9, 2015, 8:07 p.m. UTC | #2 
On 02/08/2015 05:32 AM, Ondřej Bílka wrote:
> looks ok.
> 
> On Sun, Feb 08, 2015 at 10:06:36AM +0100, Leonhard Holz wrote:
>> 	* string/strxfrm_l.c: Remove #define STRCMP.
>> 	* string/strcoll_l.c: Remove #define STRLEN.
>>
>> diff --git a/string/strxfrm_l.c b/string/strxfrm_l.c
>> index 921d1f7..8b61ea2 100644
>> --- a/string/strxfrm_l.c
>> +++ b/string/strxfrm_l.c
>> @@ -29,7 +29,6 @@
>>  # define STRING_TYPE char
>>  # define USTRING_TYPE unsigned char
>>  # define STRXFRM __strxfrm_l
>> -# define STRCMP strcmp
>>  # define STRLEN strlen
>>  # define STPNCPY __stpncpy
>>  # define WEIGHT_H "../locale/weight.h"
>>
>> diff --git a/string/strcoll_l.c b/string/strcoll_l.c
>> index 85422bd..658d5b9 100644
>> --- a/string/strcoll_l.c
>> +++ b/string/strcoll_l.c
>> @@ -30,7 +30,6 @@
>>  # define USTRING_TYPE unsigned char
>>  # define STRCOLL __strcoll_l
>>  # define STRCMP strcmp
>> -# define STRLEN strlen
>>  # define WEIGHT_H "../locale/weight.h"
>>  # define SUFFIX        MB
>>  # define L(arg) arg
> 

I agree. This looks good to me. There is no need to define
macros we don't use.

Ondrej, Care to check this in for Leonhard?

Cheers,
Carlos.
diff mbox

Patch

diff --git a/string/strxfrm_l.c b/string/strxfrm_l.c
index 921d1f7..8b61ea2 100644
--- a/string/strxfrm_l.c
+++ b/string/strxfrm_l.c
@@ -29,7 +29,6 @@ 
  # define STRING_TYPE char
  # define USTRING_TYPE unsigned char
  # define STRXFRM __strxfrm_l
-# define STRCMP strcmp
  # define STRLEN strlen
  # define STPNCPY __stpncpy
  # define WEIGHT_H "../locale/weight.h"

diff --git a/string/strcoll_l.c b/string/strcoll_l.c
index 85422bd..658d5b9 100644
--- a/string/strcoll_l.c
+++ b/string/strcoll_l.c
@@ -30,7 +30,6 @@ 
  # define USTRING_TYPE unsigned char
  # define STRCOLL __strcoll_l
  # define STRCMP strcmp
-# define STRLEN strlen
  # define WEIGHT_H "../locale/weight.h"
  # define SUFFIX        MB
  # define L(arg) arg