Message ID | 3e5a8fac-dd5c-4cff-8b4e-a036dfeb00d9@BAMAIL02.ba.imgtec.org |
---|---|
State | New |
Headers | show |
On Wed, 7 Oct 2015, Steve Ellcey wrote: > So my question is, what do we want to do in glibc? It seems > like there are two options, either getting the tz group to > add unused attributes to these definitions or to compile the > timezone files with the -Wno-unused-variable option. I am > inclined to go with the second option and created a patch > to do that, what do others think? I think adding the option is fine as long as it works with all GCC versions supported for building glibc (whether through being directly recognized, or through the general support for ignoring unknown -Wno- options if no warnings are generated) and as long as there's a comment explaining why this option is present.
diff --git a/timezone/Makefile b/timezone/Makefile index a0b8adb..2ddefbe 100644 --- a/timezone/Makefile +++ b/timezone/Makefile @@ -64,9 +64,9 @@ tz-cflags = -DTZDIR='"$(zonedir)"' \ -DTM_GMTOFF=tm_gmtoff -DTM_ZONE=tm_zone CFLAGS-zdump.c = -fwrapv -DNOID $(tz-cflags) -DHAVE_GETTEXT -CFLAGS-zic.c = -DNOID $(tz-cflags) -DHAVE_GETTEXT -CFLAGS-ialloc.c = -DNOID -DHAVE_GETTEXT -CFLAGS-scheck.c = -DNOID -DHAVE_GETTEXT +CFLAGS-zic.c = -DNOID $(tz-cflags) -DHAVE_GETTEXT -Wno-unused-variable +CFLAGS-ialloc.c = -DNOID -DHAVE_GETTEXT -Wno-unused-variable +CFLAGS-scheck.c = -DNOID -DHAVE_GETTEXT -Wno-unused-variable # We have to make sure the data for testing the tz functions is available. # Don't add leapseconds here since test-tz made checks that work only without