From patchwork Tue Apr 30 12:40:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 1929492 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=mBgf+AUu; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VTKYL596Tz20fY for ; Tue, 30 Apr 2024 22:40:38 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8E11F3858C56 for ; Tue, 30 Apr 2024 12:40:36 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id 30282385E836 for ; Tue, 30 Apr 2024 12:40:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 30282385E836 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 30282385E836 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::430 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714480819; cv=none; b=pgH/auCEmUuMFDRTtaA4u5vPB7dQCk7WdNBMKje23eYu797Tvuww/4To6L3b2V3dRLrQDJcWcNL6opPWoqIWVRNupD+H8UdUw/m4GdxmpFczyFsaVXyK8SiTckg+GcDG50S+BCOh0Bf6wmuCPa8XwB4w5IkEG7jVnO2x2W4+pVU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714480819; c=relaxed/simple; bh=SQ8it3tkDpRgATyCSEoTBYiX7NmNyc6f71zH8cTLpM0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=qlbBylAk0+havoqycjBejO+fYeUR5mrTaPIfpQPZiSvVu84qoASnBlFTs9CFQjB3H2newAU6Ojyp44XgsW/qkX9yL3PXLAPSIEIS9ZzP3ZnxDQ05ZCpiiNRsUO2tsz12tcckkzZnOra81at6mmwT1SrcuQIYGI3z0M+uBJjVwkE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-6ed9fc77bbfso4372105b3a.1 for ; Tue, 30 Apr 2024 05:40:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714480816; x=1715085616; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8A5nItnyES57zjsqWEteQRaBAP+fF5e/wyPUv2P+mc0=; b=mBgf+AUul44HX7FiE829bnv4LzeW4N3uZ9iZucBok4UTcTkqZ2OIWEOceCin9bDoay tHEGbZ0NBd7pUuFJi6tsmIYGtlRpj/ZYbChoRc0XSg6OfSWTsfUfj642tn2Z7U1LWfSa +G4Oa0/QjTwPp56hyLDREJ2Zz18wI4JILLOs4SknMvt5e3arpzds4n+8S9ItH7LJDShe erlqxGrRX50OaUJmX/P2bMAHSxbVwjUmANgkYjGINQdAyEvqTUfYibDPMRHYtFgPuqg7 03Nmh8NsC9Ijymu+PRb34HRgarj8I+J9do/mzrw0uf3o4nz3WeFrs1XgqCxePdhmHyBA 88FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714480816; x=1715085616; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8A5nItnyES57zjsqWEteQRaBAP+fF5e/wyPUv2P+mc0=; b=p/nfkuunzTyFrgfP/UsISI53+aNWP51HNyFyJJpI6lXwrgkbYUj20AJtFEqSik6N3R aFARn0aIE3zQxaZOlnlq8IAAktidWmb7MP7U5gMICvN5KwNn+EJ9Qdf5YwFlfrnA4Z6H zDTRUp+8v+m34LRY51Xv+HCXbSZ9g/myv8yUv6MSZHPBouOcSXeuqU1OcX7t/x/wj7i3 LhEVS7XquYN80h4QsDeAhW8XdYyzsU7xhVDus7+SEkp9D8XWGCtxPCfBd3jih3Izitjv 8Yh4Z0yxZidwlRJ2g6MR31fzfbzWyW78dhvq0KI3ul3Ev/hvnMuYRrpu3sYzK3PFLlNt JA2A== X-Gm-Message-State: AOJu0YzXN05dgw8511qjKZkvC30LfXxMV+vYEDzv7hDPth+1sM2bDs+w FIIJfKXSR3crzo/Mu/snzPd/tvQgKg7U5FBQfy7TZgDaaUVGXK80VeK1Tr8k5k+mWTIsY/I/roG q X-Google-Smtp-Source: AGHT+IFQ8OcgZK0bpq2Yt1duXNx4rpBvdcvcIQWkXyoGtpRG7DaLgGT7Lj49TWdeWaw0jOiXzP7Oew== X-Received: by 2002:a05:6a21:3943:b0:1af:4faf:e4a8 with SMTP id ac3-20020a056a21394300b001af4fafe4a8mr5863207pzc.33.1714480815671; Tue, 30 Apr 2024 05:40:15 -0700 (PDT) Received: from mandiga.. ([2804:1b3:a7c1:e3c5:c9b5:f382:64ea:c32b]) by smtp.gmail.com with ESMTPSA id e4-20020aa79804000000b006ecc858b67fsm21705144pfl.175.2024.04.30.05.40.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 05:40:15 -0700 (PDT) From: Adhemerval Zanella To: libc-alpha@sourceware.org Cc: Manjunath S Matti , Peter Bergner Subject: [PATCH] powerpc: Fix __fesetround_inline_nocheck on POWER9+ (BZ 31682) Date: Tue, 30 Apr 2024 09:40:06 -0300 Message-ID: <20240430124011.12408-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org The e68b1151f7460d5fa88c3a567c13f66052da79a7 commit changed the __fesetround_inline_nocheck implementation to use mffscrni (through __fe_mffscrn) instead of mtfsfi. For generic powerpc ceil/floor/trunc, the function is supposed to not change the Floating-Point Inexact Exception Enable bit, however mffscrni clear bits 56:63 (VE, OE, UE, ZE, XE, NI, RN), different than mtfsfi. This patch fixes by reverting the optimization for the __fesetround_inline_nocheck. Checked on powerpc-linux-gnu. --- sysdeps/powerpc/fpu/fenv_libc.h | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/sysdeps/powerpc/fpu/fenv_libc.h b/sysdeps/powerpc/fpu/fenv_libc.h index f9167056a8..afcf8d2e61 100644 --- a/sysdeps/powerpc/fpu/fenv_libc.h +++ b/sysdeps/powerpc/fpu/fenv_libc.h @@ -182,19 +182,13 @@ __fesetround_inline (int round) return 0; } -/* Same as __fesetround_inline, however without runtime check to use DFP - mtfsfi syntax (as relax_fenv_state) or if round value is valid. */ +/* Same as __fesetround_inline, but it does not change the floating-point + exceptions bits, and without runtime check to use DFP mtfsfi syntax + (as relax_fenv_state), or if round value is valid. */ static inline void __fesetround_inline_nocheck (const int round) { -#ifdef _ARCH_PWR9 - __fe_mffscrn (round); -#else - if (__glibc_likely (GLRO(dl_hwcap2) & PPC_FEATURE2_ARCH_3_00)) - __fe_mffscrn (round); - else - asm volatile ("mtfsfi 7,%0" : : "n" (round)); -#endif + asm volatile ("mtfsfi 7,%0" : : "n" (round)); } #define FPSCR_MASK(bit) (1 << (31 - (bit)))