From patchwork Thu Aug 24 08:50:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: dengjianbo X-Patchwork-Id: 1825189 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RWcJk69gfz1yg8 for ; Thu, 24 Aug 2023 18:51:50 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EBCE23857027 for ; Thu, 24 Aug 2023 08:51:48 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 6D2B73858401 for ; Thu, 24 Aug 2023 08:50:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6D2B73858401 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [10.2.5.5]) by gateway (Coremail) with SMTP id _____8AxCPLPGedk8XIbAA--.56044S3; Thu, 24 Aug 2023 16:50:23 +0800 (CST) Received: from 5.5.5 (unknown [10.2.5.5]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxriPMGedkoTBiAA--.1934S3; Thu, 24 Aug 2023 16:50:22 +0800 (CST) From: dengjianbo To: libc-alpha@sourceware.org Cc: adhemerval.zanella@linaro.org, xry111@xry111.site, caiyinyu@loongson.cn, xuchenghua@loongson.cn, huangpei@loongson.cn, dengjianbo Subject: [PATCH v2 2/3] LoongArch: Add ifunc support for strcmp{aligned, lsx} Date: Thu, 24 Aug 2023 16:50:18 +0800 Message-Id: <20230824085019.2608438-2-dengjianbo@loongson.cn> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20230824085019.2608438-1-dengjianbo@loongson.cn> References: <20230824085019.2608438-1-dengjianbo@loongson.cn> MIME-Version: 1.0 X-CM-TRANSID: AQAAf8CxriPMGedkoTBiAA--.1934S3 X-CM-SenderInfo: pghqwyxldqu0o6or00hjvr0hdfq/ X-Coremail-Antispam: 1Uk129KBj9fXoW3uFW3Aw15XrW5ZFWDuF17Jwc_yoW8Jr4fuo WSqFWqqrs2kw1YqrZ7C3WDX3srGrWfKr12q3y2va1rJw1Fgryakryru3ZI9rsrKrn5uFs5 Za4IvFZxArZrKF1kl-sFpf9Il3svdjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8wcxFpf 9Il3svdxBIdaVrn0xqx4xG64xvF2IEw4CE5I8CrVC2j2Jv73VFW2AGmfu7bjvjm3AaLaJ3 UjIYCTnIWjp_UUUY17kC6x804xWl14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI 8IcIk0rVWrJVCq3wAFIxvE14AKwVWUXVWUAwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xG Y2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7xvwVC0I7IYx2IY6xkF7I0E14 v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I8E87Iv6xkF7I0E 14v26F4UJVW0owAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYIkI8VC2zVCFFI 0UMc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUXVWUAwAv7VC2z280 aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JMxAIw28Icx kI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2Iq xVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42 IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY 6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aV CY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxU7_MaUUUUU X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_SHORT, KAM_STOCKGEN, SCC_5_SHORT_WORD_LINES, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org Sender: "Libc-alpha" Based on the glibc microbenchmark, strcmp-aligned implementation could reduce the runtime 0%-10% for aligned comparison, 10%-20% for unaligned comparison, strcmp-lsx implemenation could reduce the runtime 0%-50%. --- sysdeps/loongarch/lp64/multiarch/Makefile | 2 + .../lp64/multiarch/ifunc-impl-list.c | 7 + .../loongarch/lp64/multiarch/ifunc-strcmp.h | 38 ++++ .../loongarch/lp64/multiarch/strcmp-aligned.S | 179 ++++++++++++++++++ sysdeps/loongarch/lp64/multiarch/strcmp-lsx.S | 165 ++++++++++++++++ sysdeps/loongarch/lp64/multiarch/strcmp.c | 35 ++++ 6 files changed, 426 insertions(+) create mode 100644 sysdeps/loongarch/lp64/multiarch/ifunc-strcmp.h create mode 100644 sysdeps/loongarch/lp64/multiarch/strcmp-aligned.S create mode 100644 sysdeps/loongarch/lp64/multiarch/strcmp-lsx.S create mode 100644 sysdeps/loongarch/lp64/multiarch/strcmp.c diff --git a/sysdeps/loongarch/lp64/multiarch/Makefile b/sysdeps/loongarch/lp64/multiarch/Makefile index c4dd3143d1..d5a500decd 100644 --- a/sysdeps/loongarch/lp64/multiarch/Makefile +++ b/sysdeps/loongarch/lp64/multiarch/Makefile @@ -12,6 +12,8 @@ sysdep_routines += \ strchrnul-aligned \ strchrnul-lsx \ strchrnul-lasx \ + strcmp-aligned \ + strcmp-lsx \ memcpy-aligned \ memcpy-unaligned \ memmove-unaligned \ diff --git a/sysdeps/loongarch/lp64/multiarch/ifunc-impl-list.c b/sysdeps/loongarch/lp64/multiarch/ifunc-impl-list.c index 7cec0b7724..9183b7da24 100644 --- a/sysdeps/loongarch/lp64/multiarch/ifunc-impl-list.c +++ b/sysdeps/loongarch/lp64/multiarch/ifunc-impl-list.c @@ -62,6 +62,13 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array, IFUNC_IMPL_ADD (array, i, strchrnul, 1, __strchrnul_aligned) ) + IFUNC_IMPL (i, name, strcmp, +#if !defined __loongarch_soft_float + IFUNC_IMPL_ADD (array, i, strcmp, SUPPORT_LSX, __strcmp_lsx) +#endif + IFUNC_IMPL_ADD (array, i, strcmp, 1, __strcmp_aligned) + ) + IFUNC_IMPL (i, name, memcpy, #if !defined __loongarch_soft_float IFUNC_IMPL_ADD (array, i, memcpy, SUPPORT_LASX, __memcpy_lasx) diff --git a/sysdeps/loongarch/lp64/multiarch/ifunc-strcmp.h b/sysdeps/loongarch/lp64/multiarch/ifunc-strcmp.h new file mode 100644 index 0000000000..ca26352bec --- /dev/null +++ b/sysdeps/loongarch/lp64/multiarch/ifunc-strcmp.h @@ -0,0 +1,38 @@ +/* Common definition for strcmp ifunc selection. + All versions must be listed in ifunc-impl-list.c. + Copyright (C) 2023 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include + +#if !defined __loongarch_soft_float +extern __typeof (REDIRECT_NAME) OPTIMIZE (lsx) attribute_hidden; +#endif + +extern __typeof (REDIRECT_NAME) OPTIMIZE (aligned) attribute_hidden; + +static inline void * +IFUNC_SELECTOR (void) +{ +#if !defined __loongarch_soft_float + if (SUPPORT_LSX) + return OPTIMIZE (lsx); + else +#endif + return OPTIMIZE (aligned); +} diff --git a/sysdeps/loongarch/lp64/multiarch/strcmp-aligned.S b/sysdeps/loongarch/lp64/multiarch/strcmp-aligned.S new file mode 100644 index 0000000000..f5f4f3364e --- /dev/null +++ b/sysdeps/loongarch/lp64/multiarch/strcmp-aligned.S @@ -0,0 +1,179 @@ +/* Optimized strcmp implementation using basic Loongarch instructions. + Copyright (C) 2023 Free Software Foundation, Inc. + + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library. If not, see + . */ + +#include +#include +#include + +#if IS_IN (libc) +# define STRCMP_NAME __strcmp_aligned +#else +# define STRCMP_NAME strcmp +#endif + +LEAF(STRCMP_NAME, 6) + lu12i.w a4, 0x01010 + andi a2, a0, 0x7 + ori a4, a4, 0x101 + andi a3, a1, 0x7 + + bstrins.d a4, a4, 63, 32 + li.d t7, -1 + li.d t8, 8 + slli.d a5, a4, 7 + + bne a2, a3, L(unaligned) + bstrins.d a0, zero, 2, 0 + bstrins.d a1, zero, 2, 0 + ld.d t0, a0, 0 + + ld.d t1, a1, 0 + slli.d t3, a2, 3 + sll.d t2, t7, t3 + orn t0, t0, t2 + + + orn t1, t1, t2 + sub.d t2, t0, a4 + andn t3, a5, t0 + and t2, t2, t3 + + bne t0, t1, L(al_end) +L(al_loop): + bnez t2, L(ret0) + ldx.d t0, a0, t8 + ldx.d t1, a1, t8 + + addi.d t8, t8, 8 + sub.d t2, t0, a4 + andn t3, a5, t0 + and t2, t2, t3 + + beq t0, t1, L(al_loop) +L(al_end): + xor t3, t0, t1 + or t2, t2, t3 + ctz.d t3, t2 + + + bstrins.d t3, zero, 2, 0 + srl.d t0, t0, t3 + srl.d t1, t1, t3 + andi t0, t0, 0xff + + andi t1, t1, 0xff + sub.d a0, t0, t1 + jr ra + nop + +L(ret0): + move a0, zero + jr ra + nop + nop + +L(unaligned): + slt a6, a3, a2 + xor t0, a0, a1 + maskeqz t0, t0, a6 + xor a0, a0, t0 + + + xor a1, a1, t0 + andi a2, a0, 0x7 + andi a3, a1, 0x7 + bstrins.d a0, zero, 2, 0 + + bstrins.d a1, zero, 2, 0 + ld.d t4, a0, 0 + ld.d t1, a1, 0 + slli.d a2, a2, 3 + + slli.d a3, a3, 3 + srl.d t0, t4, a2 + srl.d t1, t1, a3 + srl.d t5, t7, a3 + + orn t0, t0, t5 + orn t1, t1, t5 + bne t0, t1, L(not_equal) + sll.d t5, t7, a2 + + + sub.d a3, a2, a3 + orn t4, t4, t5 + sub.d a2, zero, a3 + sub.d t2, t4, a4 + + andn t3, a5, t4 + and t2, t2, t3 + bnez t2, L(find_zero) +L(un_loop): + srl.d t5, t4, a3 + + ldx.d t4, a0, t8 + ldx.d t1, a1, t8 + addi.d t8, t8, 8 + sll.d t0, t4, a2 + + or t0, t0, t5 + bne t0, t1, L(not_equal) + sub.d t2, t4, a4 + andn t3, a5, t4 + + + and t2, t2, t3 + beqz t2, L(un_loop) +L(find_zero): + sub.d t2, t0, a4 + andn t3, a5, t0 + + and t2, t2, t3 + bnez t2, L(ret0) + ldx.d t1, a1, t8 + srl.d t0, t4, a3 + +L(not_equal): + sub.d t2, t0, a4 + andn t3, a5, t0 + and t2, t2, t3 + xor t3, t0, t1 + + or t2, t2, t3 +L(un_end): + ctz.d t3, t2 + bstrins.d t3, zero, 2, 0 + srl.d t0, t0, t3 + + + srl.d t1, t1, t3 + andi t0, t0, 0xff + andi t1, t1, 0xff + sub.d t2, t0, t1 + + + sub.d t3, t1, t0 + masknez t0, t2, a6 + maskeqz t1, t3, a6 + or a0, t0, t1 + + jr ra +END(STRCMP_NAME) + +libc_hidden_builtin_def (STRCMP_NAME) diff --git a/sysdeps/loongarch/lp64/multiarch/strcmp-lsx.S b/sysdeps/loongarch/lp64/multiarch/strcmp-lsx.S new file mode 100644 index 0000000000..2e177a3872 --- /dev/null +++ b/sysdeps/loongarch/lp64/multiarch/strcmp-lsx.S @@ -0,0 +1,165 @@ +/* Optimized strcmp implementation using Loongarch LSX instructions. + Copyright (C) 2023 Free Software Foundation, Inc. + + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library. If not, see + . */ + +#include +#include +#include + +#if IS_IN (libc) && !defined __loongarch_soft_float + +# define STRCMP __strcmp_lsx + +LEAF(STRCMP, 6) + pcalau12i t0, %pc_hi20(L(INDEX)) + andi a2, a0, 0xf + vld vr2, t0, %pc_lo12(L(INDEX)) + andi a3, a1, 0xf + + bne a2, a3, L(unaligned) + bstrins.d a0, zero, 3, 0 + bstrins.d a1, zero, 3, 0 + vld vr0, a0, 0 + + vld vr1, a1, 0 + vreplgr2vr.b vr3, a2 + vslt.b vr2, vr2, vr3 + vseq.b vr3, vr0, vr1 + + vmin.bu vr3, vr0, vr3 + vor.v vr3, vr3, vr2 + vsetanyeqz.b fcc0, vr3 + bcnez fcc0, L(al_out) + + +L(al_loop): + vld vr0, a0, 16 + vld vr1, a1, 16 + addi.d a0, a0, 16 + addi.d a1, a1, 16 + + vseq.b vr3, vr0, vr1 + vmin.bu vr3, vr0, vr3 + vsetanyeqz.b fcc0, vr3 + bceqz fcc0, L(al_loop) + +L(al_out): + vseqi.b vr3, vr3, 0 + vfrstpi.b vr3, vr3, 0 + vshuf.b vr0, vr0, vr0, vr3 + vshuf.b vr1, vr1, vr1, vr3 + + vpickve2gr.bu t0, vr0, 0 + vpickve2gr.bu t1, vr1, 0 + sub.d a0, t0, t1 + jr ra + + +L(unaligned): + slt a4, a3, a2 + xor t0, a0, a1 + maskeqz t0, t0, a4 + xor a0, a0, t0 + + xor a1, a1, t0 + andi a2, a0, 0xf + andi a3, a1, 0xf + bstrins.d a0, zero, 3, 0 + + bstrins.d a1, zero, 3, 0 + vld vr3, a0, 0 + vld vr1, a1, 0 + vreplgr2vr.b vr4, a2 + + vreplgr2vr.b vr5, a3 + vslt.b vr7, vr2, vr5 + vsub.b vr5, vr5, vr4 + vaddi.bu vr6, vr2, 16 + + + vsub.b vr6, vr6, vr5 + vshuf.b vr0, vr3, vr3, vr6 + vor.v vr0, vr0, vr7 + vor.v vr1, vr1, vr7 + + vseq.b vr5, vr0, vr1 + vsetanyeqz.b fcc0, vr5 + bcnez fcc0, L(not_equal) + vslt.b vr4, vr2, vr4 + + vor.v vr0, vr3, vr4 + vsetanyeqz.b fcc0, vr0 + bcnez fcc0, L(find_zero) + nop + +L(un_loop): + vld vr3, a0, 16 + vld vr1, a1, 16 + addi.d a0, a0, 16 + addi.d a1, a1, 16 + + + vshuf.b vr0, vr3, vr0, vr6 + vseq.b vr5, vr0, vr1 + vsetanyeqz.b fcc0, vr5 + bcnez fcc0, L(not_equal) + + vsetanyeqz.b fcc0, vr3 + vor.v vr0, vr3, vr3 + bceqz fcc0, L(un_loop) +L(find_zero): + vmin.bu vr5, vr1, vr5 + + vsetanyeqz.b fcc0, vr5 + bcnez fcc0, L(ret0) + vld vr1, a1, 16 + vshuf.b vr0, vr3, vr3, vr6 + + vseq.b vr5, vr0, vr1 +L(not_equal): + vmin.bu vr5, vr0, vr5 +L(un_end): + vseqi.b vr5, vr5, 0 + vfrstpi.b vr5, vr5, 0 + + + vshuf.b vr0, vr0, vr0, vr5 + vshuf.b vr1, vr1, vr1, vr5 + vpickve2gr.bu t0, vr0, 0 + vpickve2gr.bu t1, vr1, 0 + + sub.d t3, t0, t1 + sub.d t4, t1, t0 + masknez t0, t3, a4 + maskeqz t1, t4, a4 + + or a0, t0, t1 + jr ra +L(ret0): + move a0, zero + jr ra +END(STRCMP) + + .section .rodata.cst16,"M",@progbits,16 + .align 4 +L(INDEX): + .dword 0x0706050403020100 + .dword 0x0f0e0d0c0b0a0908 + +libc_hidden_builtin_def (STRCMP) +#endif diff --git a/sysdeps/loongarch/lp64/multiarch/strcmp.c b/sysdeps/loongarch/lp64/multiarch/strcmp.c new file mode 100644 index 0000000000..6f249c0b59 --- /dev/null +++ b/sysdeps/loongarch/lp64/multiarch/strcmp.c @@ -0,0 +1,35 @@ +/* Multiple versions of strcmp. + All versions must be listed in ifunc-impl-list.c. + Copyright (C) 2023 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +/* Define multiple versions only for the definition in libc. */ +#if IS_IN (libc) +# define strcmp __redirect_strcmp +# include +# undef strcmp + +# define SYMBOL_NAME strcmp +# include "ifunc-strcmp.h" + +libc_ifunc_redirected (__redirect_strcmp, strcmp, IFUNC_SELECTOR ()); + +# ifdef SHARED +__hidden_ver1 (strcmp, __GI_strcmp, __redirect_strcmp) + __attribute__ ((visibility ("hidden"))) __attribute_copy__ (strcmp); +# endif +#endif