diff mbox series

resolv/nss_dns/dns-host: Get rid of alloca.

Message ID 20230810151356.743825-1-josimmon@redhat.com
State New
Headers show
Series resolv/nss_dns/dns-host: Get rid of alloca. | expand

Commit Message

Joe Simmons-Talbott Aug. 10, 2023, 3:13 p.m. UTC 
Since the alloca is a small constant size use an array instead.
---
 resolv/nss_dns/dns-host.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andreas Schwab Aug. 10, 2023, 3:28 p.m. UTC | #1 
On Aug 10 2023, Joe Simmons-Talbott via Libc-alpha wrote:

>        const char *cp = __res_context_hostalias (ctx, name, tmp, NS_MAXDNAME);

Please use sizeof (tmp).

Ok with that change.
Joe Simmons-Talbott Aug. 10, 2023, 3:58 p.m. UTC | #2 
On Thu, Aug 10, 2023 at 05:28:08PM +0200, Andreas Schwab wrote:
> On Aug 10 2023, Joe Simmons-Talbott via Libc-alpha wrote:
> 
> >        const char *cp = __res_context_hostalias (ctx, name, tmp, NS_MAXDNAME);
> 
> Please use sizeof (tmp).

Fixed in v2.

Thanks,
Joe
> 
> Ok with that change.
> 
> -- 
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."
>
diff mbox series

Patch

diff --git a/resolv/nss_dns/dns-host.c b/resolv/nss_dns/dns-host.c
index 1d60c51f5e..f752b7cf4b 100644
--- a/resolv/nss_dns/dns-host.c
+++ b/resolv/nss_dns/dns-host.c
@@ -378,6 +378,7 @@  _nss_dns_gethostbyname4_r (const char *name, struct gaih_addrtuple **pat,
 			   int *herrnop, int32_t *ttlp)
 {
   enum nss_status status = check_name (name, herrnop);
+  char tmp[NS_MAXDNAME];
   if (status != NSS_STATUS_SUCCESS)
     return status;
   struct resolv_context *ctx = __resolv_context_get ();
@@ -395,7 +396,6 @@  _nss_dns_gethostbyname4_r (const char *name, struct gaih_addrtuple **pat,
    */
   if (strchr (name, '.') == NULL)
     {
-      char *tmp = alloca (NS_MAXDNAME);
       const char *cp = __res_context_hostalias (ctx, name, tmp, NS_MAXDNAME);
       if (cp != NULL)
 	name = cp;