| Message ID | 20230405162144.984598-5-hjl.tools@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | <sys/platform/x86.h>: Update CPUID features | expand |
On Wed, Apr 5, 2023 at 11:22 AM H.J. Lu via Libc-alpha <libc-alpha@sourceware.org> wrote: > > Add Bus lock debug exceptions (BUS_LOCK_DETECT) support to > <sys/platform/x86.h>. > --- > manual/platform.texi | 3 +++ > sysdeps/x86/bits/platform/x86.h | 2 +- > sysdeps/x86/tst-get-cpu-features.c | 1 + > 3 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/manual/platform.texi b/manual/platform.texi > index 9251b63e47..78ee39f650 100644 > --- a/manual/platform.texi > +++ b/manual/platform.texi > @@ -276,6 +276,9 @@ extensions. > @item > @code{BMI2} -- BMI2 instructions. > > +@item > +@code{BUS_LOCK_DETECT} -- Bus lock debug exceptions. > + > @item > @code{CLDEMOTE} -- CLDEMOTE instruction. > > diff --git a/sysdeps/x86/bits/platform/x86.h b/sysdeps/x86/bits/platform/x86.h > index c9189fa248..e25f1ac53c 100644 > --- a/sysdeps/x86/bits/platform/x86.h > +++ b/sysdeps/x86/bits/platform/x86.h > @@ -187,7 +187,7 @@ enum > instructions in 64-bit mode. */ > x86_cpu_RDPID = x86_cpu_index_7_ecx + 22, > x86_cpu_KL = x86_cpu_index_7_ecx + 23, > - x86_cpu_INDEX_7_ECX_24 = x86_cpu_index_7_ecx + 24, > + x86_cpu_BUS_LOCK_DETECT = x86_cpu_index_7_ecx + 24, > x86_cpu_CLDEMOTE = x86_cpu_index_7_ecx + 25, > x86_cpu_INDEX_7_ECX_26 = x86_cpu_index_7_ecx + 26, > x86_cpu_MOVDIRI = x86_cpu_index_7_ecx + 27, > diff --git a/sysdeps/x86/tst-get-cpu-features.c b/sysdeps/x86/tst-get-cpu-features.c > index 5f5cd3e448..dcb735ddd6 100644 > --- a/sysdeps/x86/tst-get-cpu-features.c > +++ b/sysdeps/x86/tst-get-cpu-features.c > @@ -147,6 +147,7 @@ do_test (void) > CHECK_CPU_FEATURE_PRESENT (LA57); > CHECK_CPU_FEATURE_PRESENT (RDPID); > CHECK_CPU_FEATURE_PRESENT (KL); > + CHECK_CPU_FEATURE_PRESENT (BUS_LOCK_DETECT); > CHECK_CPU_FEATURE_PRESENT (CLDEMOTE); > CHECK_CPU_FEATURE_PRESENT (MOVDIRI); > CHECK_CPU_FEATURE_PRESENT (MOVDIR64B); > -- > 2.39.2 > Rename 'bit_cpu_INDEX_7_ECX_24' in cpu-features.h?
On Wed, Apr 5, 2023 at 1:20 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote: > > On Wed, Apr 5, 2023 at 11:22 AM H.J. Lu via Libc-alpha > <libc-alpha@sourceware.org> wrote: > > > > Add Bus lock debug exceptions (BUS_LOCK_DETECT) support to > > <sys/platform/x86.h>. > > --- > > manual/platform.texi | 3 +++ > > sysdeps/x86/bits/platform/x86.h | 2 +- > > sysdeps/x86/tst-get-cpu-features.c | 1 + > > 3 files changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/manual/platform.texi b/manual/platform.texi > > index 9251b63e47..78ee39f650 100644 > > --- a/manual/platform.texi > > +++ b/manual/platform.texi > > @@ -276,6 +276,9 @@ extensions. > > @item > > @code{BMI2} -- BMI2 instructions. > > > > +@item > > +@code{BUS_LOCK_DETECT} -- Bus lock debug exceptions. > > + > > @item > > @code{CLDEMOTE} -- CLDEMOTE instruction. > > > > diff --git a/sysdeps/x86/bits/platform/x86.h b/sysdeps/x86/bits/platform/x86.h > > index c9189fa248..e25f1ac53c 100644 > > --- a/sysdeps/x86/bits/platform/x86.h > > +++ b/sysdeps/x86/bits/platform/x86.h > > @@ -187,7 +187,7 @@ enum > > instructions in 64-bit mode. */ > > x86_cpu_RDPID = x86_cpu_index_7_ecx + 22, > > x86_cpu_KL = x86_cpu_index_7_ecx + 23, > > - x86_cpu_INDEX_7_ECX_24 = x86_cpu_index_7_ecx + 24, > > + x86_cpu_BUS_LOCK_DETECT = x86_cpu_index_7_ecx + 24, > > x86_cpu_CLDEMOTE = x86_cpu_index_7_ecx + 25, > > x86_cpu_INDEX_7_ECX_26 = x86_cpu_index_7_ecx + 26, > > x86_cpu_MOVDIRI = x86_cpu_index_7_ecx + 27, > > diff --git a/sysdeps/x86/tst-get-cpu-features.c b/sysdeps/x86/tst-get-cpu-features.c > > index 5f5cd3e448..dcb735ddd6 100644 > > --- a/sysdeps/x86/tst-get-cpu-features.c > > +++ b/sysdeps/x86/tst-get-cpu-features.c > > @@ -147,6 +147,7 @@ do_test (void) > > CHECK_CPU_FEATURE_PRESENT (LA57); > > CHECK_CPU_FEATURE_PRESENT (RDPID); > > CHECK_CPU_FEATURE_PRESENT (KL); > > + CHECK_CPU_FEATURE_PRESENT (BUS_LOCK_DETECT); > > CHECK_CPU_FEATURE_PRESENT (CLDEMOTE); > > CHECK_CPU_FEATURE_PRESENT (MOVDIRI); > > CHECK_CPU_FEATURE_PRESENT (MOVDIR64B); > > -- > > 2.39.2 > > > Rename 'bit_cpu_INDEX_7_ECX_24' in cpu-features.h? LGTM Reviewed-by: Noah Goldstein <goldstein.w.n@gmail.com>
diff --git a/manual/platform.texi b/manual/platform.texi index 9251b63e47..78ee39f650 100644 --- a/manual/platform.texi +++ b/manual/platform.texi @@ -276,6 +276,9 @@ extensions. @item @code{BMI2} -- BMI2 instructions. +@item +@code{BUS_LOCK_DETECT} -- Bus lock debug exceptions. + @item @code{CLDEMOTE} -- CLDEMOTE instruction. diff --git a/sysdeps/x86/bits/platform/x86.h b/sysdeps/x86/bits/platform/x86.h index c9189fa248..e25f1ac53c 100644 --- a/sysdeps/x86/bits/platform/x86.h +++ b/sysdeps/x86/bits/platform/x86.h @@ -187,7 +187,7 @@ enum instructions in 64-bit mode. */ x86_cpu_RDPID = x86_cpu_index_7_ecx + 22, x86_cpu_KL = x86_cpu_index_7_ecx + 23, - x86_cpu_INDEX_7_ECX_24 = x86_cpu_index_7_ecx + 24, + x86_cpu_BUS_LOCK_DETECT = x86_cpu_index_7_ecx + 24, x86_cpu_CLDEMOTE = x86_cpu_index_7_ecx + 25, x86_cpu_INDEX_7_ECX_26 = x86_cpu_index_7_ecx + 26, x86_cpu_MOVDIRI = x86_cpu_index_7_ecx + 27, diff --git a/sysdeps/x86/tst-get-cpu-features.c b/sysdeps/x86/tst-get-cpu-features.c index 5f5cd3e448..dcb735ddd6 100644 --- a/sysdeps/x86/tst-get-cpu-features.c +++ b/sysdeps/x86/tst-get-cpu-features.c @@ -147,6 +147,7 @@ do_test (void) CHECK_CPU_FEATURE_PRESENT (LA57); CHECK_CPU_FEATURE_PRESENT (RDPID); CHECK_CPU_FEATURE_PRESENT (KL); + CHECK_CPU_FEATURE_PRESENT (BUS_LOCK_DETECT); CHECK_CPU_FEATURE_PRESENT (CLDEMOTE); CHECK_CPU_FEATURE_PRESENT (MOVDIRI); CHECK_CPU_FEATURE_PRESENT (MOVDIR64B);