From patchwork Thu Jul 7 23:39:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 1653852 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=DjqxChq8; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LfCZY0yPTz9s09 for ; Fri, 8 Jul 2022 09:40:20 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 408AC3850430 for ; Thu, 7 Jul 2022 23:40:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 408AC3850430 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1657237217; bh=1BUTTckOoPA7SES7pD3dFTzDp7Isy39tz149KVNkNao=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=DjqxChq8uGt3779v+9PoDF5OmaSdjmT1spqUCG+iEGlhwFVa+lHoqsmUHBF6bphm2 dktfny975L7VTkdV2sk7qeR972oIgNqroWrA7NzOGrf1UytAy8kEY8AtYz5/JrVLJu n8EgHAZUOB0UxKJ+/xNbUmZo5D8X8TLoLjlC2Hl8= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by sourceware.org (Postfix) with ESMTPS id 17B123858434 for ; Thu, 7 Jul 2022 23:40:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 17B123858434 Received: by mail-pj1-x1033.google.com with SMTP id 89-20020a17090a09e200b001ef7638e536so295684pjo.3 for ; Thu, 07 Jul 2022 16:40:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1BUTTckOoPA7SES7pD3dFTzDp7Isy39tz149KVNkNao=; b=E4Nu/Zr80w/L5OymtagqB6/AwhQfxQiKK+JgVnbc/SPXQjJExoxqg/jFHlEbGqsDMG qpB4eAs8NlAiM6DStIId/Wab5FL2GdNPv2lWdVb23hSZ5DkxiTKx/RxccQpusZM4RTBN qW/W2kk9hbVIy3i6y1vcVGTqBUYPQcP0Hh1exRYsZ+Is2EZTjHCS+pfr+f6YElZvxGso EJDi360dv90LPjKC8ZIxY6HYutM+AZ6ma21O5cf559PilQ1NzUt8qV1aMxoiXZviG2N8 8A38CebGtFiciRJVF/KaZQ1Nu1/gcWF4BH+ZEYu+RaZndptN0BQbQVfR862PWTetQ06N BlOA== X-Gm-Message-State: AJIora+/Y3hmtOaQbGEhPJ999Q0C0Y65uJ6Wwu61fu3Dry49K+9hUfTr 816nWr/jaaUdLJyVLvWasAs= X-Google-Smtp-Source: AGRyM1txdNn8Am0EX0a2UsRmPQ+PNSbvEp89gmDlNM9PFFrMOWITDtinu7EF9edQxQim4DRVdyGzCQ== X-Received: by 2002:a17:90a:5515:b0:1ed:50e2:853e with SMTP id b21-20020a17090a551500b001ed50e2853emr7996838pji.41.1657237198983; Thu, 07 Jul 2022 16:39:58 -0700 (PDT) Received: from gnu-tgl-3.localdomain ([172.58.37.183]) by smtp.gmail.com with ESMTPSA id 206-20020a6216d7000000b00528c22038f5sm3319344pfw.14.2022.07.07.16.39.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 16:39:58 -0700 (PDT) Received: from gnu-tgl-3.. (localhost [IPv6:::1]) by gnu-tgl-3.localdomain (Postfix) with ESMTP id D6C6DC037C; Thu, 7 Jul 2022 16:39:56 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH] x86-64: Don't mark symbols as hidden in strcmp-XXX.S Date: Thu, 7 Jul 2022 16:39:56 -0700 Message-Id: <20220707233956.2483267-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 X-Spam-Status: No, score=-3027.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Libc-alpha" From: "H.J. Lu" Reply-To: "H.J. Lu" Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org Sender: "Libc-alpha" Don't mark symbols as hidden in strcmp-avx2.S, strcmp-evex.S and strcmp-sse42.S since they are marked as hidden in the IFUNC selectors. --- sysdeps/x86_64/multiarch/strcmp-avx2.S | 1 - sysdeps/x86_64/multiarch/strcmp-evex.S | 1 - sysdeps/x86_64/multiarch/strcmp-sse42.S | 1 - 3 files changed, 3 deletions(-) diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S index 8da09bd86d..516cde1145 100644 --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S @@ -184,7 +184,6 @@ .align 16 .type STRCMP, @function .globl STRCMP - .hidden STRCMP # ifndef GLABEL # define GLABEL(...) __VA_ARGS__ diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S index 2a5b3ce037..e97d51bb26 100644 --- a/sysdeps/x86_64/multiarch/strcmp-evex.S +++ b/sysdeps/x86_64/multiarch/strcmp-evex.S @@ -214,7 +214,6 @@ .align 16 .type STRCMP, @function .globl STRCMP - .hidden STRCMP # ifdef USE_AS_STRCASECMP_L ENTRY (STRCASECMP) diff --git a/sysdeps/x86_64/multiarch/strcmp-sse42.S b/sysdeps/x86_64/multiarch/strcmp-sse42.S index a9178ad25c..60313c647a 100644 --- a/sysdeps/x86_64/multiarch/strcmp-sse42.S +++ b/sysdeps/x86_64/multiarch/strcmp-sse42.S @@ -77,7 +77,6 @@ .align 16 .type STRCMP_SSE42, @function .globl STRCMP_SSE42 - .hidden STRCMP_SSE42 #ifdef USE_AS_STRCASECMP_L ENTRY (GLABEL(__strcasecmp)) movq __libc_tsd_LOCALE@gottpoff(%rip),%rax