Message ID | 20211221221329.347210-1-eggert@cs.ucla.edu |
---|---|
State | New |
Headers | show |
Series | cdefs.h: fix "__clang_major" typo | expand |
On 21/12/2021 19:13, Paul Eggert wrote: > * misc/sys/cdefs.h: Fix misspelling of "__clang_major__". LGTM, thanks. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> > --- > misc/sys/cdefs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/misc/sys/cdefs.h b/misc/sys/cdefs.h > index a05b538579..f6e1db1954 100644 > --- a/misc/sys/cdefs.h > +++ b/misc/sys/cdefs.h > @@ -81,7 +81,7 @@ > # define __NTH(fct) __attribute__ ((__nothrow__ __LEAF)) fct > # define __NTHNL(fct) __attribute__ ((__nothrow__)) fct > # else > -# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major >= 4) > +# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major__ >= 4) > # if __cplusplus >= 201103L > # define __THROW noexcept (true) > # else
On 12/30/21 06:20, Adhemerval Zanella via Libc-alpha wrote: > > > On 21/12/2021 19:13, Paul Eggert wrote: >> * misc/sys/cdefs.h: Fix misspelling of "__clang_major__". > > LGTM, thanks. > > Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> Ahemerval, In reviewing old patches to improve our SLI for patch review I noticed that this patch is reviewed and approved but not committed. The patch still looks correct to me. Would you mind committing this on behalf of Paul please? >> --- >> misc/sys/cdefs.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/misc/sys/cdefs.h b/misc/sys/cdefs.h >> index a05b538579..f6e1db1954 100644 >> --- a/misc/sys/cdefs.h >> +++ b/misc/sys/cdefs.h >> @@ -81,7 +81,7 @@ >> # define __NTH(fct) __attribute__ ((__nothrow__ __LEAF)) fct >> # define __NTHNL(fct) __attribute__ ((__nothrow__)) fct >> # else >> -# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major >= 4) >> +# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major__ >= 4) >> # if __cplusplus >= 201103L >> # define __THROW noexcept (true) >> # else >
On 23/02/23 15:30, Carlos O'Donell wrote: > On 12/30/21 06:20, Adhemerval Zanella via Libc-alpha wrote: >> >> >> On 21/12/2021 19:13, Paul Eggert wrote: >>> * misc/sys/cdefs.h: Fix misspelling of "__clang_major__". >> >> LGTM, thanks. >> >> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> > > Ahemerval, > > In reviewing old patches to improve our SLI for patch review I noticed that > this patch is reviewed and approved but not committed. The patch still looks > correct to me. > > Would you mind committing this on behalf of Paul please? > > Done. >>> --- >>> misc/sys/cdefs.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/misc/sys/cdefs.h b/misc/sys/cdefs.h >>> index a05b538579..f6e1db1954 100644 >>> --- a/misc/sys/cdefs.h >>> +++ b/misc/sys/cdefs.h >>> @@ -81,7 +81,7 @@ >>> # define __NTH(fct) __attribute__ ((__nothrow__ __LEAF)) fct >>> # define __NTHNL(fct) __attribute__ ((__nothrow__)) fct >>> # else >>> -# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major >= 4) >>> +# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major__ >= 4) >>> # if __cplusplus >= 201103L >>> # define __THROW noexcept (true) >>> # else >> >
diff --git a/misc/sys/cdefs.h b/misc/sys/cdefs.h index a05b538579..f6e1db1954 100644 --- a/misc/sys/cdefs.h +++ b/misc/sys/cdefs.h @@ -81,7 +81,7 @@ # define __NTH(fct) __attribute__ ((__nothrow__ __LEAF)) fct # define __NTHNL(fct) __attribute__ ((__nothrow__)) fct # else -# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major >= 4) +# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major__ >= 4) # if __cplusplus >= 201103L # define __THROW noexcept (true) # else