Message ID | 20210805075120.433591-1-naohirot@fujitsu.com |
---|---|
State | New |
Headers | show |
Series | benchtests: Add memset zero fill benchmark test | expand |
Hi all, is there any comment? https://sourceware.org/pipermail/libc-alpha/2021-August/129840.html Thanks. Naohiro > -----Original Message----- > From: Naohiro Tamura <naohirot@fujitsu.com> > Sent: Thursday, August 5, 2021 4:51 PM > To: Lucas A. M. Magalhaes <lamm@linux.ibm.com>; libc-alpha@sourceware.org > Cc: Tamura, Naohiro/田村 直広 <naohirot@fujitsu.com> > Subject: [PATCH v3 3/5] benchtests: Remove redundant assert.h > > This patch removed redundant "#include <assert.h>" from > bench-memset-large.c and bench-memset-walk.c. > --- > benchtests/bench-memset-large.c | 1 - > benchtests/bench-memset-walk.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/benchtests/bench-memset-large.c b/benchtests/bench-memset-large.c > index 97ed78d0d6a1..3fd20b79e53d 100644 > --- a/benchtests/bench-memset-large.c > +++ b/benchtests/bench-memset-large.c > @@ -23,7 +23,6 @@ > #define TIMEOUT (20 * 60) > #include "bench-string.h" > > -#include <assert.h> > #include "json-lib.h" > > void *generic_memset (void *, int, size_t); > diff --git a/benchtests/bench-memset-walk.c b/benchtests/bench-memset-walk.c > index 0dcad09c484f..5fb315384992 100644 > --- a/benchtests/bench-memset-walk.c > +++ b/benchtests/bench-memset-walk.c > @@ -23,7 +23,6 @@ > #define TIMEOUT (20 * 60) > #include "bench-string.h" > > -#include <assert.h> > #include "json-lib.h" > > void *generic_memset (void *, int, size_t); > -- > 2.17.1
On 8/5/21 1:21 PM, Naohiro Tamura via Libc-alpha wrote: > This patch removed redundant "#include <assert.h>" from > bench-memset-large.c and bench-memset-walk.c. > --- > benchtests/bench-memset-large.c | 1 - > benchtests/bench-memset-walk.c | 1 - > 2 files changed, 2 deletions(-) LGTM. Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
diff --git a/benchtests/bench-memset-large.c b/benchtests/bench-memset-large.c index 97ed78d0d6a1..3fd20b79e53d 100644 --- a/benchtests/bench-memset-large.c +++ b/benchtests/bench-memset-large.c @@ -23,7 +23,6 @@ #define TIMEOUT (20 * 60) #include "bench-string.h" -#include <assert.h> #include "json-lib.h" void *generic_memset (void *, int, size_t); diff --git a/benchtests/bench-memset-walk.c b/benchtests/bench-memset-walk.c index 0dcad09c484f..5fb315384992 100644 --- a/benchtests/bench-memset-walk.c +++ b/benchtests/bench-memset-walk.c @@ -23,7 +23,6 @@ #define TIMEOUT (20 * 60) #include "bench-string.h" -#include <assert.h> #include "json-lib.h" void *generic_memset (void *, int, size_t);