[v2,08/25] y2038: Add __USE_TIME_BITS64 support for time_t

Message ID	20210518205613.1487824-9-adhemerval.zanella@linaro.org
State	New
Headers	show Return-Path: <libc-alpha-bounces@sourceware.org> DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2F960396B402 To: libc-alpha@sourceware.org Subject: [PATCH v2 08/25] y2038: Add __USE_TIME_BITS64 support for time_t Date: Tue, 18 May 2021 17:55:56 -0300 Message-Id: <20210518205613.1487824-9-adhemerval.zanella@linaro.org> In-Reply-To: <20210518205613.1487824-1-adhemerval.zanella@linaro.org> References: <20210518205613.1487824-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list From: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Adhemerval Zanella <adhemerval.zanella@linaro.org> Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org>
Series	Add 64 bit time support on legacy ABIs \| expand [v2,00/25] Add 64 bit time support on legacy ABIs [v2,01/25] linux: mips: Split libpthread.abilist in n32 and n64 [v2,02/25] linux: mips: Split librt.abilist in n32 and n64 [v2,03/25] linux: mips: Split libanl.abilist in n32 and n64 [v2,04/25] linux: s390: Add libanl.abilist in s390 and s390x [v2,05/25] linux: Add fallback for 64-bit time_t SO_{RCV, SND}TIMEO [v2,06/25] linux: Add fallback for 64-bit time_t SO_TIMESTAMP{NS} [v2,07/25] linux: Add recvvmsg fallback for 64-bit time_t SO_TIMESTAMP{NS} [v2,08/25] y2038: Add __USE_TIME_BITS64 support for time_t [v2,09/25] y2038: Add __USE_TIME_BITS64 support for struct timeval [v2,10/25] y2038: Add __USE_TIME_BITS64 support for struct timespec [v2,11/25] y2038: Add __USE_TIME_BITS64 support for struct utimbuf [v2,12/25] y2038: linux: Add __USE_TIME_BITS64 support for struct timex [v2,13/25] y2038: Use a common definition for stat [v2,14/25] y2038: Use a common definition for msqid_ds [v2,15/25] y2038: Use a common definition for semid_ds [v2,16/25] y2038: Use a common definition for shmid_ds [v2,17/25] y2038: Add __USE_TIME_BITS64 support for socket-constants.h [v2,18/25] time: Add 64 bit time support for getdate [v2,19/25] y2038: Add support for 64 bit time on legacy ABIs [v2,20/25] posix: Add glob64 with 64 bit time_t support [v2,21/25] io: Add fts64 with 64 bit time_t support [v2,22/25] io: Add ftw64 with 64 bit time_t support [v2,23/25] libsupport: Add 64 bit time_t support for time functions [v2,24/25] libsupport: Add 64 bit time_t support for stat functions [v2,25/25] y2038: Add test coverage

Message ID

20210518205613.1487824-9-adhemerval.zanella@linaro.org

State

New

Headers

DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2F960396B402
To: libc-alpha@sourceware.org
Subject: [PATCH v2 08/25] y2038: Add __USE_TIME_BITS64 support for time_t
Date: Tue, 18 May 2021 17:55:56 -0300
Message-Id: <20210518205613.1487824-9-adhemerval.zanella@linaro.org>
In-Reply-To: <20210518205613.1487824-1-adhemerval.zanella@linaro.org>
References: <20210518205613.1487824-1-adhemerval.zanella@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
From: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Reply-To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Errors-To: libc-alpha-bounces@sourceware.org
Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org>

Series

Add 64 bit time support on legacy ABIs | expand

Comments

Lukasz Majewski May 19, 2021, 9:02 a.m. UTC | #1

On Tue, 18 May 2021 17:55:56 -0300
Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:

> The __USE_TIME_BITS64 is not defined internally yet.
> ---
>  time/bits/types/time_t.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/time/bits/types/time_t.h b/time/bits/types/time_t.h
> index ab8287c6fe..84d67f6ac3 100644
> --- a/time/bits/types/time_t.h
> +++ b/time/bits/types/time_t.h
> @@ -4,6 +4,10 @@
>  #include <bits/types.h>
>  
>  /* Returned by `time'.  */
> +#ifdef __USE_TIME_BITS64
> +typedef __time64_t time_t;
> +#else
>  typedef __time_t time_t;
> +#endif
>  
>  #endif

Reviewed-by: Lukasz Majewski <lukma@denx.de>

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

Carlos O'Donell June 4, 2021, 7:30 p.m. UTC | #2

On 5/18/21 4:55 PM, Adhemerval Zanella wrote:
> The __USE_TIME_BITS64 is not defined internally yet.

LGTM.

No regressions on x86_64, i686, ppc64le, aarch64, s390x.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>

> ---
>  time/bits/types/time_t.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/time/bits/types/time_t.h b/time/bits/types/time_t.h
> index ab8287c6fe..84d67f6ac3 100644
> --- a/time/bits/types/time_t.h
> +++ b/time/bits/types/time_t.h
> @@ -4,6 +4,10 @@
>  #include <bits/types.h>
>  
>  /* Returned by `time'.  */
> +#ifdef __USE_TIME_BITS64
> +typedef __time64_t time_t;
> +#else
>  typedef __time_t time_t;
> +#endif
>  
>  #endif
>

diff --git a/time/bits/types/time_t.h b/time/bits/types/time_t.h
index ab8287c6fe..84d67f6ac3 100644
--- a/time/bits/types/time_t.h
+++ b/time/bits/types/time_t.h
@@ -4,6 +4,10 @@ 
 #include <bits/types.h>
 
 /* Returned by `time'.  */
+#ifdef __USE_TIME_BITS64
+typedef __time64_t time_t;
+#else
 typedef __time_t time_t;
+#endif
 
 #endif

[v2,08/25] y2038: Add __USE_TIME_BITS64 support for time_t

Commit Message

Comments

Patch