Message ID | 20210515123442.1432385-4-hjl.tools@gmail.com |
---|---|
State | New |
Headers | show |
Series | Add an internal wrapper for clone, clone2 and clone3 | expand |
On Mai 15 2021, H.J. Lu via Libc-alpha wrote: > diff --git a/sysdeps/unix/sysv/linux/Versions b/sysdeps/unix/sysv/linux/Versions > index 220bb2dffe..299d4fef9c 100644 > --- a/sysdeps/unix/sysv/linux/Versions > +++ b/sysdeps/unix/sysv/linux/Versions > @@ -179,6 +179,7 @@ libc { > __sigtimedwait; > # functions used by nscd > __netlink_assert_response; > + __clone_internal; The comment doesn't fit here. Andreas.
* H. J. Lu: > Export __clone_internal for libpthread.so and __clone_internal tests. > --- > sysdeps/unix/sysv/linux/Versions | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sysdeps/unix/sysv/linux/Versions b/sysdeps/unix/sysv/linux/Versions > index 220bb2dffe..299d4fef9c 100644 > --- a/sysdeps/unix/sysv/linux/Versions > +++ b/sysdeps/unix/sysv/linux/Versions > @@ -179,6 +179,7 @@ libc { > __sigtimedwait; > # functions used by nscd > __netlink_assert_response; > + __clone_internal; > } > } I think this won't be necessary after the libpthread move. We can test the function directly by linking statically. We already do this in a few other cases. Thanks, Florian
On Thu, May 20, 2021 at 7:24 AM Florian Weimer <fweimer@redhat.com> wrote: > > * H. J. Lu: > > > Export __clone_internal for libpthread.so and __clone_internal tests. > > --- > > sysdeps/unix/sysv/linux/Versions | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/sysdeps/unix/sysv/linux/Versions b/sysdeps/unix/sysv/linux/Versions > > index 220bb2dffe..299d4fef9c 100644 > > --- a/sysdeps/unix/sysv/linux/Versions > > +++ b/sysdeps/unix/sysv/linux/Versions > > @@ -179,6 +179,7 @@ libc { > > __sigtimedwait; > > # functions used by nscd > > __netlink_assert_response; > > + __clone_internal; > > } > > } > > I think this won't be necessary after the libpthread move. This patch has been dropped. > We can test the function directly by linking statically. We already do > this in a few other cases. That is in the v6 patch. Thanks.
diff --git a/sysdeps/unix/sysv/linux/Versions b/sysdeps/unix/sysv/linux/Versions index 220bb2dffe..299d4fef9c 100644 --- a/sysdeps/unix/sysv/linux/Versions +++ b/sysdeps/unix/sysv/linux/Versions @@ -179,6 +179,7 @@ libc { __sigtimedwait; # functions used by nscd __netlink_assert_response; + __clone_internal; } }