From patchwork Tue Feb 9 17:44:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 1438518 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=libc-alpha-bounces@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=KwVtACS9; dkim-atps=neutral Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DZqyq4DD2z9sBJ for ; Wed, 10 Feb 2021 04:44:35 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 91C5A394D8AA; Tue, 9 Feb 2021 17:44:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 91C5A394D8AA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1612892672; bh=HN+ghDYiLvQCNmZtW+I9uvX7awhrNvgpIUHPHTsIt14=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=KwVtACS9okZjD6nL+VOv1LDlDFNeRoK5Sc88Fik0lIYvx6uGxGr7UdPonUItFK5HL zunze64ldZ/imjSMyoFRfcnuuXVW/KMR2Jm8hVxMEJwgMBTzfLAlYfNbnEUW7WClt0 7+NutGMJu1Zcow+OgMiCI03ZB+2PmuefM0zuhfe4= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by sourceware.org (Postfix) with ESMTPS id 4D84A385DC39 for ; Tue, 9 Feb 2021 17:44:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4D84A385DC39 Received: by mail-qt1-x82f.google.com with SMTP id w20so13571566qta.0 for ; Tue, 09 Feb 2021 09:44:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HN+ghDYiLvQCNmZtW+I9uvX7awhrNvgpIUHPHTsIt14=; b=FLzjLM3nGgZpZ/j5YFfbLoRRpvL/5tBOPjNoMr9iZtjljk1yifatdl9c2GKXfdKNPG 0p1d57qsATkO/2yxLF1ghIHh0EInquv4HKgp6qAkroePTtRoyu7awgoOh0j7Dpu8+3+O iwNPusOR/mxDZvQDZbS/KixzntUFiYEIvKIqOZRKfudIinaeoZieBE6U58z5r5UPfDOq TMij5s8ko21DimS4Mt2hZCHf1oca7nIAXADj4qc/vUp+N2KJiK8T12pru3CQkZttv1Zv 1T48teA/wsvZlbxlD1H1nJCJpDcNDlEFyKnFTITOJcIORWx6HaWNnNLQ0+TZSoujRyOl 5iOA== X-Gm-Message-State: AOAM533fRbT4sZPFJXmNGL3zJaj9CBAdtE5qjJvukcLEocmmCkwvfIyp cLMv4DslZzxjafhdEhIAAAAOJYs/DUpJ2A== X-Google-Smtp-Source: ABdhPJysOK6oixuVVX3kwxU9hJGRQq8x19Ccuz/uvnzm+17bt2vkTtur0+kxJLTLxNNfAuMTkTUD8g== X-Received: by 2002:ac8:4f52:: with SMTP id i18mr20024657qtw.113.1612892668684; Tue, 09 Feb 2021 09:44:28 -0800 (PST) Received: from localhost.localdomain ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id c14sm5170110qkm.115.2021.02.09.09.44.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 09:44:28 -0800 (PST) To: libc-alpha@sourceware.org Subject: [COMMITTED] linux: Fix __sem_check_add_mapping name length Date: Tue, 9 Feb 2021 14:44:23 -0300 Message-Id: <20210209174423.3577809-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210203183414.571813-1-adhemerval.zanella@linaro.org> References: <20210203183414.571813-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" Take in consideration the trailling NULL since sem_search uses strcmp to compare entries. Checked on x86_64-linux-gnu and powerpc-linux-gnu (where it triggered a nptl/tst-sem7 regression). --- sysdeps/pthread/sem_routines.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sysdeps/pthread/sem_routines.c b/sysdeps/pthread/sem_routines.c index ea7a445324..c2c8b54cd0 100644 --- a/sysdeps/pthread/sem_routines.c +++ b/sysdeps/pthread/sem_routines.c @@ -72,6 +72,7 @@ __sem_check_add_mapping (const char *name, int fd, sem_t *existing) size_t namelen = strlen (name); if (namelen > NAME_MAX) return SEM_FAILED; + namelen += 1; sem_t *result = SEM_FAILED;