diff mbox series

tst: Provide test for timerfd related functions

Message ID 20210113150146.32652-1-lukma@denx.de
State New
Headers show
Series tst: Provide test for timerfd related functions | expand

Commit Message

Lukasz Majewski Jan. 13, 2021, 3:01 p.m. UTC 
This change adds new test to assess functionality of timerfd_*
functions.
It creates new timer (operates on its file descriptor) and checks
if time before and after sleep is between expected values.
---
 sysdeps/unix/sysv/linux/Makefile      |   3 +-
 sysdeps/unix/sysv/linux/tst-timerfd.c | 100 ++++++++++++++++++++++++++
 2 files changed, 102 insertions(+), 1 deletion(-)
 create mode 100644 sysdeps/unix/sysv/linux/tst-timerfd.c

Comments

Florian Weimer Jan. 13, 2021, 3:10 p.m. UTC | #1 
* Lukasz Majewski:

> +  fd = timerfd_create(CLOCK_REALTIME, 0);
> +  if (fd < 0)
> +    {
> +	    printf ("*** timerfd_create failed: %d\n", fd);
> +      return fd;
> +    }

Please use FAIL_EXIT1 with %m, and add spaces in function calls, e.g.,
“timerfd_create (CLOCK_REALTIME, 0)”.

This others to the other function calls in the code.

> +  /* Check difference between timerfd_gettime() calls.  */
> +  long long int diff = val1.it_value.tv_sec - val2.it_value.tv_sec;
> +  diff *= 1000000000;
> +  diff += val1.it_value.tv_nsec - val2.it_value.tv_nsec;
> +  diff -= 1000000000;
> +  diff = abs(diff);
> +  if (diff > 100000000)
> +    {
> +      printf ("*** The diff between timerfd calls (%lld) is wrong!\n",
> +              diff);
> +      goto err;
> +    }

Why diff = abs (diff)?  Can the offset really be in both directions?

> +  ret = close(fd);

You could use xclose here.

Thanks,
Florian
Lukasz Majewski Jan. 13, 2021, 10:25 p.m. UTC | #2 
Hi Florian,

> * Lukasz Majewski:
> 
> > +  fd = timerfd_create(CLOCK_REALTIME, 0);
> > +  if (fd < 0)
> > +    {
> > +	    printf ("*** timerfd_create failed: %d\n", fd);
> > +      return fd;
> > +    }  
> 
> Please use FAIL_EXIT1 with %m, and add spaces in function calls, e.g.,
> “timerfd_create (CLOCK_REALTIME, 0)”.
> 
> This others to the other function calls in the code.

Ok. I will adjust the code properly. Thanks for pointing this out.

> 
> > +  /* Check difference between timerfd_gettime() calls.  */
> > +  long long int diff = val1.it_value.tv_sec - val2.it_value.tv_sec;
> > +  diff *= 1000000000;
> > +  diff += val1.it_value.tv_nsec - val2.it_value.tv_nsec;
> > +  diff -= 1000000000;
> > +  diff = abs(diff);
> > +  if (diff > 100000000)
> > +    {
> > +      printf ("*** The diff between timerfd calls (%lld) is
> > wrong!\n",
> > +              diff);
> > +      goto err;
> > +    }  
> 
> Why diff = abs (diff)?  Can the offset really be in both directions?

I've refactored the code and now it seems like the abs (diff) can be
safely removed.

> 
> > +  ret = close(fd);  
> 
> You could use xclose here.

Ok.

> 
> Thanks,
> Florian




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
diff mbox series

Patch

diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile
index 6df4779126..7503b356c8 100644
--- a/sysdeps/unix/sysv/linux/Makefile
+++ b/sysdeps/unix/sysv/linux/Makefile
@@ -107,7 +107,8 @@  tests += tst-clone tst-clone2 tst-clone3 tst-fanotify tst-personality \
 	 tst-quota tst-sync_file_range tst-sysconf-iov_max tst-ttyname \
 	 test-errno-linux tst-memfd_create tst-mlock2 tst-pkey \
 	 tst-rlimit-infinity tst-ofdlocks tst-gettid tst-gettid-kill \
-	 tst-tgkill tst-sysvsem-linux tst-sysvmsg-linux tst-sysvshm-linux
+	 tst-tgkill tst-sysvsem-linux tst-sysvmsg-linux tst-sysvshm-linux \
+	 tst-timerfd
 tests-internal += tst-ofdlocks-compat tst-sigcontext-get_pc
 
 CFLAGS-tst-sigcontext-get_pc.c = -fasynchronous-unwind-tables
diff --git a/sysdeps/unix/sysv/linux/tst-timerfd.c b/sysdeps/unix/sysv/linux/tst-timerfd.c
new file mode 100644
index 0000000000..6ec379ff71
--- /dev/null
+++ b/sysdeps/unix/sysv/linux/tst-timerfd.c
@@ -0,0 +1,100 @@ 
+/* Test for timerfd related functions
+   Copyright (C) 2021 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#include <time.h>
+#include <support/check.h>
+#include <sys/time.h>
+#include <sys/timerfd.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <unistd.h>
+
+static int
+do_test (void)
+{
+	struct itimerspec settings = { { 2, 0 }, { 2, 0 } };
+	struct itimerspec val1, val2;
+  int fd, ret;
+
+  fd = timerfd_create(CLOCK_REALTIME, 0);
+  if (fd < 0)
+    {
+	    printf ("*** timerfd_create failed: %d\n", fd);
+      return fd;
+    }
+
+  /* Set the timer.  */
+  ret = timerfd_settime(fd, 0, &settings, NULL);
+  if (ret != 0)
+    {
+      printf ("*** timerfd_settime failed: %m\n");
+      goto err;
+    }
+
+  /* Read the timer just before sleep.  */
+  ret = timerfd_gettime(fd, &val1);
+  if (ret != 0)
+    {
+      printf ("*** timerfd_gettime failed: %m\n");
+      goto err;
+    }
+
+  /* Sleep for 1 second.  */
+  ret = usleep(1000000);
+  if (ret != 0)
+    {
+      printf ("*** usleep failed: %m\n");
+      goto err;
+    }
+
+  /* Read the timer just after sleep.  */
+  ret = timerfd_gettime(fd, &val2);
+  if (ret != 0)
+    {
+      printf ("*** timerfd_gettime failed: %m\n");
+      goto err;
+    }
+
+  /* Check difference between timerfd_gettime() calls.  */
+  long long int diff = val1.it_value.tv_sec - val2.it_value.tv_sec;
+  diff *= 1000000000;
+  diff += val1.it_value.tv_nsec - val2.it_value.tv_nsec;
+  diff -= 1000000000;
+  diff = abs(diff);
+  if (diff > 100000000)
+    {
+      printf ("*** The diff between timerfd calls (%lld) is wrong!\n",
+              diff);
+      goto err;
+    }
+
+  ret = close(fd);
+  if (ret != 0)
+	  {
+      printf ("*** fd close failed: %m\n");
+      goto err;
+	  }
+
+  return 0;
+
+ err:
+  close (fd);
+  return ret;
+}
+
+#include <support/test-driver.c>