| Message ID | 20200108085326.93010-1-siddhesh@sourceware.org |
|---|---|
| State | New |
| Headers | show |
| Series | Drop dependency of dist target on ChangeLog | expand |
This looks good, except for the change to timezone/README: > +Please check the ChangeLog files in ChangeLog.old directory at the top level > +for the version of the tzcode and tzdata packages. It's awkward to have to paw through ChangeLog.old for version numbers, plus when I took the trouble to actually do that I found that the version numbers there were incorrect. So I propose the attached patch instead.
Paul Eggert wrote: > It's awkward to have to paw through ChangeLog.old for version numbers, plus > when I took the trouble to actually do that I found that the version numbers > there were incorrect. So I propose the attached patch instead. > > * timezone/version: New file, also taken from tzcode2018i. > * timezone/README: Reword so that people needn't paw through > old ChangeLog files to see which version we're using, a process > that is error-prone. Update an obsolescent URL. > --- > timezone/README | 14 ++++++++------ > timezone/version | 1 + > 2 files changed, 9 insertions(+), 6 deletions(-) > create mode 100644 timezone/version Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Thanks.
On 09/01/20 7:26 am, Paul Eggert wrote: > This looks good, except for the change to timezone/README: > >> +Please check the ChangeLog files in ChangeLog.old directory at the >> top level >> +for the version of the tzcode and tzdata packages. > > It's awkward to have to paw through ChangeLog.old for version numbers, > plus when I took the trouble to actually do that I found that the > version numbers there were incorrect. So I propose the attached patch > instead. Perfect, thanks. I'll commit my change without this doc update and you can commit this one. Siddhesh
diff --git a/Makefile b/Makefile index 3dafcec2b2..8f0a93aceb 100644 --- a/Makefile +++ b/Makefile @@ -673,7 +673,7 @@ TAGS: generated := $(generated) stubs.h -files-for-dist := README INSTALL configure ChangeLog NEWS +files-for-dist := README INSTALL configure NEWS # Regenerate stuff, then error if these things are not committed yet. dist-prepare: $(files-for-dist) diff --git a/NEWS b/NEWS index b85989ec3d..0ecee6c13b 100644 --- a/NEWS +++ b/NEWS @@ -104,6 +104,10 @@ Changes to build and runtime requirements: * It is no longer necessary to have recent Linux kernel headers to build working (non-stub) system call wrappers. +* The ChangeLog file is no longer present in the toplevel directory of the + source tree. ChangeLog files are located in the ChangeLog.old directory as + ChangeLog.N where the highest N has the latest entries. + Security related changes: CVE-2019-19126: ld.so failed to ignore the LD_PREFER_MAP_32BIT_EXEC diff --git a/timezone/README b/timezone/README index fc50f1399f..fdfdcd9403 100644 --- a/timezone/README +++ b/timezone/README @@ -9,8 +9,8 @@ The files iso3166.tab zone.tab leapseconds yearistype come from the tzdata package by Arthur David Olson et.al. -Please check the ChangeLog files in the top level directory for the -version of the tzcode and tzdata packages. +Please check the ChangeLog files in ChangeLog.old directory at the top level +for the version of the tzcode and tzdata packages. Please also see: https://sourceware.org/glibc/wiki/SharedSourceFiles