From patchwork Fri Aug 17 13:24:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 958809 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-95354-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="D6SsTkyJ"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41sP7f3Smvz9s3x for ; Fri, 17 Aug 2018 23:24:46 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:to:subject:mime-version:content-type :content-transfer-encoding:message-id:from; q=dns; s=default; b= INATPSI9rQIdKATheqVNHGHv6orkm0DI6NGm6rKT3oSFjg+TJfRObCxOwt9/H7q6 BMx/rpN/6fuQ8ZYSNz0pea1SGA9MAupzR1ltGl/empV9sXoFji4wFv9y4RGHm4zm E4KwHyNwbuEqMpM4zbg6RcrqZnVa5h9y7ZzokKRt1VM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:to:subject:mime-version:content-type :content-transfer-encoding:message-id:from; s=default; bh=tT4tW7 ZkdzrEM+nLs2jF2sTgp2o=; b=D6SsTkyJCnFFWMHfBTfmYXS7a1BP3kgR0j5XvD SKOpb7mpiqjRKUtBD674zuNYU2dielGFo8XajPA5t4PJokmcGmi9HIxd99j1UrPY Ay0eWpx7OMaFp37qZTPoVZCHOaSgD9R5D+l1PENj6H4ThrV/rNdIZgnKFypGTvmW zL83o= Received: (qmail 10590 invoked by alias); 17 Aug 2018 13:24:33 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 10315 invoked by uid 89); 17 Aug 2018 13:24:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=ordered X-HELO: mx1.redhat.com Date: Fri, 17 Aug 2018 15:24:01 +0200 To: libc-alpha@sourceware.org Subject: [PATCH] Makeconfig: Do not sort and deduplicate +cflags [BZ # 17248] User-Agent: Heirloom mailx 12.5 7/5/10 MIME-Version: 1.0 Message-Id: <20180817132401.5523B404122B7@oldenburg.str.redhat.com> From: fweimer@redhat.com (Florian Weimer) The original intent behind this is unclear. It interferes with flags that has to be ordered in a particular way. This change does not introduce any changes in the built binaries on x86-64, and build-many-glibcs.py shows no regressions, either. (I did not compare all object files, though.) 2018-08-17 Florian Weimer [BZ #17248] * Makeconfig (+cflags): Do not sort (and deduplicate). Reviewed-by: Carlos O'Donell diff --git a/Makeconfig b/Makeconfig index 92e76d6200..a9e50e5b60 100644 --- a/Makeconfig +++ b/Makeconfig @@ -902,9 +902,6 @@ endif # $(+cflags) == "" $(+stack-protector) +gcc-nowarn := -w -# Don't duplicate options if we inherited variables from the parent. -+cflags := $(sort $(+cflags)) - # Each sysdeps directory can contain header files that both will be # used to compile and will be installed. Each can also contain an # include/ subdirectory, whose header files will be used to compile