From patchwork Thu Jul 5 11:28:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 939883 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-93985-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="EQiRij71"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41Lwbc6kXPz9s29 for ; Thu, 5 Jul 2018 21:28:44 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:to:subject:mime-version:content-type :content-transfer-encoding:message-id:from; q=dns; s=default; b= w+waLhfmteSKhwdWTH0Y48DlM1DHmCTIJJbUFcLsVayilPXus1BxydO07T0zK/tc VgwMM6DKRQjYVAxEV6jD5Ch6CL8n68HvC4UJ7T18ZtFwPRWh5i7XFmL74sruw6NA nTQK3cRDbX5+pVHfXNg1grTGGfDEJNe+vywTkcJWN+E= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:to:subject:mime-version:content-type :content-transfer-encoding:message-id:from; s=default; bh=Zg3yrY 0fp2plVZzMRfZQRjL11pQ=; b=EQiRij71airOFAbthhs0kpvclzjdUWLs6s/p9X 35zk886mdB/xJmTZkgdi6b+c+hJYhYEpxL6sJQDdDCRqpL1k9gONzJuXUAzcXWTv DBifrN4uaw6XiuTdc7PGK8KAjE4EVKdOfWRkdXV/PMzl8C7qPQph6sJKZTgh+YXP X3kVo= Received: (qmail 57710 invoked by alias); 5 Jul 2018 11:28:39 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 56919 invoked by uid 89); 5 Jul 2018 11:28:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=risk X-HELO: mx1.redhat.com Date: Thu, 05 Jul 2018 13:28:35 +0200 To: libc-alpha@sourceware.org Subject: [PATCH] Compile debug/stack_chk_fail_local.c with stack protector User-Agent: Heirloom mailx 12.5 7/5/10 MIME-Version: 1.0 Message-Id: <20180705112835.50D6A43994575@oldenburg.str.redhat.com> From: fweimer@redhat.com (Florian Weimer) The resulting object file is statically linked into applications, so it is desirable to have (formal) stack protector coverage there. 2018-07-05 Florian Weimer * debug/Makefile (CFLAGS-stack_chk_fail_local.c): Remove $(no-stack-protector). stack_chk_fail_local.c can be compiled with stack protector enabled because there is no risk of infinite recursion. Reviewed-by: Carlos O'Donell diff --git a/debug/Makefile b/debug/Makefile index c6f6feb0ec..d9683a8c8c 100644 --- a/debug/Makefile +++ b/debug/Makefile @@ -61,7 +61,6 @@ elide-routines.o := stack_chk_fail_local # makes no sense. CFLAGS-stack_chk_fail.c += $(no-stack-protector) -CFLAGS-stack_chk_fail_local.c += $(no-stack-protector) CFLAGS-backtrace.c += -fno-omit-frame-pointer -funwind-tables CFLAGS-sprintf_chk.c += $(libio-mtsafe)