From patchwork Wed Jul 4 14:29:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 939393 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-93962-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="uotYpRcr"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41LNgJ18HQz9s1b for ; Thu, 5 Jul 2018 00:30:03 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:to:subject:mime-version:content-type :content-transfer-encoding:message-id:from; q=dns; s=default; b= h1bl30T6XIPTdO6D3hQF/3rZiNT9DQ0yg3MG++tOi5AuDO8bY7cZMChUWj/tTJfS 8mrWkNnFGZVifoEeEZJYW7izJeaBFa6nM1q4PraG8Zh5rVhVy5DgL179jToVdhBa 7yZxL9p06mHpR5iTDMQr22jPNKWytZqXOPFsiDouBAA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:to:subject:mime-version:content-type :content-transfer-encoding:message-id:from; s=default; bh=Az4YMi StUJ8iS5ZVLh7ZFKMDZNg=; b=uotYpRcrVapOul3UmMyv6+xvvEl0urJ/FIR7ok 7IyepHZdUNsQ5X8Y046naQ4Hn9Z1aeaxED0R8hI0I4MfqgkeuYWCxH1un3GDOI0L jm6FbtZspb6iYQSE4HXpzXNqZa+U+RWwVL45eOgoW418m1J0QazElIHwl/h7qBT1 Ebj8A= Received: (qmail 76647 invoked by alias); 4 Jul 2018 14:29:58 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 76156 invoked by uid 89); 4 Jul 2018 14:29:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=essential, Hx-languages-length:693 X-HELO: mx1.redhat.com Date: Wed, 04 Jul 2018 16:29:54 +0200 To: libc-alpha@sourceware.org Subject: [PATCH] Makeconfig (ASFLAGS): Always append required assembler flags User-Agent: Heirloom mailx 12.5 7/5/10 MIME-Version: 1.0 Message-Id: <20180704142954.4F54743994575@oldenburg.str.redhat.com> From: fweimer@redhat.com (Florian Weimer) Otherwise, it is impossible to set ASFLAGS differently from CFLAGS without also overriding essential flags such as -Wa,--noexecstack. 2018-07-04 Florian Weimer * Makeconfig (ASFLAGS): Always append required assembler flags. Reviewed-by: Carlos O'Donell diff --git a/Makeconfig b/Makeconfig index 608ffe648c..099f184088 100644 --- a/Makeconfig +++ b/Makeconfig @@ -1047,7 +1047,7 @@ endif ifndef ASFLAGS ASFLAGS := $(filter -g% -fdebug-prefix-map=%,$(CFLAGS)) endif -ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu) +override ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu) ifndef BUILD_CC BUILD_CC = $(CC)