From patchwork Mon Sep 25 23:47:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 818395 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-84934-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="W9qCAz4o"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3y1LNz4X38z9t2Q for ; Tue, 26 Sep 2017 09:47:47 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id :mime-version:content-type; q=dns; s=default; b=J9EkCDn8yy0WtlQG xwQZALjkUNPF0YeDN4NCgxqpapDufz86y55z5Nxl9neMXWCus9+ccgkzhbnygZrW +tKdn5GupFOXfcCMEoTvalQTGp++NYrLioiLvLKg0VUVzU+KsH+8RNFCbrxNdCVm haILRDJL0wEXPSlN2uPA0ftqls4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id :mime-version:content-type; s=default; bh=BMcf3w7y5+TIWNjruf+jmV XKRGo=; b=W9qCAz4oXBHwPOe+uCf/1+Ucc2NkFDkAp97AfkC/AsXrNjXFnOGCV2 IsM1X+EgjTinur4LmOvHx10qC8kWdDd5Zt5nL9hNVqCRPBi5QT2toemtFoklvHjh TrbCnYIpADuyuw9rMybSXkYmb7SVy6DNfFUYyTLroWd6gZSOn7lc0= Received: (qmail 94289 invoked by alias); 25 Sep 2017 23:47:41 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 94277 invoked by uid 89); 25 Sep 2017 23:47:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=LD, AS, $ld, 5-9 X-HELO: mail-io0-f182.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=G+E9AoY9PjaORYAaGjg1I4/zT4bEYLTHw+6cZeLL0OI=; b=nqox1AwYIdpkXHSYqZJdon9wJUAvVg4TComQ8z7TD5CzynW0lUuka2II9DapCNK+BI 8OF1QXfxumiyPY/s3rgebhIC4YH1haLv4p6KX3XZO/G+sCjeLqUfg1y+Z7P+5YlVxFkn O1RRWkOC1yNaKlqAxQQytAOk+WbiTZEcuWpxvFciGXbuJM8iXocs6GEzCs24DYvk+ACZ FWSeyjVwD2KMlJNnUI/TrNLRszGgXt2dG2YVGu29zLqbPs10wXf1VBDessc8OqdKXsJ4 OPcDzAeGWkjJwO+35vT5fml5nlQ6STYExLcIBER6t8cAGQfcG3+AgOXhj7fJrz7tpJNZ /QQQ== X-Gm-Message-State: AHPjjUjiXlepAzUCFGAxHdYlgHxoqe9jRxq2Pc82cDKPyQpxJMRwonqy kuKE+IzpQ7LVb+ZZB+LKH7sRGZ0e X-Google-Smtp-Source: AOwi7QA89yQUl0T0UwvH7vq0aw3HhwJpW9uNu1TE1ZU94mpBqEuLNl9iP2SI486as1CgCY4Z2K51CA== X-Received: by 10.107.161.80 with SMTP id k77mr8295794ioe.206.1506383255518; Mon, 25 Sep 2017 16:47:35 -0700 (PDT) Date: Mon, 25 Sep 2017 16:47:28 -0700 From: "H.J. Lu" To: GNU C Library Cc: Joseph Myers Subject: [PATCH] Update configure.ac for binutils 2.25 Message-ID: <20170925234727.GA10561@gmail.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.8.3 (2017-05-23) Commit 073e8fa7739ed453d6854b834f290c263a6cdb9f requires binutils 2.25 or later to build glibc: * configure.ac (AS): Require binutils 2.25 or later. (LD): Likewise. But it only updated LD version check in configure.ac. This patch adds the missing AS version check. I will check it in shortly. H.J. --- * configure.ac (AS): Require binutils 2.25 or later. * configure: Regenerated. --- configure | 4 ++-- configure.ac | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 5cb5210107..067d92d2ba 100755 --- a/configure +++ b/configure @@ -4615,7 +4615,7 @@ $as_echo "$libc_cv_prog_ld_gnu" >&6; } gnu_ld=$libc_cv_prog_ld_gnu -# Accept binutils 2.22 or newer. +# Accept binutils 2.25 or newer. for ac_prog in $AS do # Extract the first word of "$ac_prog", so it can be a program name with args. @@ -4667,7 +4667,7 @@ $as_echo_n "checking version of $AS... " >&6; } ac_prog_version=`$AS --version 2>&1 | sed -n 's/^.*GNU assembler.* \([0-9]*\.[0-9.]*\).*$/\1/p'` case $ac_prog_version in '') ac_prog_version="v. ?.??, bad"; ac_verc_fail=yes;; - 2.1[0-9][0-9]*|2.2[2-9]*|2.[3-9][0-9]*|[3-9].*|[1-9][0-9]*) + 2.1[0-9][0-9]*|2.2[5-9]*|2.[3-9][0-9]*|[3-9].*|[1-9][0-9]*) ac_prog_version="$ac_prog_version, ok"; ac_verc_fail=no;; *) ac_prog_version="$ac_prog_version, bad"; ac_verc_fail=yes;; diff --git a/configure.ac b/configure.ac index 2c6308883c..d412104d8c 100644 --- a/configure.ac +++ b/configure.ac @@ -1078,10 +1078,10 @@ AC_PROG_LN_S LIBC_PROG_BINUTILS -# Accept binutils 2.22 or newer. +# Accept binutils 2.25 or newer. AC_CHECK_PROG_VER(AS, $AS, --version, [GNU assembler.* \([0-9]*\.[0-9.]*\)], - [2.1[0-9][0-9]*|2.2[2-9]*|2.[3-9][0-9]*|[3-9].*|[1-9][0-9]*], + [2.1[0-9][0-9]*|2.2[5-9]*|2.[3-9][0-9]*|[3-9].*|[1-9][0-9]*], AS=: critic_missing="$critic_missing as") if test -n "`$LD --version | sed -n 's/^GNU \(gold\).*$/\1/p'`"; then