diff mbox

x86-64: Check PIC instead of SHARED in start.S

Message ID 20170802160005.GA3548@intel.com
State New
Headers show

Commit Message

H.J. Lu Aug. 2, 2017, 4 p.m. UTC 
Since start.o may be compiled as PIC, we should check PIC instead of
SHARED.

Any comments or objections?


H.J.
--
	* sysdeps/x86_64/start.S (_start): Check PIC instead of SHARED.
---
 sysdeps/x86_64/start.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Florian Weimer Aug. 2, 2017, 5:19 p.m. UTC | #1 
* H. J. Lu:

> Since start.o may be compiled as PIC, we should check PIC instead of
> SHARED.
>
> Any comments or objections?

Looks reasonable.
diff mbox

Patch

diff --git a/sysdeps/x86_64/start.S b/sysdeps/x86_64/start.S
index 62a00eaeaa..9edd17b60c 100644
--- a/sysdeps/x86_64/start.S
+++ b/sysdeps/x86_64/start.S
@@ -96,7 +96,7 @@  ENTRY (_start)
 	   which grow downwards).  */
 	pushq %rsp
 
-#ifdef SHARED
+#ifdef PIC
 	/* Pass address of our own entry points to .fini and .init.  */
 	mov __libc_csu_fini@GOTPCREL(%rip), %R8_LP
 	mov __libc_csu_init@GOTPCREL(%rip), %RCX_LP