From patchwork Thu Jun 23 14:40:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 639669 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rb3zr2lT8z9s9n for ; Fri, 24 Jun 2016 00:40:56 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b=joM+VpRJ; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:to:subject:mime-version:content-type :content-transfer-encoding:message-id:from; q=dns; s=default; b= HyjeIUSYX2RnMn9IS7J2wV1Y1S5g7EmNscX80g/ydCs44NRBpACIx+wqX1TlxBnm lQbrGTgkKhNgJdmJnvUHHQOuLZwHhVmhF/7TgXfP7fkth8A+Aq0Zajf5hWt2ITI8 BZuPL5m0UItvt1mDmEfeoc7SibRCLaFXc3toOfzVfmk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:to:subject:mime-version:content-type :content-transfer-encoding:message-id:from; s=default; bh=qQ/BhU kQHGGkq0KBIbRUMSgH9GM=; b=joM+VpRJNAxBQ81mzf0p2W3ylXd9gYK/mi9JK0 xZQZrKfWNxD0SAmlUrhVSluJtdL1xtMah31/E8Psys2HZQN109KBdlGqyJnQV2zF GBcVwXgabMNTtgpalCT79OrvyP+Sx2Qlf/M4JcfJBWy0ISjFUoZA0GQRprzbn+AG wLWqo= Received: (qmail 15224 invoked by alias); 23 Jun 2016 14:40:49 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 15207 invoked by uid 89); 23 Jun 2016 14:40:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=3469, 3466 X-HELO: mx1.redhat.com Date: Thu, 23 Jun 2016 16:40:42 +0200 To: libc-alpha@sourceware.org Subject: [PATCH] test-skeleton.c: Do not enable M_PERTURB User-Agent: Heirloom mailx 12.5 7/5/10 MIME-Version: 1.0 Message-Id: <20160623144042.E649F41C390E5@oldenburg.str.redhat.com> From: fweimer@redhat.com (Florian Weimer) Over all, this decreases the realism of the tests because it ensures that freshly allocated memory has a well-defined bit pattern. It also causes malloc to take internal paths different from regular application usage, and therefore reduces malloc test coverage. 2016-06-23 Florian Weimer * test-skeleton.c (main): Do not enable M_PERTURB. diff --git a/test-skeleton.c b/test-skeleton.c index d9bf989..e462eee 100644 --- a/test-skeleton.c +++ b/test-skeleton.c @@ -346,9 +346,6 @@ main (int argc, char *argv[]) unsigned int timeoutfactor = 1; pid_t termpid; - /* Make uses of freed and uninitialized memory known. */ - mallopt (M_PERTURB, 42); - #ifdef STDOUT_UNBUFFERED setbuf (stdout, NULL); #endif