Message ID | 20160408225740.GE6588@vapier.lan |
---|---|
State | New |
Headers | show |
Mike, Thanks for pushing it and even more for digging out those test-suite references, I would not have thought to look for the locale name there as well. cjl On Fri, Apr 8, 2016 at 6:57 PM, Mike Frysinger <vapier@gentoo.org> wrote: > On 25 Feb 2016 15:10, Mike Frysinger wrote: >> On 19 Feb 2016 02:28, Mike Frysinger wrote: >> > From the bug: >> > Obsolete locale. The ISO-639 code for Hebrew was changed from 'iw' >> > to 'he' in 1989, according to Bruno Haible on libc-alpha 2003-09-01. >> >> ping ... > > i've pushed this now with a benchtest update: > --- a/benchtests/Makefile > +++ b/benchtests/Makefile > @@ -48,7 +48,7 @@ string-benchset-all := $(string-benchset) ${wcsmbs-benchset} > LOCALES := en_US.UTF-8 tr_TR.UTF-8 cs_CZ.UTF-8 fa_IR.UTF-8 fr_FR.UTF-8 \ > ja_JP.UTF-8 si_LK.UTF-8 en_GB.UTF-8 vi_VN.UTF-8 ar_SA.UTF-8 \ > da_DK.UTF-8 pl_PL.UTF-8 pt_PT.UTF-8 el_GR.UTF-8 ru_RU.UTF-8 \ > - iw_IL.UTF-8 is_IS.UTF-8 es_ES.UTF-8 hi_IN.UTF-8 sv_SE.UTF-8 \ > + he_IL.UTF-8 is_IS.UTF-8 es_ES.UTF-8 hi_IN.UTF-8 sv_SE.UTF-8 \ > hu_HU.UTF-8 it_IT.UTF-8 sr_RS.UTF-8 zh_CN.UTF-8 > include ../gen-locales.mk > > --- a/benchtests/bench-strcoll.c > +++ b/benchtests/bench-strcoll.c > @@ -44,7 +44,7 @@ static const char *const input_files[] = { > "lorem_ipsum#pt_PT.UTF-8", > "lorem_ipsum#el_GR.UTF-8", > "lorem_ipsum#ru_RU.UTF-8", > - "lorem_ipsum#iw_IL.UTF-8", > + "lorem_ipsum#he_IL.UTF-8", > "lorem_ipsum#es_ES.UTF-8", > "lorem_ipsum#hi_IN.UTF-8", > "lorem_ipsum#sv_SE.UTF-8", > --- a/benchtests/strcoll-inputs/filelist#en_US.UTF-8 > +++ b/benchtests/strcoll-inputs/filelist#en_US.UTF-8 > @@ -10525,7 +10525,7 @@ lorem_ipsum_el_GR > lorem_ipsum_pt_PT > lorem_ipsum_tr_TR > en_US > -lorem_ipsum_iw_IL > +lorem_ipsum_he_IL > lorem_ipsum_ru_RU > lorem_ipsum_hu_HU > lorem_ipsum_ja_JP > @@ -11550,7 +11550,6 @@ tr_TR > iu_CA > szl_PL > fr_BE@euro > -iw_IL > fy_NL > mn_MN > cmn_TW > rename from benchtests/strcoll-inputs/lorem_ipsum#iw_IL.UTF-8 > rename to benchtests/strcoll-inputs/lorem_ipsum#he_IL.UTF-8 > > -mike
* Mike Frysinger:
> i've pushed this now with a benchtest update:
I think those are just lists of strings. We should keep them so that
the benchmarks keep measuring the same thing as before.
On 09 Apr 2016 13:56, Florian Weimer wrote: > * Mike Frysinger: > > > i've pushed this now with a benchtest update: > > I think those are just lists of strings. We should keep them so that > the benchmarks keep measuring the same thing as before. at least some of them weren't as they would actually process the iw_IL locale. i didn't look closely at every one once `make bench` seemed to pass. -mike
--- a/benchtests/Makefile +++ b/benchtests/Makefile @@ -48,7 +48,7 @@ string-benchset-all := $(string-benchset) ${wcsmbs-benchset} LOCALES := en_US.UTF-8 tr_TR.UTF-8 cs_CZ.UTF-8 fa_IR.UTF-8 fr_FR.UTF-8 \ ja_JP.UTF-8 si_LK.UTF-8 en_GB.UTF-8 vi_VN.UTF-8 ar_SA.UTF-8 \ da_DK.UTF-8 pl_PL.UTF-8 pt_PT.UTF-8 el_GR.UTF-8 ru_RU.UTF-8 \ - iw_IL.UTF-8 is_IS.UTF-8 es_ES.UTF-8 hi_IN.UTF-8 sv_SE.UTF-8 \ + he_IL.UTF-8 is_IS.UTF-8 es_ES.UTF-8 hi_IN.UTF-8 sv_SE.UTF-8 \ hu_HU.UTF-8 it_IT.UTF-8 sr_RS.UTF-8 zh_CN.UTF-8 include ../gen-locales.mk --- a/benchtests/bench-strcoll.c +++ b/benchtests/bench-strcoll.c @@ -44,7 +44,7 @@ static const char *const input_files[] = { "lorem_ipsum#pt_PT.UTF-8", "lorem_ipsum#el_GR.UTF-8", "lorem_ipsum#ru_RU.UTF-8", - "lorem_ipsum#iw_IL.UTF-8", + "lorem_ipsum#he_IL.UTF-8", "lorem_ipsum#es_ES.UTF-8", "lorem_ipsum#hi_IN.UTF-8", "lorem_ipsum#sv_SE.UTF-8", --- a/benchtests/strcoll-inputs/filelist#en_US.UTF-8 +++ b/benchtests/strcoll-inputs/filelist#en_US.UTF-8 @@ -10525,7 +10525,7 @@ lorem_ipsum_el_GR lorem_ipsum_pt_PT lorem_ipsum_tr_TR en_US -lorem_ipsum_iw_IL +lorem_ipsum_he_IL lorem_ipsum_ru_RU lorem_ipsum_hu_HU lorem_ipsum_ja_JP @@ -11550,7 +11550,6 @@ tr_TR iu_CA szl_PL fr_BE@euro -iw_IL fy_NL mn_MN cmn_TW