From patchwork Mon Jan 25 19:26:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Miller X-Patchwork-Id: 572864 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 964F7140774 for ; Tue, 26 Jan 2016 06:26:27 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b=O4xfifiS; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:message-id:to:cc:subject:from:in-reply-to :references:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=bS6eEmYg8Wd3pljVfj8KMvQQvUuDD54wsyfrTSSy3Kh CHb2cyGYZJcFUmYB4BbFeZ4/+Tyw+UpzqqFPI97/XlRlcFrnkaoKE7A4qLZ5Fa0q Kjhx2lHM/I6aCbNPqe+zYgB3PU7e7MpiSmPxnQzfW67q3yy2LTRXOCNNEpd4KEFI = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:message-id:to:cc:subject:from:in-reply-to :references:mime-version:content-type:content-transfer-encoding; s=default; bh=aBRW7Sr2dzk9JIs3PIthOrHyNtA=; b=O4xfifiSGLVg7dils EsBdGqGaN9ubDViuiyXQFoTVjDPfE4CBEhx+nzVfiz5M2V87S9Ppz50y7TwwC7Gj yQGR6S6QB3NcS6YI7yhbVBGxg+6XtQPdWXdPhWdlOfmZlcJMSJPuonzAgGHZOcdZ lfzC2vwOTh3o7cVgyhx6WOcvC4= Received: (qmail 38503 invoked by alias); 25 Jan 2016 19:26:20 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 38493 invoked by uid 89); 25 Jan 2016 19:26:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=Hx-languages-length:1297, e_sqrtl.c, UD:e_sqrtl.c, e_sqrtlc X-HELO: shards.monkeyblade.net Date: Mon, 25 Jan 2016 11:26:17 -0800 (PST) Message-Id: <20160125.112617.1980346546297775887.davem@davemloft.net> To: rth@twiddle.net Cc: joseph@codesourcery.com, libc-alpha@sourceware.org Subject: Re: [PATCH COMMITTED] Adjust sparc 32-bit __sqrtl_finite version tag. From: David Miller In-Reply-To: <56A6729E.5050703@twiddle.net> References: <20160125.110050.1847019402132253680.davem@davemloft.net> <56A6729E.5050703@twiddle.net> Mime-Version: 1.0 From: Richard Henderson Date: Mon, 25 Jan 2016 11:08:14 -0800 > On 01/25/2016 11:00 AM, David Miller wrote: >> } >> strong_alias (__ieee754_sqrtl, __sqrtl_finite) >> + >> +#include >> +versioned_symbol (libm, __sqrtl_finite, sqrtl_finite, GLIBC_2_23); > > sqrtl_finite (no underscores) is not an exported symbol. > > Drop the strong alias and version from __ieee754_sqrtl to __sqrtl_finite. Aha, I see. Testing the following... diff --git a/sysdeps/sparc/sparc32/fpu/e_sqrtl.c b/sysdeps/sparc/sparc32/fpu/e_sqrtl.c index 46ad861..b0ce44a 100644 --- a/sysdeps/sparc/sparc32/fpu/e_sqrtl.c +++ b/sysdeps/sparc/sparc32/fpu/e_sqrtl.c @@ -25,4 +25,6 @@ __ieee754_sqrtl (long double x) { return _Q_sqrt (x); } -strong_alias (__ieee754_sqrtl, __sqrtl_finite) + +#include +versioned_symbol (libm, __ieee754_sqrtl, __sqrtl_finite, GLIBC_2_23); diff --git a/sysdeps/unix/sysv/linux/sparc/sparc32/Versions b/sysdeps/unix/sysv/linux/sparc/sparc32/Versions index c9a5b3e..a0b9c19 100644 --- a/sysdeps/unix/sysv/linux/sparc/sparc32/Versions +++ b/sysdeps/unix/sysv/linux/sparc/sparc32/Versions @@ -24,3 +24,9 @@ libc { fallocate64; } } + +libm { + GLIBC_2.23 { + __sqrtl_finite; + } +}