From patchwork Mon Jan 25 19:00:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Miller X-Patchwork-Id: 572860 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 88FB0140326 for ; Tue, 26 Jan 2016 06:01:02 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b=uSCeOwPb; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:message-id:to:cc:subject:from:in-reply-to :references:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=KkV0ag4gbqbCGjBkrQjZe8VQks0vnKJxXdBaqjzPPuF CGBeJ4jJLF6W+94dPXMRaIZzNAQQPoSh4QVrUKenArsd067Gug4L9PBilg1Xr496 dVI6gUfrXIQMokl4MLdgVTF/hBVFsJ4Ar5ZtX9wSOciO6i7CaTnpVcH6ZwXY3ObU = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:message-id:to:cc:subject:from:in-reply-to :references:mime-version:content-type:content-transfer-encoding; s=default; bh=dhtQE+PmHFttvYlYZ/m1d9W1x9Y=; b=uSCeOwPbl9kX0b6wW v9ea0vUv0gB+40TZRAyo4LTFqt51c9FzaEMDWxdg+KKPGW6wzB6cffVsyz4E09qH 20EGk0lbVQj2V1OQ0x/gQl1sKWpvg/pGKRFqDzfrV8HiO7TXw1rD2IbEL+AikIgM WUoz+IPKbnep1XbuYeAtQEAl1E= Received: (qmail 19935 invoked by alias); 25 Jan 2016 19:00:54 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 19920 invoked by uid 89); 25 Jan 2016 19:00:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=UD:e_sqrtl.c, e_sqrtl.c, e_sqrtlc, __ieee754_sqrtl X-HELO: shards.monkeyblade.net Date: Mon, 25 Jan 2016 11:00:50 -0800 (PST) Message-Id: <20160125.110050.1847019402132253680.davem@davemloft.net> To: joseph@codesourcery.com Cc: libc-alpha@sourceware.org Subject: Re: [PATCH COMMITTED] Adjust sparc 32-bit __sqrtl_finite version tag. From: David Miller In-Reply-To: References: <20160125.104334.434410107130817436.davem@davemloft.net> Mime-Version: 1.0 From: Joseph Myers Date: Mon, 25 Jan 2016 18:47:21 +0000 > Presumably you also need to add a Versions entry for this and maybe define > the function using versioned_symbol, so that it gets exported at the new > version and does not get exported at the old version? Hmmm, something like this? diff --git a/sysdeps/sparc/sparc32/fpu/e_sqrtl.c b/sysdeps/sparc/sparc32/fpu/e_sqrtl.c index 46ad861..30d4d34 100644 --- a/sysdeps/sparc/sparc32/fpu/e_sqrtl.c +++ b/sysdeps/sparc/sparc32/fpu/e_sqrtl.c @@ -26,3 +26,6 @@ __ieee754_sqrtl (long double x) return _Q_sqrt (x); } strong_alias (__ieee754_sqrtl, __sqrtl_finite) + +#include +versioned_symbol (libm, __sqrtl_finite, sqrtl_finite, GLIBC_2_23); diff --git a/sysdeps/unix/sysv/linux/sparc/sparc32/Versions b/sysdeps/unix/sysv/linux/sparc/sparc32/Versions index c9a5b3e..a0b9c19 100644 --- a/sysdeps/unix/sysv/linux/sparc/sparc32/Versions +++ b/sysdeps/unix/sysv/linux/sparc/sparc32/Versions @@ -24,3 +24,9 @@ libc { fallocate64; } } + +libm { + GLIBC_2.23 { + __sqrtl_finite; + } +}