diff mbox

[BZ,2898] Mention mkdtemp as another secure alternative to mktemp

Message ID 20150809093430.GA7925@glebfm.cloud.tilaa.com
State New
Headers show

Commit Message

Gleb Fotengauer-Malinovskiy Aug. 9, 2015, 9:34 a.m. UTC 
[BZ #2898]
* misc/mktemp.c: Add mkdtemp to link_warning message.
Patch by Aurelien Jarno.
---
 misc/mktemp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mike Frysinger Aug. 9, 2015, 10:53 a.m. UTC | #1 
i'm fine with this.  i don't think there is confusion with the two funcs listed.
-mike
Dmitry V. Levin Aug. 14, 2015, 11:15 p.m. UTC | #2 
On Sun, Aug 09, 2015 at 11:34:31AM +0200, Gleb Fotengauer-Malinovskiy wrote:
> [BZ #2898]
> * misc/mktemp.c: Add mkdtemp to link_warning message.
> Patch by Aurelien Jarno.
> ---
>  misc/mktemp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/misc/mktemp.c b/misc/mktemp.c
> index fc82ede..a144938 100644
> --- a/misc/mktemp.c
> +++ b/misc/mktemp.c
> @@ -33,4 +33,4 @@ __mktemp (template)
>  }
>  weak_alias (__mktemp, mktemp)
>  
> -link_warning (mktemp, "the use of `mktemp' is dangerous, better use `mkstemp'")
> +link_warning (mktemp, "the use of `mktemp' is dangerous, better use `mkstemp' or `mkdtemp'")

This line is too long.  Besides that, LGTM.
diff mbox

Patch

diff --git a/misc/mktemp.c b/misc/mktemp.c
index fc82ede..a144938 100644
--- a/misc/mktemp.c
+++ b/misc/mktemp.c
@@ -33,4 +33,4 @@  __mktemp (template)
 }
 weak_alias (__mktemp, mktemp)
 
-link_warning (mktemp, "the use of `mktemp' is dangerous, better use `mkstemp'")
+link_warning (mktemp, "the use of `mktemp' is dangerous, better use `mkstemp' or `mkdtemp'")