From patchwork Sat May 31 02:03:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kaz Kojima X-Patchwork-Id: 354374 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id E3D54140101 for ; Sat, 31 May 2014 12:04:43 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:message-id:to:cc:subject:from:in-reply-to :references:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=TtbsegrL0IBTbvwKre9RzC12pM7c2huuxl3q8zMRVmI xtFMEI4i97WeHi7xCdYokf38i7VU+L2cYv+SsyKoWz4dtE/gntpdThuEq3rVx5Fu pwljVX65LO2AvMJTHTc1ZeCCHaFjjP3EMhmvDvwuB5vTBGclGSRJxQDi0Af/9Buo = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:message-id:to:cc:subject:from:in-reply-to :references:mime-version:content-type:content-transfer-encoding; s=default; bh=Q+zxcZuRcjXBxpKIiZbA6pqGhYI=; b=KnmXhjPha3lP3YCUm +GcKNXDiki2X8XKwmm4aOzBZgs/24NY0ZDBoBrhHyJ9TcKKnwc0fIBL0HOGLhmAr hjIHv06DxXiwqA3NWQTuCAlxsmZw+1n+G3/TDMvmQQADJtiVm3/m2JX4pSRe/fRJ mn6mWixoabHl+M0gtRLY5Q25DM= Received: (qmail 32739 invoked by alias); 31 May 2014 02:04:36 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 27800 invoked by uid 89); 31 May 2014 02:04:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mo-sw.iij4u.or.jp Date: Sat, 31 May 2014 11:03:53 +0900 (JST) Message-Id: <20140531.110353.293156792.kkojima@rr.iij4u.or.jp> To: roland@hack.frob.com Cc: libc-alpha@sourceware.org Subject: Re: [PATCH roland/nptl-sh] SH: Consolidate NPTL/non versions of vfork From: Kaz Kojima In-Reply-To: <20140530161958.15CE72C39B6@topped-with-meat.com> References: <20140529230926.133C22C3C21@topped-with-meat.com> <20140530.134750.439128275.kkojima@rr.iij4u.or.jp> <20140530161958.15CE72C39B6@topped-with-meat.com> Mime-Version: 1.0 Roland McGrath wrote: > I've made that fix on the branch. Please let me know if it works now. > (Or feel free to just commit it yourself if you prefer.) I've got /tmp/ccAPJUC8.s: Assembler messages: /tmp/ccAPJUC8.s: Error: .size expression for __vfork does not evaluate to a constant when compiling. From alpha/vfork.S, the patch below may fix the issue. With it in origin/roland/nptl-sh branch, it looks vfork objects are in good shape. Regards, kaz diff --git a/sysdeps/unix/sysv/linux/sh/vfork.S b/sysdeps/unix/sysv/linux/sh/vfork.S index 157a38c..76326f5 100644 --- a/sysdeps/unix/sysv/linux/sh/vfork.S +++ b/sysdeps/unix/sysv/linux/sh/vfork.S @@ -64,10 +64,7 @@ ENTRY (__libc_vfork) .L2: .word PID - TLS_PRE_TCB_SIZE .align 2 -PSEUDO_END (__vfork) -libc_hidden_def (__vfork) - -weak_alias (__vfork, vfork) +PSEUDO_END (__libc_vfork) #if !NOT_IN_libc weak_alias (__libc_vfork, vfork)