Message ID | 1617874149-11830-1-git-send-email-ayush.m@samsung.com |
---|---|
State | New |
Headers | show |
Series | [1/1] malloc: remove redundant check of unsorted bin corruption | expand |
Ayush Mittal via Libc-alpha <libc-alpha@sourceware.org> writes: > * malloc/malloc.c (_int_malloc): remove redundant check of > unsorted bin corruption > > With commit "b90ddd08f6dd688e651df9ee89ca3a69ff88cd0c" > (malloc: Additional checks for unsorted bin integrity), > same check of (bck->fd != victim) is added before checking of unsorted > chunk corruption, which was added in "bdc3009b8ff0effdbbfb05eb6b10966753cbf9b8" > (Added check before removing from unsorted list). Sorry this one fell through the cracks. LGTM. Pushed. Reviewed-by: DJ Delorie <dj@redhat.com>
diff --git a/malloc/malloc.c b/malloc/malloc.c index 5b87bdb081..77bde442ab 100644 --- a/malloc/malloc.c +++ b/malloc/malloc.c @@ -3813,8 +3813,6 @@ _int_malloc (mstate av, size_t bytes) } /* remove from unsorted list */ - if (__glibc_unlikely (bck->fd != victim)) - malloc_printerr ("malloc(): corrupted unsorted chunks 3"); unsorted_chunks (av)->bk = bck; bck->fd = unsorted_chunks (av);