From patchwork Mon Nov 6 13:37:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 834755 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-86799-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="ejj1Nxu6"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yVttv5dzXz9s7c for ; Tue, 7 Nov 2017 00:38:47 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=GSe37RVO8VluGunsJtoqGwjZ8ES+yaG /UJMt3F+IT5Lqvu86GhRSSe9YscS0QDuXJofqvCvXbPWKf2CUDvrvo3ZTdCfuJqy ZC9G3S5d1ScSxQsgHLfjE06x5kXrvllZi9u2J20CuW0y88zA0+P9yK4+vCpCtQwn R04UPiBSQWXk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=GD1g3H4JCFDV2f2cIMoq4g26Hgc=; b=ejj1N xu6AQKAUEL98AnUDlqcSi7/6haJlHEh9DnngWus7EniefRL97Mc5E0BUISE17F38 4wBicZ17rPP5w4zKsNPTyN8N3ksD9mWcgBqViKuwlgSt+jqNBkLrz1kJCShfVPr5 j8aKO6yBy5v/IczFD/NjbwJiMbd5lc58/XIeW8= Received: (qmail 34627 invoked by alias); 6 Nov 2017 13:37:29 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 34557 invoked by uid 89); 6 Nov 2017 13:37:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qk0-f196.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=33EK0PEZRpn5cnTeYV6UfjtzyU0oM/Hx806B8FL3c84=; b=QljWSewNQb4vnwWBkqxKWequih9FzANg6LEmDPqIrC+SOwsBjF3pKukctNw3M/+75U 30a+fqQR5TAwlNA4RzbFPFvjgNidTwTyKUt+BJfS3mYzpwMH07buvmdcOQV9EEjTFxT7 YBEsZwwOfhuP6d3pmNWHhizthbZDwHeqT74x29CesUnih9l9MSrMJ6++4mrGGOHXbDy0 zQEHqj3XMRvMXcERnD2/hBelbsvpUeDKMibXMQNIYKQBvkpWNL0u5MbcpToLELyaPGm+ sM36m6YCc6abam71PPiBm5E51uvKMt0h2ZM2Mn3ZCizArV4gzHb9ecPJOdOArVI4bQDk /FMA== X-Gm-Message-State: AJaThX5lM/mVpswHByQUEJN1Tc8tEKtPjVaGN/BInXo9QoE82ODbR+i7 0AdoCkYPdGEgr33/rWPTabFdtPKwkGw= X-Google-Smtp-Source: ABhQp+QaiNhu0UeW70TN0ZrLvbxhUBQZEWqSZBKKTUDoP8tFtUJT9238CCNK1FKEiRMjjV+DucFm/A== X-Received: by 10.55.21.135 with SMTP id 7mr9966090qkv.216.1509975445293; Mon, 06 Nov 2017 05:37:25 -0800 (PST) From: Adhemerval Zanella To: libc-alpha@sourceware.org Subject: [PATCH v2 8/8] Optimize sigrelse implementation Date: Mon, 6 Nov 2017 11:37:06 -0200 Message-Id: <1509975426-1772-8-git-send-email-adhemerval.zanella@linaro.org> In-Reply-To: <1509975426-1772-1-git-send-email-adhemerval.zanella@linaro.org> References: <1509975426-1772-1-git-send-email-adhemerval.zanella@linaro.org> This patch simplifies sighold a bit by removing an extra sigprocmask and using SIG_BLOCK (which union of the current set and the set argument). Checked on x86_64-linux-gnu. * signal/sighold.c (sighold): Optimize implementation. Signed-off-by: Adhemerval Zanella --- ChangeLog | 2 ++ signal/sigrelse.c | 12 +++--------- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/signal/sigrelse.c b/signal/sigrelse.c index e41c2bd..61f240b 100644 --- a/signal/sigrelse.c +++ b/signal/sigrelse.c @@ -26,14 +26,8 @@ sigrelse (int sig) { sigset_t set; - /* Retrieve current signal set. */ - if (__sigprocmask (SIG_SETMASK, NULL, &set) < 0) + sigemptyset (&set); + if (sigaddset (&set, sig) < 0) return -1; - - /* Remove the specified signal. */ - if (sigdelset (&set, sig) < 0) - return -1; - - /* Set the new mask. */ - return __sigprocmask (SIG_SETMASK, &set, NULL); + return __sigprocmask (SIG_UNBLOCK, &set, NULL); }