diff mbox

Add Phillipines peso symbol to translit_neutral

Message ID 1461426795-14966-1-git-send-email-raj.khem@gmail.com
State New
Headers show

Commit Message

Khem Raj April 23, 2016, 3:53 p.m. UTC
Fixes
usr/share/i18n/locales/tl_PH:87: LC_MONETARY: unknown character in field `currency_symbol’

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 localedata/ChangeLog                | 4 ++++
 localedata/locales/translit_neutral | 2 ++
 2 files changed, 6 insertions(+)

Comments

Florian Weimer April 23, 2016, 5:59 p.m. UTC | #1
* Khem Raj:

> Fixes
> usr/share/i18n/locales/tl_PH:87: LC_MONETARY: unknown character in field `currency_symbol’

Why does this fix the bug?

> +% PHILIPPINES PESO SIGN
> +<U20B1> "<U0050><U0068><U0050>"

Is this the correct transliteration?  It is not listed in Unicode.
Chris Leonard April 23, 2016, 7:16 p.m. UTC | #2
https://en.wikipedia.org/wiki/Philippine_peso_sign

see encoding section

On Sat, Apr 23, 2016 at 1:59 PM, Florian Weimer <fw@deneb.enyo.de> wrote:
> * Khem Raj:
>
>> Fixes
>> usr/share/i18n/locales/tl_PH:87: LC_MONETARY: unknown character in field `currency_symbol’
>
> Why does this fix the bug?
>
>> +% PHILIPPINES PESO SIGN
>> +<U20B1> "<U0050><U0068><U0050>"
>
> Is this the correct transliteration?  It is not listed in Unicode.
Mike Frysinger April 23, 2016, 7:58 p.m. UTC | #3
On 23 Apr 2016 19:59, Florian Weimer wrote:
> * Khem Raj:
> > Fixes
> > usr/share/i18n/locales/tl_PH:87: LC_MONETARY: unknown character in field `currency_symbol’
> 
> Why does this fix the bug?

he didn't mention the encoding ... this is ISO-8859-1.  so the translit
changes it from the unicode/utf-8 ₱ to PHP as the former can't be encoded.

(i'm sure you know much of this already ... just trying to avoid anymore
confusion due to missing/assumed info)

> > +% PHILIPPINES PESO SIGN
> > +<U20B1> "<U0050><U0068><U0050>"
> 
> Is this the correct transliteration?  It is not listed in Unicode.

it is, the same as £ & ¥ -- just use the currency code in place of the
symbol.  where in the standard are you finding the definition for the
translit_neutral file ?  it doesn't seem to be handled by unicode-gen/
(yet?).  there's more symbols we need to add ...
-mike
Florian Weimer April 23, 2016, 8:15 p.m. UTC | #4
* Mike Frysinger:

>> Is this the correct transliteration?  It is not listed in Unicode.
>
> it is, the same as £ & ¥ -- just use the currency code in place of the
> symbol.  where in the standard are you finding the definition for the
> translit_neutral file ?

Unicode sometimes give transliterations, but not in this case.  I
assume because the correct transliteration is locale-dependent.  If
you translate to the currency code, there are multiple choices for ¥
(for Japanese Yen and Chinese Yuan) and perhaps ₱ (as this was used in
other countries, not just the Philippines).  £ may also have been used
for Italian Lire.
Mike Frysinger April 23, 2016, 8:54 p.m. UTC | #5
On 23 Apr 2016 22:15, Florian Weimer wrote:
> * Mike Frysinger:
> >> Is this the correct transliteration?  It is not listed in Unicode.
> >
> > it is, the same as £ & ¥ -- just use the currency code in place of the
> > symbol.  where in the standard are you finding the definition for the
> > translit_neutral file ?
> 
> Unicode sometimes give transliterations, but not in this case.  I
> assume because the correct transliteration is locale-dependent.  If
> you translate to the currency code, there are multiple choices for ¥
> (for Japanese Yen and Chinese Yuan) and perhaps ₱ (as this was used in
> other countries, not just the Philippines).  £ may also have been used
> for Italian Lire.

but we've made a choice already for ¥ & £ in this file:
% POUND SIGN
<U00A3> "<U0047><U0042><U0050>"
% YEN SIGN
<U00A5> "<U004A><U0050><U0059>"

Unicode has given a diff codepoint for the Lira: <U20A4>.  although they
did use £ in the past, and people might still (since it's more common on
keyboards).

you're right that the Yen-vs-Renminbi is not unambiguous, and considering
the way the Unicode consortium has treated CJK in the past (just see the
misguided "Han Unification" strategy), i don't expect this to change.  we
can pick an obvious "winner" for some locales (like zh_* & ja_*), but what
about common ones like en_US ?  do we leave ¥ unmapped ?

while you're right that other countries have used "the peso", have any
used the ₱ symbol ?  mexico for instance has used $ instead.
-mike
diff mbox

Patch

diff --git a/localedata/ChangeLog b/localedata/ChangeLog
index 320bb8d..999e5b1 100644
--- a/localedata/ChangeLog
+++ b/localedata/ChangeLog
@@ -1,3 +1,7 @@ 
+2016-04-23  Khem Raj  <raj.khem@gmail.com>
+
+	* locales/translit_neutral: Add entry for U20B1.
+
 2016-04-16  Mike Frysinger  <vapier@gentoo.org>
 
 	* locales/fil_PH (LC_TELEPHONE): Change copy to en_PH.
diff --git a/localedata/locales/translit_neutral b/localedata/locales/translit_neutral
index b15d01f..02c60c5 100644
--- a/localedata/locales/translit_neutral
+++ b/localedata/locales/translit_neutral
@@ -567,6 +567,8 @@  include "translit_wide";""
 <U20AC> "<U0045><U0055><U0052>"
 % DRACHMA SIGN
 <U20AF> "<U0047><U0052><U0044>"
+% PHILIPPINES PESO SIGN
+<U20B1> "<U0050><U0068><U0050>"
 % HRYVNIA SIGN
 <U20B4> "<U0433><U0440><U043D>";"<U0055><U0041><U0048>"
 % INDIAN RUPEE SIGN