diff mbox

[10/12] Add fesetexcept: s390

Message ID 0b8092e6-1be4-8953-dbdd-77922469a5b2@linux.vnet.ibm.com
State New
Headers show

Commit Message

Stefan Liebler Aug. 15, 2016, 8:07 a.m. UTC 
On 08/11/2016 11:03 PM, Joseph Myers wrote:
> This patch adds an S/390 version of fesetexcept.  Untested.
>
> 2016-08-11  Joseph Myers  <joseph@codesourcery.com>
>
> 	* sysdeps/s390/fpu/fesetexcept.c: New file.
>
> diff --git a/sysdeps/s390/fpu/fesetexcept.c b/sysdeps/s390/fpu/fesetexcept.c
> new file mode 100644
> index 0000000..4728f3e
> --- /dev/null
> +++ b/sysdeps/s390/fpu/fesetexcept.c
> @@ -0,0 +1,32 @@
> +/* Set given exception flags.  S/390 version.
> +   Copyright (C) 2016 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Lesser General Public License for more details.
> +
> +   You should have received a copy of the GNU Lesser General Public
> +   License along with the GNU C Library; if not, see
> +   <http://www.gnu.org/licenses/>.  */
> +
> +#include <fenv.h>
> +#include <fpu_control.h>
> +
> +int
> +fesetexcept (int excepts)
> +{
> +  fexcept_t temp, newexcepts;
> +
> +  _FPU_GETCW (temp);
> +  temp |= (excepts & FE_ALL_EXCEPT) << FPC_FLAGS_SHIFT;
> +  _FPU_SETCW (temp);
> +
> +  return 0;
> +}
>
Hi Joseph,

the macro FPC_FLAGS_SHIFT is defined in fenv_libc.h, which is not 
included. The variable newexcepts is unused.
See diff below.

Afterwards the new tests are succeeding on s390x / s390.

Thanks.
Stefan


--

Comments

Joseph Myers Aug. 15, 2016, 8:52 p.m. UTC | #1 
On Mon, 15 Aug 2016, Stefan Liebler wrote:

> Hi Joseph,
> 
> the macro FPC_FLAGS_SHIFT is defined in fenv_libc.h, which is not included.
> The variable newexcepts is unused.
> See diff below.

Thanks, I'll include this fix when I commit.
diff mbox

Patch

diff --git a/sysdeps/s390/fpu/fesetexcept.c b/sysdeps/s390/fpu/fesetexcept.c
index 4728f3e..e875f13 100644
--- a/sysdeps/s390/fpu/fesetexcept.c
+++ b/sysdeps/s390/fpu/fesetexcept.c
@@ -18,11 +18,12 @@ 

  #include <fenv.h>
  #include <fpu_control.h>
+#include <fenv_libc.h>

  int
  fesetexcept (int excepts)
  {
-  fexcept_t temp, newexcepts;
+  fexcept_t temp;

    _FPU_GETCW (temp);
    temp |= (excepts & FE_ALL_EXCEPT) << FPC_FLAGS_SHIFT;