From patchwork Thu May 5 13:58:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Szabolcs Nagy X-Patchwork-Id: 1626984 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=r1qFySyX; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvFg44j6bz9sBB for ; Thu, 5 May 2022 23:59:12 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2B09F3857367 for ; Thu, 5 May 2022 13:59:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2B09F3857367 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1651759148; bh=JIjTrK44Gam6VTs8bA/t8xPo0Y961MyRFETKyJ8KnWY=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=r1qFySyXhtLHa5Q6qPqF65OqUNk9gZEWV8IRv5KY56lS5Bc6/X6ovuhRZ24L8Je5r nPTdXCpVs+Gx39C16hxloaJdZcP/EBVanly/u9xOxZfI2VTOG5gzkCpOKxSmxESpI+ wv+V2eJb5yDUPgRxGnQR3SDLEUgyDbEyPC3ztVtY= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10049.outbound.protection.outlook.com [40.107.1.49]) by sourceware.org (Postfix) with ESMTPS id C50EA3858D3C for ; Thu, 5 May 2022 13:58:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C50EA3858D3C ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iO2/8X5iD4KB+++jqTV1brTxKasS7YMfxKDRNJ5Q9ZAcGOOhwEYoqE5SEMDe41b+Bv1XU07GQYsGz4yn/trCmKhvIjkYwD7vdP+VXN3UiPRctHWil0S6u4By/bslfLFxkPF2HT6BHYpOq6ccOZBP6SMJ163+W8BMCKcO6I2yjKYPlgBTS3uwHuRLsLrtX2l6IRdCEUqVohsZMz8WMX9ly94ru5z0AO/4/9196z0sDL5206GvCZE3pjumGIxaD2ouV7KoSnz/1KvpKoEiDoHkJf6ugejbxWurHoX8c+lIAa1L3bh/IcW5jvH0pNpzYc5moeetHWChaRgmux0nYEnLIg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JIjTrK44Gam6VTs8bA/t8xPo0Y961MyRFETKyJ8KnWY=; b=bPnq6KyQb6DJSdlFhUnvnkCofjQbDbmh2a/X/h6wX+yCY//Y3gPBrpeU/MWY2VZ/paVbNFLvpWbOzSSC0dRDSs7YURM59tCC2QW89WjC28KhWRtr+2aHzdHoRThZZjvA1mQWDhbIXptyGHi5sd4olFZDZWZpJx6SqK/CsrBqRmY2v2jkLdK3UyFkxWGyHn7Wn721a6uegfLxI/u0OFvvidC9dHD7SeEszJwjsDo+8uxDmXCUmumLGVXuBuTu910RoyfswM2o8d9h5ytoaN2kCHzwQmAHiwjUG+TNg6cseTPIPVk1yYmkV8q0dOiWc/t8u8VPeEWXFcvYkKP3JuaO6g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1, 1, smtp.mailfrom=arm.com] dmarc=[1, 1, header.from=arm.com]) Received: from DB7PR03CA0087.eurprd03.prod.outlook.com (2603:10a6:10:72::28) by AM6PR08MB3733.eurprd08.prod.outlook.com (2603:10a6:20b:89::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Thu, 5 May 2022 13:58:48 +0000 Received: from DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:72:cafe::1c) by DB7PR03CA0087.outlook.office365.com (2603:10a6:10:72::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27 via Frontend Transport; Thu, 5 May 2022 13:58:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT057.mail.protection.outlook.com (100.127.142.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Thu, 5 May 2022 13:58:47 +0000 Received: ("Tessian outbound 62985e3c34b6:v118"); Thu, 05 May 2022 13:58:47 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ae7ff809cde2c899 X-CR-MTA-TID: 64aa7808 Received: from 6c00948b4887.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 321543AC-5D8C-4771-8D2D-ECC4447C0F54.1; Thu, 05 May 2022 13:58:40 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6c00948b4887.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 05 May 2022 13:58:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gMTqeISxyx61p78KyfsAoyKhzVYNiZvMRaz3pi9N0ZGWENwE/9V0dcJHRFoWatkc2pIXn7mZSEAc+5MHHkil57O7c4YzjUA82FGKdrZzircx/AbQufMyZXxQWZMW0ANCVFanz9NS66jT5DKrqL2uc80qObVilgIFvY/hcvQCjGi3VWW748aCk4I6vzXu30K8oIiZVSwKL9RC2n6ZrVRS+DzDaActQt3fz/eqThSmv3NPqtqPFn2OC6TRMtvp3rAe3qUx7LG6bjPr1/JkeG0EUFNzYqLexSisdIX9f0qTkJus6ON1mPX3t3RQPbwap17rg1FI9GkSuGkTWLvPSUWX2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JIjTrK44Gam6VTs8bA/t8xPo0Y961MyRFETKyJ8KnWY=; b=BDWUPr/knPAFVjEs4Z8tT60fthfkvaNxJnePKfBQVg+3PrGpH0W8hXzj6BDnqsoNAUQ7DT1Q62fpvliYFdl9AGVzg+CTGpzND6QeCy8OTaOU2GGPdwNech1HsgjrhTole75vr7n6x3Na4OYlS+XJ9/x3FCc7IdtJMlegR1UQoS1e5Pp9LZhCqkHS2mgMv30joLHiAruEFChN/ZT54CRWL8blV9M+uGD/EUlxd7U+k10FtGKmXx3f67dvfKdjZrp5dn4QpX+NJfmbvhDpoIOlyaFTeuH1e3f6L1KdbaxeQ6T7F+rtmTwQ/7pUJtex8XuDZjhjcyHjTSdC/hN4YNv8Jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none Received: from AS9PR06CA0140.eurprd06.prod.outlook.com (2603:10a6:20b:467::26) by VE1PR08MB5854.eurprd08.prod.outlook.com (2603:10a6:800:1b0::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 5 May 2022 13:58:39 +0000 Received: from AM5EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:467:cafe::9d) by AS9PR06CA0140.outlook.office365.com (2603:10a6:20b:467::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Thu, 5 May 2022 13:58:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT052.mail.protection.outlook.com (10.152.17.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5227.15 via Frontend Transport; Thu, 5 May 2022 13:58:38 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 5 May 2022 13:58:41 +0000 Received: from armchair.cambridge.arm.com (10.2.80.71) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.27 via Frontend Transport; Thu, 5 May 2022 13:58:41 +0000 To: Subject: [PATCH v6 0/4] Args adjustment with ./ld.so exe [BZ #23293] Date: Thu, 5 May 2022 14:58:37 +0100 Message-ID: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: dc6c97d1-651f-40f5-e448-08da2e9f6076 X-MS-TrafficTypeDiagnostic: VE1PR08MB5854:EE_|DBAEUR03FT057:EE_|AM6PR08MB3733:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XP3JeiHIrpUgrfqt9rHfdMySe/JXreA1wzXLE5Ub1tcUmJkC98pjkFIcKLVs6XOqvRT/YgVcV8b0HKZv7zfY+5ym1C6NK9bIY0CbG4l2zwVusGlUwDpg1ebDKSCmrATNg10Vy2W2qMHSuyhDUxCKgKKTt/+MegneqElnyuJIN/CokffBmUOOY2WopcX5smldneMcWsMlcUmKno2fD0Ji35rYwfECDJ38gLqQ91UIPaXMo0dwj35Gtf8mOyWP1nqjEXBOUggecxvpoKGvwKRl0XyZdDElTt5O1o5YUEnt+gqGCSC3+ipYaRw77wHh5YsqOrbkPFXLPT5XwyMj3g3gP6B/RODmk78Ckl371UUBkVqtcWw9NbgeW/y4D+nGJo71OdxYJ77vZayHhtS6xbS2JWfZv6qBgae/ZRhwpd0SYhKnsKjPxbGTDmjjWHIpj8iGn7kmBPBHv2ie1///nDQfUK4bORajDTDuPLVQuDbnA4cBraje7uSD+9lQBJqCw8cKcYgoCdrPSd/gOnrB3EVr+GWA3fbEMzqTY15S1bn+NhW0c7hUXTf9/jF+CLoxBoVi6M6T5TR2zW/QS2KBi1oJU+G0WtoDICuYqm3U3dk5iCoTm0ipd7rBwVzbAGfMchom91jg9o1XL88c+HZFKY6ZiNiNteUb17xqAqmznmHEGcQBiF+u2NBtuyjgDyo7ItSWnWJA903xWryOteWLMxOQxQ== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(86362001)(8676002)(6666004)(70586007)(70206006)(508600001)(6916009)(316002)(186003)(426003)(336012)(47076005)(2616005)(26005)(356005)(7696005)(81166007)(40460700003)(83380400001)(82310400005)(36860700001)(8936002)(36756003)(44832011)(2906002)(5660300002)(36900700001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5854 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3bab290c-d392-4553-fbb3-08da2e9f5b06 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2yT/HhTi/lmxqj3QzHyZX+7Ib+r8quCEZ5L+0XcxZRBNsAuRExcfPH2M8zvasOMeGN0LaVd+an3Bs2QPsk69Xwgj3ox6jlmUCLpundWCfU3uus8GwfQkGjGxGotnFy8mrvkE4exHuXtuqmgTd6CE0QRaZVTuegFXUrKuuBBMpQl0sqZYMoo3ug/gg31tm2auIqEi+9nqtqe/MQNQ9Hy8ykNR9fn2kGHrbhK4zT+PQ2laxnRUcjugFGyK+YTycSAFQHmaj14IN8EamLt0v2SzSDpgl0cKkY5F04v4Q4hCDVD+bDe0gTUss7cTYoh35SEN4O585IyLJQOP5wbTNQOckSaKu4GzdSBVppkr84z5j1r2YaZ+jBmTa9KESffwKhMTNM0V1iCH0WYo1TDF8/j84G/dW/dkE6ZmSpbkqxbF9Y1QYmsnnJ5GIYOF4/A9hWyVnn822E6+8rCOAicFyymsw/ApqwBbOR1KZycIYr0Faf51nfpm2obrbSb2nj2jqsB1yWlwDfXnAgxfokusTcsFAvVLv3yErviK5U5QeOf5aw9tzJfDpwfmceP8kxuV22yRQWTXSFWZ1CNNGqmQynsyREatrPY4WX9a5jNxsGPLO9E1c8yWa/cw1niC30koL7SJSbPoLuQDTP1C4MZ+VbJIWHVPMrGZTw2WV0+frSS5qJQOUTU0OnLN461PgxQQX9cX X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(336012)(2616005)(186003)(26005)(6666004)(7696005)(426003)(47076005)(81166007)(86362001)(40460700003)(36860700001)(44832011)(82310400005)(83380400001)(5660300002)(508600001)(6916009)(316002)(70206006)(70586007)(8676002)(8936002)(36756003)(2906002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 13:58:47.9428 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dc6c97d1-651f-40f5-e448-08da2e9f6076 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3733 X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Szabolcs Nagy via Libc-alpha From: Szabolcs Nagy Reply-To: Szabolcs Nagy Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org Sender: "Libc-alpha" The Hurd ld.so start code had to be adjusted. This revealed that the fix actually cuts across abstraction layers: fiddles with ELF entry stack layout in generic code, skipping the intermediate OS sysdep layer. If the OS layer ever wants to do something more complicated with the args then the interface contract with dl_main will have to be reevaluated. I ran cross tests for i686-gnu, but not execution tests, so the changes in sysdeps/mach/hurd/dl-sysdep.c require a review. The patches are in the nsz/bug23293-v6 branch. Szabolcs Nagy (4): rtld: Use generic argv adjustment in ld.so [BZ #23293] rtld: Remove DL_ARGV_NOT_RELRO and make _dl_skip_args const linux: Add a getauxval test [BZ #23293] aarch64: Move ld.so _start to separate file and drop _dl_skip_args elf/rtld.c | 83 ++++++++++++++++++------ sysdeps/aarch64/Makefile | 1 + sysdeps/aarch64/dl-machine.h | 77 +--------------------- sysdeps/aarch64/dl-start.S | 53 +++++++++++++++ sysdeps/aarch64/dl-sysdep.h | 4 -- sysdeps/alpha/dl-sysdep.h | 23 ------- sysdeps/arc/dl-sysdep.h | 4 -- sysdeps/arm/dl-sysdep.h | 4 -- sysdeps/csky/dl-sysdep.h | 23 ------- sysdeps/generic/ldsodefs.h | 13 +--- sysdeps/ia64/dl-sysdep.h | 23 ------- sysdeps/mach/hurd/dl-sysdep.c | 30 ++++----- sysdeps/nios2/dl-sysdep.h | 4 -- sysdeps/s390/s390-32/dl-sysdep.h | 23 ------- sysdeps/sparc/dl-sysdep.h | 23 ------- sysdeps/unix/sysv/linux/Makefile | 1 + sysdeps/unix/sysv/linux/ia64/dl-sysdep.h | 4 -- sysdeps/unix/sysv/linux/tst-getauxval.c | 74 +++++++++++++++++++++ 18 files changed, 209 insertions(+), 258 deletions(-) create mode 100644 sysdeps/aarch64/dl-start.S delete mode 100644 sysdeps/alpha/dl-sysdep.h delete mode 100644 sysdeps/csky/dl-sysdep.h delete mode 100644 sysdeps/ia64/dl-sysdep.h delete mode 100644 sysdeps/s390/s390-32/dl-sysdep.h delete mode 100644 sysdeps/sparc/dl-sysdep.h create mode 100644 sysdeps/unix/sysv/linux/tst-getauxval.c