From patchwork Thu Mar 19 14:41:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: develop--- via Libc-alpha X-Patchwork-Id: 1258263 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=libc-alpha-bounces@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=sourceware.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=Pv28bwKr; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48jqNd38BNz9sW6 for ; Fri, 20 Mar 2020 01:41:37 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D44F7387702B; Thu, 19 Mar 2020 14:41:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D44F7387702B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1584628892; bh=5RIl1INzrN6+eulb9nlm4JdHtlydiFOgmg9kYCWKMYM=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=Pv28bwKr6QJQ2IY+34hUgEMF0k6jfYUugU0z65obMf+OfZyxlXpE4JZtlAIChlTfi 7OKKHSP7riNgVvnAInClHFobQQEy/B+Rs3syIMwXW/37DuwdY6tl5S9EdOzf54f65u FAF7JNcQIdT9kWioazE5uD7LCFAJWJRlapllNcV0= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by sourceware.org (Postfix) with ESMTPS id 63653385F020 for ; Thu, 19 Mar 2020 14:41:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 63653385F020 Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 91A20278816; Thu, 19 Mar 2020 10:41:29 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 4Q3RSPRC-uJ7; Thu, 19 Mar 2020 10:41:29 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 33645278713; Thu, 19 Mar 2020 10:41:29 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 33645278713 X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id OS_1CyTBerpg; Thu, 19 Mar 2020 10:41:29 -0400 (EDT) Received: from localhost.localdomain (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) by mail.efficios.com (Postfix) with ESMTPSA id EEF16278814; Thu, 19 Mar 2020 10:41:28 -0400 (EDT) To: Carlos O'Donell Subject: [RFC PATCH glibc 0/8] Restartable Sequences enablement Date: Thu, 19 Mar 2020 10:41:02 -0400 Message-Id: <20200319144110.3733-1-mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_3, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Mathieu Desnoyers via Libc-alpha From: develop--- via Libc-alpha Reply-To: Mathieu Desnoyers Cc: libc-alpha@sourceware.org, Joseph Myers , Mathieu Desnoyers Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" Hi, Please find the rseq-enablement patchset for comments in this series. This patch series is based on glibc master branch at commit 1fabdb9908 x86: Remove ARCH_CET_LEGACY_BITMAP [BZ #25397] Since the last post, I updated the copyright dates, and moved from using the __NR_rseq preprocessor macro to introduce __ASSUME_RSEQ, which is defined when configuring with --enable-kernel=4.18.0 (or more recent). This change was required now that glibc source tree contains the Linux system call number definitions. Florian Weimer helped a lot so far by providing great feedback and posting a set of 3 patches implementing glibc modifications needed by rseq. Those are the first 3 patches of this patchset. It would be appreciated if others can help out by focusing their review effort specifically on those 3 patches from Florian. Thanks for the feedback! Mathieu Florian Weimer (3): Introduce Implement __libc_early_init nptl: Start new threads with all signals blocked [BZ #25098] Mathieu Desnoyers (5): glibc: Perform rseq(2) registration at C startup and thread creation (v15) glibc: sched_getcpu(): use rseq cpu_id TLS on Linux (v6) support record failure: allow use from constructor support: implement xpthread key create/delete (v4) rseq registration tests (v8) NEWS | 10 + csu/init-first.c | 4 - csu/libc-start.c | 5 + elf/Makefile | 5 +- elf/Versions | 1 + elf/dl-call-libc-early-init.c | 41 ++ elf/dl-load.c | 9 + elf/dl-lookup-direct.c | 116 ++++++ elf/dl-lookup.c | 10 +- elf/dl-open.c | 24 ++ elf/elf_machine_sym_no_match.h | 34 ++ elf/libc-early-init.h | 35 ++ elf/libc_early_init.c | 30 ++ elf/rtld.c | 4 + manual/threads.texi | 30 +- misc/rseq-internal.h | 33 ++ nptl/descr.h | 10 +- nptl/pthread_create.c | 56 ++- support/Makefile | 2 + support/check.h | 4 + support/support_record_failure.c | 18 +- support/xpthread_key_create.c | 25 ++ support/xpthread_key_delete.c | 24 ++ support/xthread.h | 2 + sysdeps/generic/ldsodefs.h | 17 + sysdeps/mach/hurd/i386/init-first.c | 4 - sysdeps/mips/dl-machine.h | 15 - sysdeps/mips/elf_machine_sym_no_match.h | 43 +++ sysdeps/unix/sysv/linux/Makefile | 11 +- sysdeps/unix/sysv/linux/Versions | 3 + sysdeps/unix/sysv/linux/aarch64/bits/rseq.h | 43 +++ sysdeps/unix/sysv/linux/aarch64/libc.abilist | 1 + sysdeps/unix/sysv/linux/alpha/libc.abilist | 1 + sysdeps/unix/sysv/linux/arm/be/libc.abilist | 1 + sysdeps/unix/sysv/linux/arm/bits/rseq.h | 83 ++++ sysdeps/unix/sysv/linux/arm/le/libc.abilist | 1 + sysdeps/unix/sysv/linux/bits/rseq.h | 29 ++ sysdeps/unix/sysv/linux/csky/libc.abilist | 1 + sysdeps/unix/sysv/linux/hppa/libc.abilist | 1 + sysdeps/unix/sysv/linux/i386/libc.abilist | 1 + sysdeps/unix/sysv/linux/ia64/libc.abilist | 1 + sysdeps/unix/sysv/linux/kernel-features.h | 5 + .../sysv/linux/m68k/coldfire/libc.abilist | 1 + .../unix/sysv/linux/m68k/m680x0/libc.abilist | 1 + .../sysv/linux/microblaze/be/libc.abilist | 1 + .../sysv/linux/microblaze/le/libc.abilist | 1 + sysdeps/unix/sysv/linux/mips/bits/rseq.h | 62 +++ .../sysv/linux/mips/mips32/fpu/libc.abilist | 1 + .../sysv/linux/mips/mips32/nofpu/libc.abilist | 1 + .../sysv/linux/mips/mips64/n32/libc.abilist | 1 + .../sysv/linux/mips/mips64/n64/libc.abilist | 1 + sysdeps/unix/sysv/linux/nios2/libc.abilist | 1 + sysdeps/unix/sysv/linux/powerpc/bits/rseq.h | 37 ++ .../linux/powerpc/powerpc32/fpu/libc.abilist | 1 + .../powerpc/powerpc32/nofpu/libc.abilist | 1 + .../linux/powerpc/powerpc64/be/libc.abilist | 1 + .../linux/powerpc/powerpc64/le/libc.abilist | 1 + .../unix/sysv/linux/riscv/rv64/libc.abilist | 1 + sysdeps/unix/sysv/linux/rseq-internal.h | 76 ++++ sysdeps/unix/sysv/linux/rseq-sym.c | 44 +++ sysdeps/unix/sysv/linux/s390/bits/rseq.h | 37 ++ .../unix/sysv/linux/s390/s390-32/libc.abilist | 1 + .../unix/sysv/linux/s390/s390-64/libc.abilist | 1 + sysdeps/unix/sysv/linux/sched_getcpu.c | 30 +- sysdeps/unix/sysv/linux/sh/be/libc.abilist | 1 + sysdeps/unix/sysv/linux/sh/le/libc.abilist | 1 + .../sysv/linux/sparc/sparc32/libc.abilist | 1 + .../sysv/linux/sparc/sparc64/libc.abilist | 1 + sysdeps/unix/sysv/linux/sys/rseq.h | 30 ++ sysdeps/unix/sysv/linux/tst-rseq-nptl.c | 354 ++++++++++++++++++ sysdeps/unix/sysv/linux/tst-rseq.c | 115 ++++++ sysdeps/unix/sysv/linux/x86/bits/rseq.h | 30 ++ .../unix/sysv/linux/x86_64/64/libc.abilist | 1 + .../unix/sysv/linux/x86_64/x32/libc.abilist | 1 + 74 files changed, 1561 insertions(+), 69 deletions(-) create mode 100644 elf/dl-call-libc-early-init.c create mode 100644 elf/dl-lookup-direct.c create mode 100644 elf/elf_machine_sym_no_match.h create mode 100644 elf/libc-early-init.h create mode 100644 elf/libc_early_init.c create mode 100644 misc/rseq-internal.h create mode 100644 support/xpthread_key_create.c create mode 100644 support/xpthread_key_delete.c create mode 100644 sysdeps/mips/elf_machine_sym_no_match.h create mode 100644 sysdeps/unix/sysv/linux/aarch64/bits/rseq.h create mode 100644 sysdeps/unix/sysv/linux/arm/bits/rseq.h create mode 100644 sysdeps/unix/sysv/linux/bits/rseq.h create mode 100644 sysdeps/unix/sysv/linux/mips/bits/rseq.h create mode 100644 sysdeps/unix/sysv/linux/powerpc/bits/rseq.h create mode 100644 sysdeps/unix/sysv/linux/rseq-internal.h create mode 100644 sysdeps/unix/sysv/linux/rseq-sym.c create mode 100644 sysdeps/unix/sysv/linux/s390/bits/rseq.h create mode 100644 sysdeps/unix/sysv/linux/sys/rseq.h create mode 100644 sysdeps/unix/sysv/linux/tst-rseq-nptl.c create mode 100644 sysdeps/unix/sysv/linux/tst-rseq.c create mode 100644 sysdeps/unix/sysv/linux/x86/bits/rseq.h