From patchwork Fri Jul 2 11:46:14 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 57652 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id C8FB9B70A0 for ; Fri, 2 Jul 2010 21:46:26 +1000 (EST) Received: (qmail 20165 invoked by alias); 2 Jul 2010 11:46:24 -0000 Received: (qmail 20152 invoked by uid 22791); 2 Jul 2010 11:46:23 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL, BAYES_00, KAM_STOCKGEN, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Jul 2010 11:46:19 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id E3CA94C3; Fri, 2 Jul 2010 13:46:16 +0200 (CEST) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id hVyUa9rdt56M; Fri, 2 Jul 2010 13:46:14 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id D83854C2; Fri, 2 Jul 2010 13:46:14 +0200 (CEST) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.3+Sun/8.14.3/Submit) id o62BkEZj024256; Fri, 2 Jul 2010 13:46:14 +0200 (MEST) From: Rainer Orth To: Paolo Carlini Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, Paolo Bonzini , Jonathan Wakely Subject: Re: [build, doc, v3] Support Sun symbol versioning in libstdc++-v3, rev. 2 References: <4C2C61C1.5030600@oracle.com> <4C2DC0A1.3060007@oracle.com> <4C2DC174.8000800@oracle.com> Date: Fri, 02 Jul 2010 13:46:14 +0200 In-Reply-To: <4C2DC174.8000800@oracle.com> (Paolo Carlini's message of "Fri, 02 Jul 2010 12:37:40 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Paolo Carlini writes: >> Rainer, are you *sure* that HAVE_SYMVER_SYMBOL_RENAMING_RUNTIME_SUPPORT >> is actually defined somewhere on, eg, linux, for use in gnu.ver etc? >> Because I did a quick build on x86_64-linux and inside the libstdc++-v3 >> build dir I only see >> _GLIBCXX_HAVE_SYMVER_SYMBOL_RENAMING_RUNTIME_SUPPORT defined, in >> config.h + _GLIBCXX__GLIBCXX_HAVE_SYMVER_SYMBOL_RENAMING_RUNTIME_SUPPORT >> in c++config.h. Something seems fishy... >> > And abi_check fails. Something is badly wrong on linux. Of course always > test on linux too when testing this kind of change!!!! Please fix > quickly or revert, thanks. I think I see now what's going on. The following patch should fix it: * There was a syntax error in acinclude.m4: a missing ;; in the default case. * I AC_DEFINE'd the _GLIBCXX_-prefixed symbol in acinclude.m4, while the files under src include c++config.h which adds another level of prefixing. Could you please test this for me? I don't have ready access to GNU/Linux. Sorry for the mess. Rainer diff -r 08cc828c8afb libstdc++-v3/acinclude.m4 --- a/libstdc++-v3/acinclude.m4 Mon Jun 28 16:33:40 2010 +0200 +++ b/libstdc++-v3/acinclude.m4 Fri Jul 02 13:43:56 2010 +0200 @@ -2998,9 +2998,9 @@ symvers_renaming=no ;; # Other platforms with GNU symbol versioning (GNU/Linux, more?) do. *) - AC_DEFINE(_GLIBCXX_HAVE_SYMVER_SYMBOL_RENAMING_RUNTIME_SUPPORT, 1, + AC_DEFINE(HAVE_SYMVER_SYMBOL_RENAMING_RUNTIME_SUPPORT, 1, [Define to 1 if the target runtime linker supports binding the same symbol to different versions.]) - symvers_renaming=yes + symvers_renaming=yes ;; esac fi GLIBCXX_CONDITIONAL(ENABLE_SYMVERS_SOL2, test $symvers_renaming = no)