From patchwork Tue Feb 4 09:55:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 316512 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 8F53F2C0090 for ; Tue, 4 Feb 2014 20:55:29 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; q=dns; s=default; b=bY5ICtASCFKUxpCP QJs/3yBDTh25Dho9UW7ZngpLCh5zUbANSIhruAhkOvc9CRoKa35i+z5uKrvXPPCQ SEUwQ2IUHpSWmI/q62uNMXfuqK6/hyXBDV4dm6dkZ2hbNAyYp/J5jDEPg/Ej7pYA RmpOQ4+SF9fqJoJPsrsJCFAQRwQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; s=default; bh=XvG10fofaVyQPuJOHBkide DyENE=; b=nbzMgLCPxIlEiWVaKkXmPS3i2I5pZi6YZsZAu1Q7yOusfEZaN1tI00 uhCoVZ0GlMTQzSMism8xG0IDyZOFzaRFt3DodmzPPJLEBRuw7iSUc/8lk2jAXnby vpVONgTGVnYFKnIo3Niv5nORUYstUQ4GdROvJyZ5d8Z5S89Xk53jQ= Received: (qmail 23930 invoked by alias); 4 Feb 2014 09:55:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 23903 invoked by uid 89); 4 Feb 2014 09:55:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp-relay.CeBiTec.Uni-Bielefeld.DE Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Feb 2014 09:55:20 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id A1F8AA46; Tue, 4 Feb 2014 10:55:17 +0100 (CET) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id CyqR4VeZtbMk; Tue, 4 Feb 2014 10:55:16 +0100 (CET) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.110]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id CD16BA45; Tue, 4 Feb 2014 10:55:15 +0100 (CET) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.14.5+Sun/8.14.5/Submit) id s149tFoq008202; Tue, 4 Feb 2014 10:55:15 +0100 (MET) From: Rainer Orth To: Paolo Carlini Cc: "gcc-patches\@gcc.gnu.org" , Jason Merrill Subject: Re: [C++ Patch] PR 58846 References: <52E91B33.8040703@oracle.com> Date: Tue, 04 Feb 2014 10:55:15 +0100 In-Reply-To: <52E91B33.8040703@oracle.com> (Paolo Carlini's message of "Wed, 29 Jan 2014 16:16:03 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Paolo Carlini writes: > a very minor ICE on invalid regression, but since we explicitly allow for > redeclarations (also see comments in declare_global_var) we may as well > avoid crashing, at least in mainline. Tested x86_64-linux. The test FAILs on Solaris which doesn't have __cxa_atexit: FAIL: g++.dg/init/dso_handle2.C -std=c++98 (test for errors, line 10) FAIL: g++.dg/init/dso_handle2.C -std=c++11 (test for errors, line 10) Fixed like dso_handle1.C does by forcing -fuse-cxa-atexit. Tested with the appropriate runtest invocations on i386-pc-solaris2.11 and x86_64-unknown-linux-gnu. Ok for mainline? Rainer 2014-02-04 Rainer Orth * g++.dg/init/dso_handle2.C: Compile with -fuse-cxa-atexit. # HG changeset patch # Parent 944218077f384619dcc391f55c51e5ba477dd022 Fix g++.dg/init/dso_handle2.C on Solaris gcc/testsuite: * g++.dg/init/dso_handle2.C: Compile with -fuse-cxa-atexit. diff --git a/gcc/testsuite/g++.dg/init/dso_handle2.C b/gcc/testsuite/g++.dg/init/dso_handle2.C --- a/gcc/testsuite/g++.dg/init/dso_handle2.C +++ b/gcc/testsuite/g++.dg/init/dso_handle2.C @@ -1,4 +1,5 @@ // PR c++/58846 +// { dg-options "-fuse-cxa-atexit" } extern "C" { char* __dso_handle; }