diff mbox

[testsuite] Fix gcc.dg/tls/pr58595.c on Solaris 9

Message ID yddlhw6o0h0.fsf@lokon.CeBiTec.Uni-Bielefeld.DE
State New
Headers show

Commit Message

Rainer Orth March 19, 2014, 12:07 p.m. UTC 
Jakub Jelinek <jakub@redhat.com> writes:

> On Tue, Mar 18, 2014 at 11:19:52AM +0100, Rainer Orth wrote:
>> The new gcc.dg/tls/pr58595.c testcase FAILs on Solaris 9:
>> 
>> FAIL: gcc.dg/tls/pr58595.c (test for excess errors)
>> Excess errors:
>> Undefined                       first referenced
>>  symbol                             in file
>> ___tls_get_addr                     /var/tmp//ccuBbAna.o
>> ld: fatal: Symbol referencing errors. No output written to ./pr58595.exe
>> WARNING: gcc.dg/tls/pr58595.c compilation failed to produce executable
>> 
>> Fixed as follows, tested with the appropriate runtest invocation on
>> i386-pc-solaris2.9, i386-pc-solaris2.11, and x86_64-unknown-linux-gnu,
>> installed on mainline.
>
> Can you please also change
> /* { dg-require-effective-target tls } */
> to
> /* { dg-require-effective-target tls_runtime } */
> ?

Sure, done as follows after retesting as before:

2014-03-19  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* gcc.dg/tls/pr58595.c: Require tls_runtime instead of tls.
> BTW, don't know if dg-add-options tls can come before that or not.

It can: the tls_runtime check takes care of adding the options itself.

	Rainer
diff mbox

Patch

changeset:   13384:d1c2de35507e
tag:         tip
user:        Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
date:        Wed Mar 19 13:04:36 2014 +0100
summary:     Require tls_runtime in gcc.dg/tls/pr58595.c

diff --git a/gcc/testsuite/gcc.dg/tls/pr58595.c b/gcc/testsuite/gcc.dg/tls/pr58595.c
--- a/gcc/testsuite/gcc.dg/tls/pr58595.c
+++ b/gcc/testsuite/gcc.dg/tls/pr58595.c
@@ -3,7 +3,7 @@ 
 /* { dg-options "-O2" } */
 /* { dg-additional-options "-fpic" { target fpic } } */
 /* { dg-add-options tls } */
-/* { dg-require-effective-target tls } */
+/* { dg-require-effective-target tls_runtime } */
 /* { dg-require-effective-target sync_int_long } */
 
 struct S { unsigned long a, b; };