From patchwork Mon Jul 18 10:22:01 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 105244 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 52BDCB6FD1 for ; Mon, 18 Jul 2011 20:22:21 +1000 (EST) Received: (qmail 28497 invoked by alias); 18 Jul 2011 10:22:19 -0000 Received: (qmail 28488 invoked by uid 22791); 18 Jul 2011 10:22:18 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 18 Jul 2011 10:22:05 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 9C945306; Mon, 18 Jul 2011 12:22:03 +0200 (CEST) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id nyjAO6QsK8R5; Mon, 18 Jul 2011 12:22:02 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 0545A305; Mon, 18 Jul 2011 12:22:02 +0200 (CEST) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.4+Sun/8.14.4/Submit) id p6IAM1V1011321; Mon, 18 Jul 2011 12:22:01 +0200 (MEST) From: Rainer Orth To: Jakub Jelinek Cc: Andrew Pinski , GCC Patches , Richard Guenther Subject: Re: [PATCH] Move pr49309.C testcase to libmudflap (PR testsuite/49753) References: <20110715195627.GO2687@tyan-ft48-01.lab.bos.redhat.com> Date: Mon, 18 Jul 2011 12:22:01 +0200 In-Reply-To: <20110715195627.GO2687@tyan-ft48-01.lab.bos.redhat.com> (Jakub Jelinek's message of "Fri, 15 Jul 2011 21:56:27 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Jakub Jelinek writes: > On Wed, Jul 13, 2011 at 01:37:22PM -0700, Andrew Pinski wrote: >> Hi, >> The problem here is that the type of the POINTER_PLUS_EXPR is >> incorrect and also the non folded version leaks to the IR. This patch >> fixes those two problems and fixes the ICE. >> >> OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. > > The testcase is wrongly placed and thus fails everywhere. -fmudflap > causes inclusion of headers and gcc/testsuite/ isn't set up to find them. There's a far simpler fix, inspired by gcc.dg/dfp/pr35739.c. I think it is better since it gives the testcase wider coverage. Tested with the appropriate runtest invocation on i386-pc-solaris2.11 and alpha-dec-osf5.1b. Will install on mainline and 4.6 branch unless someone objects. Rainer 2011-07-18 Rainer Orth * g++.dg/torture/pr49309.C: Add -fpreprocessed to dg-options. diff --git a/gcc/testsuite/g++.dg/torture/pr49309.C b/gcc/testsuite/g++.dg/torture/pr49309.C --- a/gcc/testsuite/g++.dg/torture/pr49309.C +++ b/gcc/testsuite/g++.dg/torture/pr49309.C @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { dg-options "-fmudflap" } */ +/* { dg-options "-fpreprocessed -fmudflap" } */ struct A { int i;