From patchwork Wed Nov 26 13:32:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 415121 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 81BF014017B for ; Thu, 27 Nov 2014 00:33:05 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type; q=dns; s= default; b=asf0qH1MDJwPt0XE5o3WBE/84Xt5aBIQGBvKx8C/oCDpDbYGnfrhP 6Gwmk/QQOKfnvWD1dJOwVc8v30GB9YhL/5j2aCYwJhW+4fuR/LX/kJ73SWE6hI5g C9RL9cZUVIMvX+yvnzUq/ZDqA27WewJBZcVDXg2C2z4d1Le6fK6RYE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type; s= default; bh=pcR4kbUkKtOQiVbY5XWSjaE3VFM=; b=AjHXMGVnmwGiJ5zFAN9B sMJIwEHNEV4xuHikPJuHl5uIV6NtuKrJDSVjnKQJ1bQFq6G0+V5EWIRXSqt4QSuV glRHZ9GaeeRqZjummOpZe78Gdjn+7jYA+6ErNmLR6PvwZl9/jBBEm6TsdjRznnoP Apm8aBxk/+jgfwaHqvdb2L4= Received: (qmail 24363 invoked by alias); 26 Nov 2014 13:32:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 24348 invoked by uid 89); 26 Nov 2014 13:32:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp-relay.CeBiTec.Uni-Bielefeld.DE Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Nov 2014 13:32:54 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 8A7CDE99 for ; Wed, 26 Nov 2014 14:32:52 +0100 (CET) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id XYJY3sceV2lC for ; Wed, 26 Nov 2014 14:32:50 +0100 (CET) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.110]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 14875E98 for ; Wed, 26 Nov 2014 14:32:50 +0100 (CET) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.14.7+Sun/8.14.7/Submit) id sAQDWn9V006887; Wed, 26 Nov 2014 14:32:49 +0100 (CET) From: Rainer Orth To: gcc-patches@gcc.gnu.org Subject: [testsuite, i386] XFAIL gcc.target/i386/mcount_pic.c etc. on Solaris Date: Wed, 26 Nov 2014 14:32:49 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Two tests scanning for get_pc_thunk were FAILing on Solaris/x86: FAIL: gcc.target/i386/mcount_pic.c (test for excess errors) WARNING: gcc.target/i386/mcount_pic.c compilation failed to produce executable FAIL: gcc.target/i386/mcount_pic.c scan-assembler get_pc_thunk FAIL: gcc.target/i386/pr63620.c scan-assembler get_pc_thunk The first one initially failed due to the use of -p: on Solaris, this requires mcrt1.o, which is only distributed with the Studio compilers, while gcrt1.o (for -pg) is included either with the OS or comes from libgcc. On Linux/x86, both -p and -pg work, so I've changed the test to use the latter. After that, the scans for get_pc_thunk FAILed, explained by this comment in i386/sol2.h: /* Only recent versions of Solaris 11 ld properly support hidden .gnu.linkonce sections, so don't use them. */ #ifndef USE_GLD #define USE_HIDDEN_LINKONCE 0 #endif The following patch fixes those issues by compiling with -pg and XFAILing the scan-assembler tests on Solaris/x86 without gld. Tested with the appropriate runtest invocations on i386-pc-solaris2.11 (with and without gld), and x86_64-unknown-linux-gnu (both 32 and 64-bit multilibs). Installed on mainline. Rainer 2014-11-07 Rainer Orth * gcc.target/i386/pr63620.c: XFAIL get_pc_thunk scan on *-*-solaris* && !gld. * gcc.target/i386/mcount_pic.c: Likewise. Use -pg. # HG changeset patch # Parent aeefb237cf7036cddb5dea755c6cfd987e7c8a0f Skip gcc.target/i386/mcount_pic.c on Solaris diff --git a/gcc/testsuite/gcc.target/i386/mcount_pic.c b/gcc/testsuite/gcc.target/i386/mcount_pic.c --- a/gcc/testsuite/gcc.target/i386/mcount_pic.c +++ b/gcc/testsuite/gcc.target/i386/mcount_pic.c @@ -3,7 +3,7 @@ /* { dg-do run } */ /* { dg-require-effective-target fpic } */ /* { dg-require-effective-target ia32 } */ -/* { dg-options "-O2 -fpic -p -save-temps" } */ +/* { dg-options "-O2 -fpic -pg -save-temps" } */ int main () { @@ -11,5 +11,5 @@ int main () } /* { dg-final { scan-assembler "mcount" } } */ -/* { dg-final { scan-assembler "get_pc_thunk" } } */ +/* { dg-final { scan-assembler "get_pc_thunk" { xfail { *-*-solaris* && { ! gld } } } } } */ /* { dg-final { cleanup-saved-temps } } */ diff --git a/gcc/testsuite/gcc.target/i386/pr63620.c b/gcc/testsuite/gcc.target/i386/pr63620.c --- a/gcc/testsuite/gcc.target/i386/pr63620.c +++ b/gcc/testsuite/gcc.target/i386/pr63620.c @@ -17,4 +17,4 @@ test (__float128 x, int p, func f) return x; } -/* { dg-final { scan-assembler "get_pc_thunk" } } */ +/* { dg-final { scan-assembler "get_pc_thunk" { xfail { *-*-solaris* && { ! gld } } } } } */