From patchwork Thu Mar 6 11:55:27 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 327397 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 2EF382C0314 for ; Thu, 6 Mar 2014 22:55:42 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:mime-version:content-type; q=dns; s=default; b=Y0Ik728BXkSLONvbCpvtU2G/LzlHESl0eBfR4QwNX2TI/V0ff/ 1Osa8fYMyvxxzVAmaANaopLsxyywT/ZDOs73Gur6IieBG5tvw4YSLFl2/M0Zb6wj y80+dmRyzaoVXzncKL08sl58ccHA9cUZfD6THJ+rzNCrOMfbqDjf5Ufr0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:mime-version:content-type; s= default; bh=hLJnAUGs1Is0H1CofZP9p48dyEE=; b=Y/PDFC7Bi5lkfrvAy8u9 Cs8wzQ41FOyhbKcPsFor4so9z9BCtEugQZYAr8TZuEizXTlfI4qb4oYfPUOmIIl3 wEOOGcbwpDkYv/l582DIG9rakwN4fY+Jq91x2XVlGkvJOzirqK7H8rU8F5wx6/y1 nM/BqBNsubcZbU7DtRwAMEY= Received: (qmail 15014 invoked by alias); 6 Mar 2014 11:55:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 14996 invoked by uid 89); 6 Mar 2014 11:55:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp-relay.CeBiTec.Uni-Bielefeld.DE Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Mar 2014 11:55:31 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 68ACF2B2; Thu, 6 Mar 2014 12:55:29 +0100 (CET) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8JMlsoKizsRO; Thu, 6 Mar 2014 12:55:27 +0100 (CET) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.110]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 8F6922B1; Thu, 6 Mar 2014 12:55:27 +0100 (CET) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.14.7+Sun/8.14.7/Submit) id s26BtRHt012583; Thu, 6 Mar 2014 12:55:27 +0100 (MET) From: Rainer Orth To: gcc-patches@gcc.gnu.org Cc: Paolo Bonzini , Ian Lance Taylor Subject: [build, libgcc] Don't install vtv_*.o unless --enable-vtable-verify (PR libgcc/59339) Date: Thu, 06 Mar 2014 12:55:27 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Uros pointed me at PR libgcc/59339 where make install tries to install the vtv_*.o files even if they aren't built, leading to install warnings. The following patch fixes this by ensuring that the files are only installed if built. Tested with make install in libgcc on x86-64-unknown-linux-gnu --enable-vtable-verify (files are installed) and i686-unknown-linux-gnu (no installation attempted). Ok for mainline? Rainer 2014-03-06 Rainer Orth PR libgcc/59339 * config.host (*-*-linux*, frv-*-*linux*, *-*-kfreebsd*-gnu) (*-*-knetbsd*-gnu, *-*-gnu*, *-*-kopensolaris*-gnu): Only add vtv_*.o to extra_parts if enable_vtable_verify. # HG changeset patch # Parent 4abfa544576aa354871a00d4ce08585ae72e8bce Don't install vtv_*.o unless --enable-vtable-verify (PR libgcc/59339) diff --git a/libgcc/config.host b/libgcc/config.host --- a/libgcc/config.host +++ b/libgcc/config.host @@ -228,7 +228,10 @@ case ${host} in ;; *-*-linux* | frv-*-*linux* | *-*-kfreebsd*-gnu | *-*-knetbsd*-gnu | *-*-gnu* | *-*-kopensolaris*-gnu) tmake_file="$tmake_file t-crtstuff-pic t-libgcc-pic t-eh-dw2-dip t-slibgcc t-slibgcc-gld t-slibgcc-elf-ver t-linux" - extra_parts="crtbegin.o crtbeginS.o crtbeginT.o crtend.o crtendS.o vtv_start.o vtv_end.o vtv_start_preinit.o vtv_end_preinit.o" + extra_parts="crtbegin.o crtbeginS.o crtbeginT.o crtend.o crtendS.o" + if test x$enable_vtable_verify = xyes; then + extra_parts="$extra_parts vtv_start.o vtv_end.o vtv_start_preinit.o vtv_end_preinit.o" + fi ;; *-*-lynxos*) tmake_file="$tmake_file t-lynx $cpu_type/t-crtstuff t-crtstuff-pic t-libgcc-pic"