From patchwork Wed Mar 9 11:53:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 594999 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 665DD14032B for ; Wed, 9 Mar 2016 22:53:29 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=uLqkLfbM; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; q=dns; s=default; b=DzbOE+1AUwNu9yCH zo4E0Y9wcjfvT7wUrY533+6PJzYtOgDK2F9gG16kYmjNUhvqF1lA1MVk5GyS8KQT UhcOaWI4amgLhUf4gZPyX66OQY5UJxVQ6rKhSQ+JnFVKrSY3+UJiYIdshsBciHmI ec4mLijk/YrDjNjvw5DIvKDPMjg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; s=default; bh=GRe/EABFJcPNDcSrw+gIMS xKAG0=; b=uLqkLfbMGsheB/1HjaLSN5yErpDKxVOr5/6mIpyp7IgzyvUtjJ++rT k+ds2UPKtuInPPK9ea0snX96YTNHOwBIxSOKzfHrw1fxXIiVj8WpbPHXawQj8gGM kba8L059yig8LQbc2h/Pz7pYz3W4PVRZgy2MMDZQwd6Q82N/iBCMU= Received: (qmail 100338 invoked by alias); 9 Mar 2016 11:53:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 100324 invoked by uid 89); 9 Mar 2016 11:53:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.5 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Really, permutation, H*MI:Uni, ints X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Mar 2016 11:53:08 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id DD8F8757; Wed, 9 Mar 2016 12:53:05 +0100 (CET) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id kUNkvzhL9u2d; Wed, 9 Mar 2016 12:53:03 +0100 (CET) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.110]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id C5704756; Wed, 9 Mar 2016 12:53:03 +0100 (CET) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.15.2+Sun/8.15.2/Submit) id u29Br238009082; Wed, 9 Mar 2016 12:53:02 +0100 (CET) From: Rainer Orth To: Richard Biener Cc: James Greenhalgh , gcc-patches@gcc.gnu.org, nd@arm.com Subject: Re: [Patch testsuite] Change xfail conditions for bb-slp-34.c References: <1456998378-22605-1-git-send-email-james.greenhalgh@arm.com> Date: Wed, 09 Mar 2016 12:53:02 +0100 In-Reply-To: (Richard Biener's message of "Thu, 3 Mar 2016 11:05:38 +0100 (CET)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Richard Biener writes: > On Thu, 3 Mar 2016, James Greenhalgh wrote: > >> >> Hi, >> >> ARM and AArch64 will still vectorize bb-slp-34.c - we're not operating >> with a cost model so we vectorize to a 64-bit vector of two ints, and the >> permutes are just element swaps. >> >> So, don't mark this test xfail for arm/aarch64. >> >> Checked on x86_64-none-linux-gnu, arm-none-eabi and aarch64-none-elf with >> no issues. >> >> OK? > > Ok. Indeed with using V2SI vectors the vectorization is valid. Unfortunately, the patch broke the test on sparc: FAIL: gcc.dg/vect/bb-slp-34.c -flto -ffat-lto-objects scan-tree-dump slp2 "basic block vectorized" FAIL: gcc.dg/vect/bb-slp-34.c scan-tree-dump slp2 "basic block vectorized" While before the scan-tree-dump wasn't run due to missing vect_perm support, it now fails. I believe you meant to just not xfail the test on aarch64* and arm*, which is what the following patch does. James, could you please test it? Thanks. Rainer 2016-03-09 Rainer Orth * gcc.dg/vect/bb-slp-34.c: Really don't xfail on aarch64-*-*, arm-*-*. # HG changeset patch # Parent 2b37d3d00ad8084dfecd2fc2165d20fffc47e5bf Really don't xfail gcc.dg/vect/bb-slp-34.c on aarch64, arm diff --git a/gcc/testsuite/gcc.dg/vect/bb-slp-34.c b/gcc/testsuite/gcc.dg/vect/bb-slp-34.c --- a/gcc/testsuite/gcc.dg/vect/bb-slp-34.c +++ b/gcc/testsuite/gcc.dg/vect/bb-slp-34.c @@ -33,4 +33,4 @@ int main() } /* ??? XFAILed because we access "excess" elements with the permutation. */ -/* { dg-final { scan-tree-dump "basic block vectorized" "slp2" { xfail { { vect_perm } && { ! { aarch64*-*-* arm*-*-* } } } } } } */ +/* { dg-final { scan-tree-dump "basic block vectorized" "slp2" { target vect_perm xfail { ! { aarch64*-*-* arm*-*-* } } } } } */