| Message ID | ydd7eb9kmya.fsf@CeBiTec.Uni-Bielefeld.DE |
|---|---|
| State | New |
| Headers | show |
| Series | [testsuite,i386] Restrict gcc.target/i386/spellcheck-options-5.c to Linux targets | expand |
On Thu, May 02, 2019 at 03:25:33PM +0200, Rainer Orth wrote: > The new gcc.target/i386/spellcheck-options-5.c testcase FAILs on all > non-Linux targets (seen on i386-pc-solaris2.11, but there are also > gcc-testresults reports for freebsd and darwin): > > +FAIL: gcc.target/i386/spellcheck-options-5.c (test for errors, line ) > +FAIL: gcc.target/i386/spellcheck-options-5.c (test for excess errors) > > This happens for both 32 and 64-bit on trunk and gcc-9 branch. > > Excess errors: > xgcc: error: unrecognized command line option '-mandroidX' > > That option is only defined in linux-android.h, and the only x86 targets > including that file according to config.gcc are > > i[34567]86-*-linux* | i[34567]86-*-kfreebsd*-gnu | i[34567]86-*-gnu* | i[34567]86-*-kopensolaris*-gnu > x86_64-*-linux* | x86_64-*-kfreebsd*-gnu > > So it seems natural to restrict the test to *-*-linux* and *-*-gnu* > targets, which is what the following patch does. > > Tested on i386-pc-solaris2.11 (where it now comes up UNSUPPORTED) and > x86_64-pc-linux-gnu (where it still PASSes) on the gcc-9 branch. > > Ok for mainline and gcc-9 branch? > 2019-05-02 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> > > * gcc.target/i386/spellcheck-options-5.c: Restrict to Linux and > GNU targets. Ok, thanks. > --- a/gcc/testsuite/gcc.target/i386/spellcheck-options-5.c > +++ b/gcc/testsuite/gcc.target/i386/spellcheck-options-5.c > @@ -1,5 +1,5 @@ > /* PR middle-end/90258. */ > > -/* { dg-do compile } */ > +/* { dg-do compile { target *-*-linux* *-*-gnu* } } */ > /* { dg-options "-mandroidX" } */ > /* { dg-error "unrecognized command line option '-mandroidX'; did you mean '-mandroid'" "" { target *-*-* } 0 } */ Jakub
# HG changeset patch # Parent 3c0a67b376bc087a5e7088ec27a543bb94d9f4fb Restrict gcc.target/i386/spellcheck-options-5.c to Linux targets diff --git a/gcc/testsuite/gcc.target/i386/spellcheck-options-5.c b/gcc/testsuite/gcc.target/i386/spellcheck-options-5.c --- a/gcc/testsuite/gcc.target/i386/spellcheck-options-5.c +++ b/gcc/testsuite/gcc.target/i386/spellcheck-options-5.c @@ -1,5 +1,5 @@ /* PR middle-end/90258. */ -/* { dg-do compile } */ +/* { dg-do compile { target *-*-linux* *-*-gnu* } } */ /* { dg-options "-mandroidX" } */ /* { dg-error "unrecognized command line option '-mandroidX'; did you mean '-mandroid'" "" { target *-*-* } 0 } */