From patchwork Tue Jul 6 17:16:53 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 58048 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 9D960B6EF2 for ; Wed, 7 Jul 2010 03:17:11 +1000 (EST) Received: (qmail 16817 invoked by alias); 6 Jul 2010 17:17:09 -0000 Received: (qmail 16807 invoked by uid 22791); 6 Jul 2010 17:17:08 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL, BAYES_00, TW_OV, TW_VD, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Jul 2010 17:17:00 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 64BAB6C1; Tue, 6 Jul 2010 19:16:56 +0200 (CEST) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id NUW3lx5OqUxN; Tue, 6 Jul 2010 19:16:54 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 46F706C0; Tue, 6 Jul 2010 19:16:54 +0200 (CEST) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.3+Sun/8.14.3/Submit) id o66HGr4V028077; Tue, 6 Jul 2010 19:16:53 +0200 (MEST) From: Rainer Orth To: gcc-patches@gcc.gnu.org Cc: Uros Bizjak Subject: [testsuite] Don't use multiplication in gcc.target/x86_64/abi/asm-support.S Date: Tue, 06 Jul 2010 19:16:53 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Currently, all gcc.target/x86_64 tests fail on Solaris 10 with the Sun assembler: FAIL: gcc.target/x86_64/abi/test_3_element_struct_and_unions.c compilation, -O0 output is: Assembler: snapshot.S "/var/tmp//ccno6d7L.s", line 29 : Illegal multiplication While ugly, the obvious solution is to use the values directly instead of having the assembler do the work. Tested with runtest --tool gcc --srcdir= abi-x86_64.exp both in a tree configured to use Sun as and in another with GNU as. Ok for mainline, 4.5 and 4.4 branches? Rainer 2010-07-06 Rainer Orth * gcc.target/x86_64/abi/asm-support.S (snapshot): Replace multiplication by values. diff -r e37bf965b02b gcc/testsuite/gcc.target/x86_64/abi/asm-support.S --- a/gcc/testsuite/gcc.target/x86_64/abi/asm-support.S Mon Jul 05 20:56:54 2010 +0200 +++ b/gcc/testsuite/gcc.target/x86_64/abi/asm-support.S Tue Jul 06 19:11:15 2010 +0200 @@ -26,20 +26,20 @@ movq %r15, r15(%rip) movdqu %xmm0, xmm_regs+0(%rip) movdqu %xmm1, xmm_regs+16(%rip) - movdqu %xmm2, xmm_regs+16*2(%rip) - movdqu %xmm3, xmm_regs+16*3(%rip) - movdqu %xmm4, xmm_regs+16*4(%rip) - movdqu %xmm5, xmm_regs+16*5(%rip) - movdqu %xmm6, xmm_regs+16*6(%rip) - movdqu %xmm7, xmm_regs+16*7(%rip) - movdqu %xmm8, xmm_regs+16*8(%rip) - movdqu %xmm9, xmm_regs+16*9(%rip) - movdqu %xmm10, xmm_regs+16*10(%rip) - movdqu %xmm11, xmm_regs+16*11(%rip) - movdqu %xmm12, xmm_regs+16*12(%rip) - movdqu %xmm13, xmm_regs+16*13(%rip) - movdqu %xmm14, xmm_regs+16*14(%rip) - movdqu %xmm15, xmm_regs+16*15(%rip) + movdqu %xmm2, xmm_regs+32(%rip) + movdqu %xmm3, xmm_regs+48(%rip) + movdqu %xmm4, xmm_regs+64(%rip) + movdqu %xmm5, xmm_regs+80(%rip) + movdqu %xmm6, xmm_regs+96(%rip) + movdqu %xmm7, xmm_regs+112(%rip) + movdqu %xmm8, xmm_regs+128(%rip) + movdqu %xmm9, xmm_regs+144(%rip) + movdqu %xmm10, xmm_regs+160(%rip) + movdqu %xmm11, xmm_regs+176(%rip) + movdqu %xmm12, xmm_regs+192(%rip) + movdqu %xmm13, xmm_regs+208(%rip) + movdqu %xmm14, xmm_regs+224(%rip) + movdqu %xmm15, xmm_regs+240(%rip) jmp *callthis(%rip) .LFE3: .size snapshot, .-snapshot