| Message ID | ri634rr23d8.fsf@virgil.suse.cz |
|---|---|
| State | New |
| Headers | show |
| Series | contrib/check-params-in-docs.py: Ignore gcn-preferred-vectorization-factor | expand |
Hi! On 2024-04-11T19:52:51+0200, Martin Jambor <mjambor@suse.cz> wrote: > contrib/check-params-in-docs.py is a script that checks that all > options reported with ./gcc/xgcc -Bgcc --help=param are in > gcc/doc/invoke.texi and vice versa. Eh, first time I'm hearing about this one! (a) Shouldn't this be running as part of the GCC build process? > gcn-preferred-vectorization-factor is in the manual but normally not > reported by --help, probably because I do not have gcn offload > configured. No, because you've not been building GCC for GCN target. ;-P > This patch makes the script silently about this particular > fact. (b) Shouldn't we instead ignore any '--param's with "gcn" prefix, similar to how that's done for "skip aarch64 params"? (c) ..., and shouldn't we likewise skip any "x86" ones? (d) ..., or in fact any target specific ones, following after the generic section? (Easily achieved with a special marker in 'gcc/doc/invoke.texi', just before: The following choices of @var{name} are available on AArch64 targets: ..., and adjusting the 'takewhile' in 'contrib/check-params-in-docs.py' accordingly? Grüße Thomas > I'll push the patch as obvious momentarily. > > Martin > > > contrib/ChangeLog: > > 2024-04-11 Martin Jambor <mjambor@suse.cz> > > * check-params-in-docs.py (ignored): Add > gcn-preferred-vectorization-factor. > --- > contrib/check-params-in-docs.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/check-params-in-docs.py b/contrib/check-params-in-docs.py > index 623c82284e2..f7879dd8e08 100755 > --- a/contrib/check-params-in-docs.py > +++ b/contrib/check-params-in-docs.py > @@ -45,7 +45,7 @@ parser.add_argument('params_output') > > args = parser.parse_args() > > -ignored = {'logical-op-non-short-circuit'} > +ignored = {'logical-op-non-short-circuit', 'gcn-preferred-vectorization-factor'} > params = {} > > for line in open(args.params_output).readlines(): > -- > 2.44.0
diff --git a/contrib/check-params-in-docs.py b/contrib/check-params-in-docs.py index 623c82284e2..f7879dd8e08 100755 --- a/contrib/check-params-in-docs.py +++ b/contrib/check-params-in-docs.py @@ -45,7 +45,7 @@ parser.add_argument('params_output') args = parser.parse_args() -ignored = {'logical-op-non-short-circuit'} +ignored = {'logical-op-non-short-circuit', 'gcn-preferred-vectorization-factor'} params = {} for line in open(args.params_output).readlines():