| Message ID | nycvar.YFH.7.76.2104151300530.1259@elmra.sevgm.obk |
|---|---|
| State | New |
| Headers | show |
| Series | Deprecate gimple-builder.h API | expand |
On 4/15/21 5:01 AM, Richard Biener wrote: > This adds a deprecation note to the undocumented gimple-builder.h > API only used by asan and sancov. > > Pushed. > > 2021-04-15 Richard Biener <rguenther@suse.de> > > * gimple-builder.h: Add deprecation note. > --- > gcc/gimple-builder.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gcc/gimple-builder.h b/gcc/gimple-builder.h > index 61cf08c8dcb..ae273ce9041 100644 > --- a/gcc/gimple-builder.h > +++ b/gcc/gimple-builder.h > @@ -21,6 +21,8 @@ along with GCC; see the file COPYING3. If not see > #ifndef GCC_GIMPLE_BUILDER_H > #define GCC_GIMPLE_BUILDER_H > > +/* ??? This API is legacy and should not be used in new code. */ What do the question marks mean? (IMO, they're misleading and might make the reader wonder whether the note really means what it says.) Martin > + > gassign *build_assign (enum tree_code, tree, int, tree lhs = NULL_TREE); > gassign *build_assign (enum tree_code, gimple *, int, tree lhs = NULL_TREE); > gassign *build_assign (enum tree_code, tree, tree, tree lhs = NULL_TREE); >
On April 15, 2021 6:08:44 PM GMT+02:00, Martin Sebor <msebor@gmail.com> wrote: >On 4/15/21 5:01 AM, Richard Biener wrote: >> This adds a deprecation note to the undocumented gimple-builder.h >> API only used by asan and sancov. >> >> Pushed. >> >> 2021-04-15 Richard Biener <rguenther@suse.de> >> >> * gimple-builder.h: Add deprecation note. >> --- >> gcc/gimple-builder.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/gcc/gimple-builder.h b/gcc/gimple-builder.h >> index 61cf08c8dcb..ae273ce9041 100644 >> --- a/gcc/gimple-builder.h >> +++ b/gcc/gimple-builder.h >> @@ -21,6 +21,8 @@ along with GCC; see the file COPYING3. If not see >> #ifndef GCC_GIMPLE_BUILDER_H >> #define GCC_GIMPLE_BUILDER_H >> >> +/* ??? This API is legacy and should not be used in new code. */ > >What do the question marks mean? (IMO, they're misleading and might >make the reader wonder whether the note really means what it says.) It means the API should be removed instead which shouldn't be too hard... Richard. >Martin > > >> + >> gassign *build_assign (enum tree_code, tree, int, tree lhs = >NULL_TREE); >> gassign *build_assign (enum tree_code, gimple *, int, tree lhs = >NULL_TREE); >> gassign *build_assign (enum tree_code, tree, tree, tree lhs = >NULL_TREE); >>
diff --git a/gcc/gimple-builder.h b/gcc/gimple-builder.h index 61cf08c8dcb..ae273ce9041 100644 --- a/gcc/gimple-builder.h +++ b/gcc/gimple-builder.h @@ -21,6 +21,8 @@ along with GCC; see the file COPYING3. If not see #ifndef GCC_GIMPLE_BUILDER_H #define GCC_GIMPLE_BUILDER_H +/* ??? This API is legacy and should not be used in new code. */ + gassign *build_assign (enum tree_code, tree, int, tree lhs = NULL_TREE); gassign *build_assign (enum tree_code, gimple *, int, tree lhs = NULL_TREE); gassign *build_assign (enum tree_code, tree, tree, tree lhs = NULL_TREE);